From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
To: Kalyan Thota <kalyan_t@codeaurora.org>,
dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org,
freedreno@lists.freedesktop.org, devicetree@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, robdclark@gmail.com,
dianders@chromium.org, mkrishn@codeaurora.org
Subject: Re: [RFC] Inline rotation support in dpu driver
Date: Sun, 4 Jul 2021 11:25:44 +0300 [thread overview]
Message-ID: <5dcd850a-280c-c356-32e5-35a4fe089f4e@linaro.org> (raw)
In-Reply-To: <1625311962-14185-1-git-send-email-kalyan_t@codeaurora.org>
On 03/07/2021 14:32, Kalyan Thota wrote:
> This change adds support for inline rotation in the dpu driver.
> When inline rotation is enabled the VIG pipes will directly fetch the image
> from memory in a rotated fashion
>
> Inline rotation has following restrictions
> 1) Supported only with compressed formats
NV12, which is the only format you declare, is not compressed.
> 2) max pre rotated height is 1088
> 3) restrictions with downscaling ratio
>
> Queries:
>
> 1) Since inline rotation works for fewer pixel formats with specific modifier, how can we provide this information to the compositor so that
> chrome compositor can choose between overlaying or falling back to GPU. In the patch it fails in the atomic check.
>
> 2) If a display composition fails in atomic check due to any of the restrictions in overlays
> can chrome compositor switch it back to the GPU and re trigger the commit ?
>
> posting it as RFC as validation is not complete, please share early comments on this.
>
> Kalyan Thota (1):
> drm/msm/disp/dpu1: add support for inline rotation in dpu driver
>
> drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 47 +++++++++----
> drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h | 20 ++++++
> drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 93 ++++++++++++++++++++------
> drivers/gpu/drm/msm/disp/dpu1/dpu_plane.h | 2 +
> 4 files changed, 128 insertions(+), 34 deletions(-)
>
--
With best wishes
Dmitry
next prev parent reply other threads:[~2021-07-04 8:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-03 11:32 [RFC] Inline rotation support in dpu driver Kalyan Thota
2021-07-03 18:26 ` Rob Clark
2021-07-04 8:25 ` Dmitry Baryshkov [this message]
2021-07-04 18:17 ` Rob Clark
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5dcd850a-280c-c356-32e5-35a4fe089f4e@linaro.org \
--to=dmitry.baryshkov@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=kalyan_t@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mkrishn@codeaurora.org \
--cc=robdclark@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).