From: Arnaud Ferraris <arnaud.ferraris@collabora.com>
To: Mark Brown <broonie@kernel.org>
Cc: kernel@collabora.com, Liam Girdwood <lgirdwood@gmail.com>,
Rob Herring <robh+dt@kernel.org>, Timur Tabi <timur@kernel.org>,
Nicolin Chen <nicoleotsuka@gmail.com>,
Xiubo Li <Xiubo.Lee@gmail.com>,
Fabio Estevam <festevam@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
alsa-devel@alsa-project.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH 1/2] dt-bindings: sound: fsl-asoc-card: add new compatible for I2S slave
Date: Thu, 2 Jul 2020 17:28:03 +0200 [thread overview]
Message-ID: <5de5ea5b-0716-8ed1-28b0-9ad3da7a2d47@collabora.com> (raw)
In-Reply-To: <20200702143145.GG4483@sirena.org.uk>
Hi Mark,
Le 02/07/2020 à 16:31, Mark Brown a écrit :
> On Thu, Jul 02, 2020 at 04:11:14PM +0200, Arnaud Ferraris wrote:
>> fsl-asoc-card currently doesn't support generic codecs with the SoC
>> acting as I2S slave.
>>
>> This commit adds a new `fsl,imx-audio-i2s-slave` for this use-case, as
>> well as the following mandatory properties:
>
> Why require that the CODEC be clock master here - why not make this
> configurable, reusing the properties from the generic and audio graph
> cards?
This is partly because I'm not sure how to do it (yet), but mostly
because I don't have the hardware to test this (the 2 CODECs present on
my only i.MX6 board are both clock master)
Regards,
Arnaud
next prev parent reply other threads:[~2020-07-02 15:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-02 14:11 [PATCH 0/2] ASoC: fsl-asoc-card: add support for generic codecs Arnaud Ferraris
2020-07-02 14:11 ` [PATCH 1/2] dt-bindings: sound: fsl-asoc-card: add new compatible for I2S slave Arnaud Ferraris
2020-07-02 14:31 ` Mark Brown
2020-07-02 15:28 ` Arnaud Ferraris [this message]
2020-07-02 15:42 ` Mark Brown
2020-07-03 9:23 ` Arnaud Ferraris
2020-07-02 14:11 ` [PATCH 2/2] ASoC: fsl-asoc-card: add support for generic I2S slave use-case Arnaud Ferraris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5de5ea5b-0716-8ed1-28b0-9ad3da7a2d47@collabora.com \
--to=arnaud.ferraris@collabora.com \
--cc=Xiubo.Lee@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@collabora.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=nicoleotsuka@gmail.com \
--cc=perex@perex.cz \
--cc=robh+dt@kernel.org \
--cc=timur@kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).