From: Thomas Huth <thuth@redhat.com>
To: Christian Borntraeger <borntraeger@de.ibm.com>,
Cornelia Huck <cohuck@redhat.com>
Cc: Farhan Ali <alifm@linux.vnet.ibm.com>,
linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org,
linux-fbdev@vger.kernel.org, geert@linux-m68k.org,
tomi.valkeinen@ti.com, b.zolnierkie@samsung.com
Subject: Re: [PATCH v3 1/3] Kconfig : Remove HAS_IOMEM dependency for Graphics support
Date: Wed, 21 Feb 2018 12:29:19 +0100 [thread overview]
Message-ID: <5dfa9213-0e63-54d0-8700-1ced4efd4c28@redhat.com> (raw)
In-Reply-To: <1f8907d4-c4a3-d41b-8834-679dcc85de4a@de.ibm.com>
On 21.02.2018 12:22, Christian Borntraeger wrote:
>
>
> On 02/21/2018 12:14 PM, Thomas Huth wrote:
>> On 21.02.2018 12:09, Christian Borntraeger wrote:
>>>
>>>
>>> On 02/21/2018 11:32 AM, Cornelia Huck wrote:
>>>> On Wed, 21 Feb 2018 11:22:38 +0100
>>>> Christian Borntraeger <borntraeger@de.ibm.com> wrote:
>>>>
>>>>> On 02/21/2018 11:05 AM, Christian Borntraeger wrote:
>>>>>>
>>>>>>
>>>>>> On 02/19/2018 05:38 PM, Farhan Ali wrote:
>>>>>>>
>>>>>>>
>>>>>>> On 02/19/2018 11:25 AM, Thomas Huth wrote:
>>>>>>>> On 19.02.2018 16:47, Farhan Ali wrote:
>>>>>>>>> The 'commit e25df1205f37 ("[S390] Kconfig: menus with depends on HAS_IOMEM.")'
>>>>>>>>> added the HAS_IOMEM dependecy for "Graphics support". This disabled the
>>>>>>>>> "Graphics support" menu for S390. But if we enable VT layer for S390,
>>>>>>>>> we would also need to enable the dummy console. So let's remove the
>>>>>>>>> HAS_IOMEM dependency.
>>>>>>>>>
>>>>>>>>> Move this dependency to sub menu items and console drivers that use
>>>>>>>>> io memory.
>>>>>>>>>
>>>>>>>>> Signed-off-by: Farhan Ali <alifm@linux.vnet.ibm.com>
>>>>>>>>> ---
>>>>>>>>> drivers/video/Kconfig | 21 +++++++++++----------
>>>>>>>>> drivers/video/console/Kconfig | 4 ++--
>>>>>>>>> 2 files changed, 13 insertions(+), 12 deletions(-)
>>>>>>>>>
>>>>>>>>> diff --git a/drivers/video/Kconfig b/drivers/video/Kconfig
>>>>>>>>> index 3c20af9..8f10915 100644
>>>>>>>>> --- a/drivers/video/Kconfig
>>>>>>>>> +++ b/drivers/video/Kconfig
>>>>>>>>> @@ -3,7 +3,6 @@
>>>>>>>>> #
>>>>>>>>> menu "Graphics support"
>>>>>>>>> - depends on HAS_IOMEM
>>>>>>>>> config HAVE_FB_ATMEL
>>>>>>>>> bool
>>>>>>>>> @@ -11,20 +10,22 @@ config HAVE_FB_ATMEL
>>>>>>>>> config SH_LCD_MIPI_DSI
>>>>>>>>> bool
>>>>>>>>> -source "drivers/char/agp/Kconfig"
>>>>>>>>> +if HAS_IOMEM
>>>>>>>>> + source "drivers/char/agp/Kconfig"
>>>>>>>>> -source "drivers/gpu/vga/Kconfig"
>>>>>>>>> + source "drivers/gpu/vga/Kconfig"
>>>>>>>>> -source "drivers/gpu/host1x/Kconfig"
>>>>>>>>> -source "drivers/gpu/ipu-v3/Kconfig"
>>>>>>>>> + source "drivers/gpu/host1x/Kconfig"
>>>>>>>>> + source "drivers/gpu/ipu-v3/Kconfig"
>>>>>>>>> -source "drivers/gpu/drm/Kconfig"
>>>>>>>>> + source "drivers/gpu/drm/Kconfig"
>>>>>>
>>>>>>
>>>>>> Hmmm, looks like that this makes it impossible to select VIRTIO_GPU - need still more
>>>>>> work.
>>>>>>
>>>>> Sorry my fault. I had CONFIG_PCI disabled.
>>>>
>>>> That smells like the s390 HAS_IOMEM stuff needs more work -- I guess
>>>> that you want to enable a ccw virtio-gpu device, not a pci one, right?
>>>
>>> It is a ccw virtio-gpu. But s390 has no IOMEM without CONFIG_PCI, so you cannot
>>> select VIRTIO_GPU, which needs DRM, which need IOMEM.
>>
>> So the 'source "drivers/gpu/drm/Kconfig"' should maybe rather reside
>> outside of the "if HAS_IOMEM" path? Or does it not compile anymore that way?
>
> virtio-gpu depends on drm. So in essence it boils down to if you want virtio-gpu
> you also need to enable PCI, even if the actual channel is ccw.
But if you need to enable PCI to get IOMEM, I wonder why this patch here
is needed at all? The Graphics menu / VT dummy console should be
available in the config if IOMEM is enabled anyway?
Thomas
next prev parent reply other threads:[~2018-02-21 11:29 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-19 15:47 [PATCH v3 0/3] Enable CONFIG_VT support for S390 Farhan Ali
2018-02-19 15:47 ` [PATCH v3 1/3] Kconfig : Remove HAS_IOMEM dependency for Graphics support Farhan Ali
2018-02-19 16:25 ` Thomas Huth
2018-02-19 16:38 ` Farhan Ali
2018-02-21 10:05 ` Christian Borntraeger
2018-02-21 10:22 ` Christian Borntraeger
2018-02-21 10:32 ` Cornelia Huck
2018-02-21 11:09 ` Christian Borntraeger
2018-02-21 11:14 ` Thomas Huth
2018-02-21 11:22 ` Christian Borntraeger
2018-02-21 11:29 ` Thomas Huth [this message]
2018-02-21 11:49 ` Christian Borntraeger
2018-02-21 12:07 ` Cornelia Huck
2018-02-21 12:11 ` Christian Borntraeger
2018-02-21 16:39 ` Farhan Ali
2018-02-22 7:34 ` Christian Borntraeger
2018-02-21 11:23 ` Cornelia Huck
2018-02-21 8:44 ` Christian Borntraeger
2018-02-21 11:50 ` Bartlomiej Zolnierkiewicz
2018-02-19 15:47 ` [PATCH v3 2/3] s390/char : Rename EBCDIC keymap variables Farhan Ali
2018-02-19 19:52 ` Thomas Huth
2018-02-19 15:47 ` [PATCH v3 3/3] s390/setup : enable display support for KVM guest Farhan Ali
2018-02-19 19:55 ` Thomas Huth
2018-02-20 9:43 ` [PATCH v3 0/3] Enable CONFIG_VT support for S390 Christian Borntraeger
2018-02-20 13:45 ` Farhan Ali
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5dfa9213-0e63-54d0-8700-1ced4efd4c28@redhat.com \
--to=thuth@redhat.com \
--cc=alifm@linux.vnet.ibm.com \
--cc=b.zolnierkie@samsung.com \
--cc=borntraeger@de.ibm.com \
--cc=cohuck@redhat.com \
--cc=geert@linux-m68k.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).