From: Markus Elfring <Markus.Elfring@web.de>
To: Lai Jiangshan <jiangshanlai@gmail.com>,
Zhang Qiang <qiang.zhang@windriver.com>
Cc: Tejun Heo <tj@kernel.org>, LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: [v3] workqueue: Fix double kfree for rescuer
Date: Tue, 26 May 2020 11:11:40 +0200 [thread overview]
Message-ID: <5e1582ac-2f89-80cb-283d-57ba5003890f@web.de> (raw)
In-Reply-To: <CAJhGHyC4XcNL8yzWZKZ=73wZJej4JwCaAHGV8qjYn-AqcEAEjQ@mail.gmail.com>
> wq->rescuer is guaranteed to be NULL in rcu_free_wq()
I was unsure about this data processing detail.
> The patch is a cleanup to remove a "kfree(NULL);".
I would prefer also an improved commit message according to
the understanding of the software situation in this direction.
Regards,
Markus
next prev parent reply other threads:[~2020-05-26 9:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-25 9:30 [PATCH v3] workqueue: Fix double kfree for rescuer qiang.zhang
2020-05-25 10:01 ` Markus Elfring
2020-05-25 10:01 ` Markus Elfring
2020-05-26 8:56 ` Lai Jiangshan
2020-05-26 9:11 ` Markus Elfring [this message]
2020-05-26 10:04 ` Zhang, Qiang
2020-05-26 10:34 ` [v3] " Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5e1582ac-2f89-80cb-283d-57ba5003890f@web.de \
--to=markus.elfring@web.de \
--cc=jiangshanlai@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=qiang.zhang@windriver.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).