From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933028AbcKPRKT (ORCPT ); Wed, 16 Nov 2016 12:10:19 -0500 Received: from mail-dm3nam03on0073.outbound.protection.outlook.com ([104.47.41.73]:31776 "EHLO NAM03-DM3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751652AbcKPRKR (ORCPT ); Wed, 16 Nov 2016 12:10:17 -0500 X-Greylist: delayed 155706 seconds by postgrey-1.27 at vger.kernel.org; Wed, 16 Nov 2016 12:10:17 EST Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=alex.g@adaptrum.com; Subject: Re: [PATCH v2] net/phy/vitesse: Configure RGMII skew on VSC8601, if needed To: Andrew Lunn References: <20161115.221217.2076182289174952941.davem@davemloft.net> <1479286953-11481-1-git-send-email-alex.g@adaptrum.com> <20161116135053.GF19962@lunn.ch> <20161116165437.GK23231@lunn.ch> CC: , , , , Gokhan Cosgul From: Alex Message-ID: <5e39aae8-dd47-8167-70a5-3fe379168cd4@adaptrum.com> Date: Wed, 16 Nov 2016 09:10:02 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <20161116165437.GK23231@lunn.ch> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [166.137.176.162] X-ClientProxiedBy: BN6PR1601CA0019.namprd16.prod.outlook.com (10.172.104.157) To BY1PR0401MB1175.namprd04.prod.outlook.com (10.160.194.149) X-Microsoft-Exchange-Diagnostics: 1;BY1PR0401MB1175;2:Y6Rhd0a2ODpDxNjlQ7t6in3B8JMV+ivh6EWeEYOLf1wdRrBIGUVMhja658FDpzQM5gVurjqZaiZ0x/V++STCH89x9mLPePz0/FXRl97OM8JD5kY+f4ODr3cgzUDyjMpt0N2Jkp54ajeKnQY0yVRXf+F9sqqm4+qORj+pq4uEVrY=;3:tgsS7DKFOA8azUsdaSjaqcpH7TDL5e3IrGXw7T2UgOY+vEpMNvvkWmK+xRCcxwSprQU1j0xvd9c8FjebgJ5tDWF0zgkYbdd6XEsscJthZ3yCbIX4zeGBbd+MZ5OZ0uET/DLyCCpSZ0VncqXvPiFj2zLDgJBuBgwDKzTHYsAe2MU=;25:PmTQV5WBtx+fdts38K/PKhqXIkaL9NHmc83dJm0ogardxLzhX+C1lS3pwbxJwZobyhxU+08lTyHX9HYDNd1Zy0pVHPQqCyjmbe2YoNh7omKCyMp+KxvpXImi3jmI2KJpnK3Oy7DPVcrqAy85WYc+pes791JV8N3sxnCvxiF+ZtBtFr5ytjkfBYzzJ6L02DoX7/PloOF5xFo9xfpxYmNLOxWAZ9FnhjIYD4peurthu2Uv0n2PI4nQ9+rgbA17nqC1fUj5zEVcWaAQxKJSRHQpr+DcLt+OXJ/KKjvO3lqjCAQ74/AAXPYfXktE7aaii6E2/Kpd2K9Z4C+NxYiObsmALX13YLT2JRgL7/R+7Cdgl68Syl4vhfgQxZ4qIW51QS+N6aSKQmNSCKJGX+VwrurSG+EwgKCeT3Dmlmn5FIrAlwkKPFUKuR3BhAYD6rLH9+0OWBGd6ARlYzIeAJKXDWHw4Q== X-MS-Office365-Filtering-Correlation-Id: 9972672b-6454-4e91-0865-08d40e436cce X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001);SRVR:BY1PR0401MB1175; X-Microsoft-Exchange-Diagnostics: 1;BY1PR0401MB1175;31:e5k3oFLxamaJ7jCI9DqMXZMtxLtX6MUEK4ms+yokk8QIkelFAwBPJAr0scF1Bl7YqiqT5ltkwQcwrDbkWbut3Cx0Gd5AHYKTNT1Urw2439docRryDHJqx5U9vYhw8xw6snKgih0aaxrYk6l2afO+7aoGBxr0tvMSzroh6iBt6s2FKGlSfsDV7nD+gE/rvysXsh3g9sRMX80A+X0tHkOUaBIxXvGEWbZzxgqwkd+1UZqHkc5U1alia87dkUP4qWHGQlBeGJv0mcv0v4ajZHTlDA==;4:pxJNLYpIUIF4iZuHrzeqowBaoWfJERZqmuz7YRhf9otK8T21XiQKJXockz6CdRpVZ0xKD1yXDaJyrqar33GFTiv9KKr0krnoWlFzl7Cp3+WtkWk+HGEWvDBlks5fOR2ar75Zz+XOzFr0PbPqqs5QZ5Fvx6vq66CVx4Me05UcDNqd5WQwfRCnZPWNSb5Ahxty+LloWD4uL1TRHpiPM8n9BL6FvMpd2AAqIVxcEFQ6YkUfBwc+B2HkardzNWtVsDxE99cWLSOZ0Bq7ItbikAxuqolIg40OLi1H6DPbE8NFTgWy5rfcevn2Kbhfdlox3cp79qI1aeBH2BdVL9vqRj4hP3hfLo5rER9SVwrcAnm00RXoUKOeTdQinXuCRj45nbpV/pFxFrN5ld3+jLF2sK9y2lciJn17VBY1qehqQDr8vv9LtbqqWqU8nRQkDyuD2mDWaonQ/TxLHB1nSmrTUhYhvcE4WgGIXuJ2I+YsYo2BKHg= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6060326)(6040281)(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046)(6061324)(6041223)(6043046);SRVR:BY1PR0401MB1175;BCL:0;PCL:0;RULEID:;SRVR:BY1PR0401MB1175; X-Forefront-PRVS: 01283822F8 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(7916002)(24454002)(377454003)(199003)(189002)(92566002)(8676002)(101416001)(7846002)(54356999)(33646002)(7736002)(230700001)(305945005)(81166006)(68736007)(64126003)(81156014)(50466002)(50986999)(76176999)(97736004)(105586002)(23746002)(6116002)(31686004)(4001350100001)(42186005)(189998001)(107886002)(6666003)(4326007)(106356001)(77096005)(4001430100002)(93886004)(2906002)(3846002)(6916009)(65826007)(229853002)(31696002)(36756003)(5660300001)(2950100002)(65956001)(47776003)(83506001)(66066001)(86362001)(65806001)(110136003);DIR:OUT;SFP:1101;SCL:1;SRVR:BY1PR0401MB1175;H:nuke-mobile.adaptrum;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;BY1PR0401MB1175;23:ZL4WTIPoMy4VTio4ELlQ/nzJdCcrLWFMf9S?= =?Windows-1252?Q?59LPsszkJryHLlzOIJ/0KRuYCCMY+CfX5YuCJ+/P3v3akrREEAhvnjIu?= =?Windows-1252?Q?cTuGkeP/e5xcairxPZeIQEXk0pppHfkPE0frioXz2TAMCBDT7Y1/ply+?= =?Windows-1252?Q?kxolyOrlZJ7CnpGCHyXCdJovz30tNbR7YZAzozUnEXZ2tRBTDkuQdiRa?= =?Windows-1252?Q?6XviQUAqn6kNVVxOB6KPcYIFrLgLhCPuYn6VfnhL9x/eb3hGnY1kgk4s?= =?Windows-1252?Q?CyVUWWMsp1O9H1+942lRdHs3+yGzUK4LkDiHU3qZlbx2G9xi0Ps5PIg3?= =?Windows-1252?Q?lzuf0K0xfoDkXJeBcqyPJQQ1xr4cSg6AcHfQvOabDLwdYAiOk0VzHXj+?= =?Windows-1252?Q?uX/fZqa9UGlpE8EHD3PZXkNzFPKWL09P1t3nDQ/5dG8RM24VCVusgzaf?= =?Windows-1252?Q?qqcXyO21xT6rhE/HVZAetXwjq8hcOm+npDk9+eQsc2C310OfYewK9EWp?= =?Windows-1252?Q?NeVhnCRJfz26qjdVZlt7Aojtn/BDuadrUg/h4ypDl90gd2k6PIgsmTrh?= =?Windows-1252?Q?e1131H60qLsSj6sp5JdRY+MOXNPB+LIkcckQzvuI3QbCxqtZ99Li9pTJ?= =?Windows-1252?Q?29Yv9G1f84W9gilC9NpRk1x1ox0ODlxdgWqXwEenJdVhA94JDJuA77db?= =?Windows-1252?Q?PA1lrJXlmzSljvlPWUSlragjutdESM+70EZ90a+OiH+k8STY/7MyXtp6?= =?Windows-1252?Q?hZ4bqUjG1gOiUQgVfhrhmLyYAzGGYWePsMF9MZVXCHUtP0NXBLIJCSBm?= =?Windows-1252?Q?ysbssRFzmy7dWfNgwiV0l7luCbcRykldJFNM8rQymqNkPoLDmFSgBAmY?= =?Windows-1252?Q?qDKXQm9xL0jeiEXi4NGdK44xGTsblvBT3fzMd8a2E0QhBK5QRYda2ucX?= =?Windows-1252?Q?fkoeQQ3rJNt5R7T2JzU9fPJc5UuUZxN02v4Wgsjv9BmeIOFvh2FLDLM6?= =?Windows-1252?Q?3wjnQMwGyBHG7VpHhhkuMy8dY7lsFDFDIgzrwD4NFIgG64NIxDDAqJdZ?= =?Windows-1252?Q?rCAdQ24Bu+UaY9Oy4eKonpN2tjwCcPrcAa9IyJQhSWBkXK2kcOBi4VXL?= =?Windows-1252?Q?TGDk1uFS/kxx2njx8v78VgnZrK1Dwi/t07IbXJk/AgClXh/0XmrEtJBj?= =?Windows-1252?Q?5qfdIR+0TVc5jXDKw0GiPj2ffkVWdlHqdDk7IoQGVLZI3nRd6pG6fJuq?= =?Windows-1252?Q?5F/FdCz4XewMcHkctuk08PwJ1SoG6l8AFnEvLBNBYmt9Lk6wPPbuFvJY?= =?Windows-1252?Q?7qudgK19c0ZXE81uB6jzy3kniWJoj8Z/3kEytT0SFV4/zbhmwiNl8C/p?= =?Windows-1252?Q?uhnfr/sgdGKh2RuSqTYlxbrpz5i8S+C3+iA=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1;BY1PR0401MB1175;6:eJzRZUniJEU0c2+6Y7x7jKpqDrVAIFHbK21CLJEWSCIbrSanUZT9a5FxdggtlAAna+octTNIXsv70iUMVvCjNFNXL2IGQZcoDRkdBfd+scM3AOlSkJWCzLr4ptazu56bHvZ+sOCPpJXxQvMDCe5XpFln0e56KIbFzb0E1msdhTviDSl/tRcRehG1+aZ7aUusZ+//zvXCXe0wJ/2OVnhfznChucSD0XIB9uURcIYL9ibWA2JnBKffX+Dd1aPGZftuRObHcYCqELbXrS6RWl0N0XNXNsUpFYtL6DDxsYpWXKYX7EzlokV3W2xM9AjPB1v1jUtuA/+lfPfPutC7psCEGm23zyIn091OEWvTfbqIuAE6qYUqxWQmk3+2/5UJ+7/N;5:sKfyr6S9D05PSXckt9qzJaWDwafcAqK1d8J2D91mMtcQe8adVRNN/T7lxSOFu31WTKA80qOEs/D4mlifbHm65pMMhxxmWju6pH9yT+mhJm5F2VBHw05SBG6A5n1WAf+At8R3ya3nr5cClkgvthjwz1s/hhPTu2+6Kt8RS3+LkS4=;24:mm29xd2ScZ5n4Ze2PqOTP/GNc6tV6YaiH4uPSJih/ZrrMyZKrh6k1dh/FNWI0y9t/JCn6tO2zTJArJsXCGq49au39c4uqjme3v8OelCq26U= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;BY1PR0401MB1175;7:hhs1LX2aEsahSVN0mSVkdNK/aR1XR4JCTlL5e/F2T0x+op+Btjy91r3iQ5A0IOf7qXf9sORlCqCWSJfHX0RjVV8U5On/pvD6Sa9OZ26w4ta2ecT3g6aKargwSZiOAsFxr+IMSa3XOVbzgZZ9vGrh/kwes5mPE7KPg6WyGQ2n/kKW4PGtZBgjg/LrIUTfHcM7W1CFN242FOD+uSyl0VSpSduBKeqyEsSW7hgwKDTwgZZ1ZZ8Wcog8TKiXsIwq39c2yW0XApdD1mP1vMUMXypeQ5MV++DycjIsoodZOblrJ+dInh+0cMrUbYZZ000Q4u0NdWdBj/84cWIlnmTn3Vqsz0d3rdDKRrCyu1LLwQ3BOsU= X-OriginatorOrg: adaptrum.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Nov 2016 17:10:09.4734 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY1PR0401MB1175 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/16/2016 08:54 AM, Andrew Lunn wrote: > On Wed, Nov 16, 2016 at 08:44:30AM -0800, Alex wrote: >> >> >> On 11/16/2016 05:50 AM, Andrew Lunn wrote: >>> On Wed, Nov 16, 2016 at 01:02:33AM -0800, Alexandru Gagniuc wrote: >>>> With RGMII, we need a 1.5 to 2ns skew between clock and data lines. The >>>> VSC8601 can handle this internally. While the VSC8601 can set more >>>> fine-grained delays, the standard skew settings work out of the box. >>>> The same heuristic is used to determine when this skew should be enabled >>>> as in vsc824x_config_init(). >>>> >>>> +/* This adds a skew for both TX and RX clocks, so the skew should only be >>>> + * applied to "rgmii-id" interfaces. It may not work as expected >>>> + * on "rgmii-txid", "rgmii-rxid" or "rgmii" interfaces. */ >>> >>> Hi Alexandru >>> >>> You should be able to make "rgmii" work as expected. If that is the >>> phy mode, disable the skew. >> >> And that's exactly the implemented behavior. See >> vsc8601_config_init() below. > > I don't think so. vsc8601_config_init() will not cause the skew to be > cleared if the phy-mode is "rgmii" and something else like the > bootloader could of set the skew. So saying that "rgmii" might not > work as expected is true. But with a minor change, you can make it > work as expected. That's not within the scope of this change. The scope is to make rgmii-id work. Any additional changes would be untested. Alex