From: Stephen Boyd <swboyd@chromium.org>
To: Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Kiran Gunda <kgunda@codeaurora.org>,
Lee Jones <lee.jones@linaro.org>,
Mark Rutland <mark.rutland@arm.com>,
Rob Herring <robh+dt@kernel.org>,
devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: rnayak@codeaurora.org, Kiran Gunda <kgunda@codeaurora.org>
Subject: Re: [PATCH V3 2/2] mfd: qcom-spmi-pmic: Add support for pm6150 and pm6150l
Date: Thu, 06 Feb 2020 11:08:04 -0800 [thread overview]
Message-ID: <5e3c6415.1c69fb81.11c79.08a6@mx.google.com> (raw)
In-Reply-To: <1580997328-16365-2-git-send-email-kgunda@codeaurora.org>
Quoting Kiran Gunda (2020-02-06 05:55:27)
> Add the compatibles and PMIC ids for pm6150 and pm6150l PMICs
> found on SC7180 based platforms
>
> Signed-off-by: Kiran Gunda <kgunda@codeaurora.org>
> ---
> Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml | 2 ++
> drivers/mfd/qcom-spmi-pmic.c | 4 ++++
> 2 files changed, 6 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
> index affc169..36f0795 100644
> --- a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
> +++ b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
> @@ -46,6 +46,8 @@ properties:
> - qcom,pm8998
> - qcom,pmi8998
> - qcom,pm8005
> + - qcom,pm6150
> + - qcom,pm6150l
> - qcom,spmi-pmic
Maybe the yaml binding needs to say this is sorted in subtype id in a
comment.
# Sorted based on subtype ID the device reports
Or we should sort this list in the binding and sort the compatible
string table in the driver with a comment that it's sorted based on
subtype id.
>
> reg:
> diff --git a/drivers/mfd/qcom-spmi-pmic.c b/drivers/mfd/qcom-spmi-pmic.c
> index 1df1a27..5bfeec8 100644
> --- a/drivers/mfd/qcom-spmi-pmic.c
> +++ b/drivers/mfd/qcom-spmi-pmic.c
> @@ -36,6 +36,8 @@
> #define PM8998_SUBTYPE 0x14
> #define PMI8998_SUBTYPE 0x15
> #define PM8005_SUBTYPE 0x18
> +#define PM6150L_SUBTYPE 0x1F
> +#define PM6150_SUBTYPE 0x28
>
> static const struct of_device_id pmic_spmi_id_table[] = {
> { .compatible = "qcom,spmi-pmic", .data = (void *)COMMON_SUBTYPE },
> @@ -57,6 +59,8 @@ static const struct of_device_id pmic_spmi_id_table[] = {
> { .compatible = "qcom,pm8998", .data = (void *)PM8998_SUBTYPE },
> { .compatible = "qcom,pmi8998", .data = (void *)PMI8998_SUBTYPE },
> { .compatible = "qcom,pm8005", .data = (void *)PM8005_SUBTYPE },
> + { .compatible = "qcom,pm6150l", .data = (void *)PM6150L_SUBTYPE },
> + { .compatible = "qcom,pm6150", .data = (void *)PM6150_SUBTYPE },
> { }
> };
next prev parent reply other threads:[~2020-02-06 19:08 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-06 13:55 [PATCH V3 1/2] mfd: qcom-spmi-pmic: Convert bindings to .yaml format Kiran Gunda
2020-02-06 13:55 ` [PATCH V3 2/2] mfd: qcom-spmi-pmic: Add support for pm6150 and pm6150l Kiran Gunda
2020-02-06 19:08 ` Stephen Boyd [this message]
2020-02-07 5:59 ` kgunda
2020-02-06 19:06 ` [PATCH V3 1/2] mfd: qcom-spmi-pmic: Convert bindings to .yaml format Stephen Boyd
2020-02-06 22:06 ` Rob Herring
2020-02-07 6:46 ` kgunda
2020-02-07 5:57 ` kgunda
2020-10-02 21:45 ` Stephen Boyd
2020-10-21 15:09 ` kgunda
2020-12-17 11:38 [PATCH V3 0/2] Convert qcom,spmi-pmic bindings from .txt to .yaml Kiran Gunda
2020-12-17 11:38 ` [PATCH V3 2/2] mfd: qcom-spmi-pmic: Add support for pm6150 and pm6150l Kiran Gunda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5e3c6415.1c69fb81.11c79.08a6@mx.google.com \
--to=swboyd@chromium.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=kgunda@codeaurora.org \
--cc=lee.jones@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=rnayak@codeaurora.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).