From: Waiman Long <longman@redhat.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Tejun Heo <tj@kernel.org>, Li Zefan <lizefan@huawei.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Ingo Molnar <mingo@redhat.com>,
cgroups@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-doc@vger.kernel.org, kernel-team@fb.com, pjt@google.com,
luto@amacapital.net, Mike Galbraith <efault@gmx.de>,
torvalds@linux-foundation.org, Roman Gushchin <guro@fb.com>,
Juri Lelli <juri.lelli@redhat.com>,
Patrick Bellasi <patrick.bellasi@arm.com>,
Tom Hromatka <tom.hromatka@oracle.com>
Subject: Re: [PATCH v15 12/12] cpuset: Expose cpuset.cpus.subpartitions with cgroup_debug
Date: Thu, 8 Nov 2018 13:59:43 -0500 [thread overview]
Message-ID: <5e3df063-251b-b6e0-fbc5-25e7a8b6efb5@redhat.com> (raw)
In-Reply-To: <20181108154617.GX9761@hirez.programming.kicks-ass.net>
On 11/08/2018 10:46 AM, Peter Zijlstra wrote:
> On Thu, Nov 08, 2018 at 10:08:46AM -0500, Waiman Long wrote:
>> For debugging purpose, it will be useful to expose the content of the
>> subparts_cpus as a read-only file to see if the code work correctly.
>> However, subparts_cpus will not be used at all in most use cases. So
>> adding a new cpuset file that clutters the cgroup directory may not be
>> desirable. This is now being done by using the hidden "cgroup_debug"
>> kernel command line option to expose a new "cpuset.cpus.subpartitions"
>> file.
> One thought I had; would it make sense to make these debug files hidden
> ("." prefix) ?
These debug files will only appear when the cgroup_debug command line
option is used. So I don't think we really need to add an extra "."
prefix as it will break the naming convention.
Cheers,
Longman
next prev parent reply other threads:[~2018-11-08 19:00 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-08 15:08 [PATCH v15 00/12] Enable cpuset controller in default hierarchy Waiman Long
2018-11-08 15:08 ` [PATCH v15 01/12] cpuset: " Waiman Long
2018-11-08 15:08 ` [PATCH v15 02/12] cpuset: Define data structures to support scheduling partition Waiman Long
2018-11-08 15:08 ` [PATCH v15 03/12] cpuset: Simply allocation and freeing of cpumasks Waiman Long
2018-11-08 15:08 ` [PATCH v15 04/12] cpuset: Add new v2 cpuset.sched.partition flag Waiman Long
2018-11-08 15:08 ` [PATCH v15 05/12] cpuset: Add an error state to cpuset.sched.partition Waiman Long
2018-11-08 15:08 ` [PATCH v15 06/12] cpuset: Track cpusets that use parent's effective_cpus Waiman Long
2018-11-08 15:08 ` [PATCH v15 07/12] cpuset: Make CPU hotplug work with partition Waiman Long
2018-11-08 15:08 ` [PATCH v15 08/12] cpuset: Make generate_sched_domains() " Waiman Long
2018-11-08 15:08 ` [PATCH v15 09/12] cpuset: Expose cpus.effective and mems.effective on cgroup v2 root Waiman Long
2018-11-08 15:08 ` [PATCH v15 10/12] cpuset: Use descriptive text when reading/writing cpuset.sched.partition Waiman Long
2018-11-08 15:08 ` [PATCH v15 11/12] cpuset: Add documentation about the new "cpuset.sched.partition" flag Waiman Long
2018-11-08 15:08 ` [PATCH v15 12/12] cpuset: Expose cpuset.cpus.subpartitions with cgroup_debug Waiman Long
2018-11-08 15:46 ` Peter Zijlstra
2018-11-08 18:59 ` Waiman Long [this message]
2018-11-08 15:46 ` [PATCH v15 00/12] Enable cpuset controller in default hierarchy Peter Zijlstra
2018-11-08 20:28 ` Tejun Heo
2018-11-08 20:31 ` Waiman Long
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5e3df063-251b-b6e0-fbc5-25e7a8b6efb5@redhat.com \
--to=longman@redhat.com \
--cc=cgroups@vger.kernel.org \
--cc=efault@gmx.de \
--cc=guro@fb.com \
--cc=hannes@cmpxchg.org \
--cc=juri.lelli@redhat.com \
--cc=kernel-team@fb.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan@huawei.com \
--cc=luto@amacapital.net \
--cc=mingo@redhat.com \
--cc=patrick.bellasi@arm.com \
--cc=peterz@infradead.org \
--cc=pjt@google.com \
--cc=tj@kernel.org \
--cc=tom.hromatka@oracle.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).