From: Jiaxin Yu <jiaxin.yu@mediatek.com>
To: Rob Herring <robh@kernel.org>
Cc: <broonie@kernel.org>, <angelogioacchino.delregno@collabora.com>,
<devicetree@vger.kernel.org>, <alsa-devel@alsa-project.org>,
<linux-kernel@vger.kernel.org>,
<Project_Global_Chrome_Upstream_Group@mediatek.com>,
<tzungbi@google.com>, <linux-mediatek@lists.infradead.org>,
<trevor.wu@mediatek.com>, <matthias.bgg@gmail.com>,
<aaronyu@google.com>, <julianbraha@gmail.com>,
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [v4 16/18] dt-bindings: mediatek: mt8186: add mt8186-mt6366-da7219-max98357 document
Date: Fri, 29 Apr 2022 17:40:02 +0800 [thread overview]
Message-ID: <5e400f7ccb3b208a033e2ad8f220331851ff9c7e.camel@mediatek.com> (raw)
In-Reply-To: <YmqlNV31FrcAyuN9@robh.at.kernel.org>
On Thu, 2022-04-28 at 09:31 -0500, Rob Herring wrote:
> On Thu, Apr 28, 2022 at 05:33:53PM +0800, Jiaxin Yu wrote:
> > Add document for mt8186 board with mt6366, da7219 and max98357.
> >
> > Signed-off-by: Jiaxin Yu <jiaxin.yu@mediatek.com>
> > ---
> > .../sound/mt8186-mt6366-da7219-max98357.yaml | 71
> > +++++++++++++++++++
> > 1 file changed, 71 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/sound/mt8186-
> > mt6366-da7219-max98357.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/sound/mt8186-mt6366-
> > da7219-max98357.yaml
> > b/Documentation/devicetree/bindings/sound/mt8186-mt6366-da7219-
> > max98357.yaml
> > new file mode 100644
> > index 000000000000..55e8649f2aea
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/sound/mt8186-mt6366-da7219-
> > max98357.yaml
> > @@ -0,0 +1,71 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id:
> > http://devicetree.org/schemas/sound/mt8186-mt6366-da7219-max98357.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Mediatek MT8186 with MT6366, DA7219 and MAX98357 ASoC sound
> > card driver
> > +
> > +maintainers:
> > + - Jiaxin Yu <jiaxin.yu@mediatek.com>
> > +
> > +description:
> > + This binding describes the MT8186 sound card.
> > +
> > +properties:
> > + compatible:
> > + enum:
> > + - mediatek,mt8186_mt6366_da7219_max98357_sound
>
> s/_/-/
>
Got it.
> > +
> > + mediatek,platform:
> > + $ref: "/schemas/types.yaml#/definitions/phandle"
> > + description: The phandle of MT8186 ASoC platform.
> > +
> > + headset-codec:
> > + type: object
>
> additionalProperties: false
Ditto.
>
> > + properties:
> > + sound-dai:
> > + $ref: /schemas/types.yaml#/definitions/phandle
>
> sound-dai already has a type, so drop and define how many entries.
>
Ditto.
> > + required:
> > + - sound-dai
> > +
The indentation of this line is incorrect. I will fix it.
> > + playback-codecs:
> > + type: object
>
> additionalProperties: false
>
Got it.
> > + properties:
> > + sound-dai:
> > + minItems: 2
> > + maxItems: 3
>
> If more than 1 entry, then you need to define what each one is and
> the
> order. Just like reg, interrupts, clocks, etc.
>
Hi Rob,
Should I correct them as below?
---
properties:
sound-dai:
minItems: 2
maxItems: 3
items:
- items:
- description: xxx
- description: yyy
- description: zzz
> > + $ref: /schemas/types.yaml#/definitions/phandle-array
>
> Drop
>
Got it.
> > + required:
> > + - sound-dai
> > +
> > +additionalProperties: false
> > +
> > +required:
> > + - compatible
> > + - mediatek,platform
> > + - headset-codec
> > + - playback-codecs
> > +
> > +examples:
> > + - |
> > +
> > + sound: mt8186-sound {
> > + compatible =
> > "mediatek,mt8186_mt6366_da7219_max98357_sound";
> > + mediatek,platform = <&afe>;
> > + pinctrl-names = "aud_clk_mosi_off",
> > + "aud_clk_mosi_on";
> > + pinctrl-0 = <&aud_clk_mosi_off>;
> > + pinctrl-1 = <&aud_clk_mosi_on>;
> > +
> > + headset-codec {
> > + sound-dai = <&da7219>;
> > + };
> > +
> > + playback-codecs {
> > + sound-dai = <&anx_bridge_dp>,
> > + <&max98357a>;
> > + };
> > + };
> > +
> > +...
> > --
> > 2.25.1
> >
next prev parent reply other threads:[~2022-04-29 9:40 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-28 9:33 [v4 00/18] ASoC: mediatek: Add support for MT8186 SoC Jiaxin Yu
2022-04-28 9:33 ` [v4 01/18] ASoC: mediatek: mt6366: support for mt6366 codec Jiaxin Yu
2022-04-28 9:33 ` [v4 02/18] dt-bindings: mediatek: mt6358: add new compatible for using mt6366 Jiaxin Yu
2022-04-28 9:33 ` [v4 03/18] ASoC: mediatek: mt8186: support audsys clock control Jiaxin Yu
2022-04-28 9:33 ` [v4 04/18] ASoC: mediatek: mt8186: support adda in platform driver Jiaxin Yu
2022-04-28 9:33 ` [v4 05/18] ASoC: mediatek: mt8186: support hostless " Jiaxin Yu
2022-04-28 9:33 ` [v4 06/18] ASoC: mediatek: mt8186: support hw gain " Jiaxin Yu
2022-04-28 9:33 ` [v4 07/18] ASoC: mediatek: mt8186: support i2s " Jiaxin Yu
2022-04-28 12:13 ` Mark Brown
2022-04-29 9:56 ` Jiaxin Yu
2022-04-28 9:33 ` [v4 08/18] ASoC: mediatek: mt8186: support pcm " Jiaxin Yu
2022-04-28 9:33 ` [v4 09/18] ASoC: mediatek: mt8186: support src " Jiaxin Yu
2022-04-28 9:33 ` [v4 10/18] ASoC: mediatek: mt8186: support tdm " Jiaxin Yu
2022-04-28 9:33 ` [v4 11/18] ASoC: mediatek: mt8186: support audio clock control " Jiaxin Yu
2022-04-28 9:33 ` [v4 12/18] ASoC: mediatek: mt8186: support gpio " Jiaxin Yu
2022-04-28 9:33 ` [v4 13/18] ASoC: mediatek: mt8186: add " Jiaxin Yu
2022-04-28 12:02 ` Mark Brown
2022-04-29 10:07 ` Jiaxin Yu
2022-04-28 9:33 ` [v4 14/18] dt-bindings: mediatek: mt8186: add audio afe document Jiaxin Yu
2022-05-03 19:29 ` Rob Herring
2022-04-28 9:33 ` [v4 15/18] ASoC: mediatek: mt8186: add machine driver with mt6366, da7219 and max98357 Jiaxin Yu
2022-04-28 9:33 ` [v4 16/18] dt-bindings: mediatek: mt8186: add mt8186-mt6366-da7219-max98357 document Jiaxin Yu
2022-04-28 12:17 ` Rob Herring
2022-04-28 14:31 ` Rob Herring
2022-04-29 9:40 ` Jiaxin Yu [this message]
2022-04-29 20:16 ` Rob Herring
2022-04-28 9:33 ` [v4 17/18] ASoC: mediatek: mt8186: add machine driver with mt6366, rt1019 and rt5682s Jiaxin Yu
2022-04-28 9:33 ` [v4 18/18] dt-bindings: mediatek: mt8186: add mt8186-mt6366-rt1019-rt5682s document Jiaxin Yu
2022-04-28 12:17 ` Rob Herring
2022-04-28 14:31 ` Rob Herring
2022-04-28 12:19 ` [v4 00/18] ASoC: mediatek: Add support for MT8186 SoC Mark Brown
2022-04-29 9:21 ` Jiaxin Yu
2022-04-29 8:47 ` Geert Uytterhoeven
2022-04-29 9:15 ` Jiaxin Yu
2022-04-29 12:49 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5e400f7ccb3b208a033e2ad8f220331851ff9c7e.camel@mediatek.com \
--to=jiaxin.yu@mediatek.com \
--cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
--cc=aaronyu@google.com \
--cc=alsa-devel@alsa-project.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=julianbraha@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=robh@kernel.org \
--cc=trevor.wu@mediatek.com \
--cc=tzungbi@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).