LKML Archive on lore.kernel.org
 help / Atom feed
From: "Mickaël Salaün" <mic@digikod.net>
To: Will Drewry <wad@chromium.org>, Kees Cook <keescook@chromium.org>
Cc: Shuah Khan <shuah@kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Andy Lutomirski <luto@amacapital.net>,
	linux-kselftest@vger.kernel.org
Subject: Re: [PATCH v1] selftests: Make test_harness.h more generally available
Date: Mon, 1 May 2017 17:11:29 +0200
Message-ID: <5e655775-b2ec-3660-ae52-b7df7706db57@digikod.net> (raw)
In-Reply-To: <CAAFS_9F_oYuDBGoG_db3i3EOVWnzSsm9uvirExMKUqYLAbBH6g@mail.gmail.com>

[-- Attachment #1.1: Type: text/plain, Size: 2521 bytes --]

Maybe an update on the MAINTAINERS file could help for future reviews?

diff --git a/MAINTAINERS b/MAINTAINERS
index c265a5fe4848..0361364afb50 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -11254,6 +11254,7 @@ F:      kernel/seccomp.c
 F:     include/uapi/linux/seccomp.h
 F:     include/linux/seccomp.h
 F:     tools/testing/selftests/seccomp/*
+F:     tools/testing/selftests/test_harness.h
 K:     \bsecure_computing
 K:     \bTIF_SECCOMP\b



On 30/04/2017 20:22, Will Drewry wrote:
> On Sun, Apr 30, 2017 at 12:39 PM, Kees Cook <keescook@chromium.org> wrote:
>>
>> On Sun, Apr 30, 2017 at 5:26 AM, Mickaël Salaün <mic@digikod.net> wrote:
>>> The seccomp/test_harness.h file contains useful helpers to build tests.
>>> Moving it to the selftest directory should benefit to other test
>>> components.
>>
>> Unless Shuah thinks this should live in a new include/ directory, this
>> looks fine to me.
>>
>> Acked-by: Kees Cook <keescook@chromium.org>
> 
> Same here!
> 
> Acked-by: Will Drewry <wad@chromium.org>
> 
>>
>> Thanks!
>>
>> -Kees
>>
>>>
>>> Signed-off-by: Mickaël Salaün <mic@digikod.net>
>>> Cc: Andy Lutomirski <luto@amacapital.net>
>>> Cc: Kees Cook <keescook@chromium.org>
>>> Cc: Shuah Khan <shuah@kernel.org>
>>> Cc: Will Drewry <wad@chromium.org>
>>> Link: https://lkml.kernel.org/r/CAGXu5j+8CVz8vL51DRYXqOY=xc3zuKFf=PTENe88XYHzFYidUQ@mail.gmail.com
>>> ---
>>>  tools/testing/selftests/seccomp/seccomp_bpf.c        | 2 +-
>>>  tools/testing/selftests/{seccomp => }/test_harness.h | 0
>>>  2 files changed, 1 insertion(+), 1 deletion(-)
>>>  rename tools/testing/selftests/{seccomp => }/test_harness.h (100%)
>>>
>>> diff --git a/tools/testing/selftests/seccomp/seccomp_bpf.c b/tools/testing/selftests/seccomp/seccomp_bpf.c
>>> index 03f1fa495d74..d7095ff58e72 100644
>>> --- a/tools/testing/selftests/seccomp/seccomp_bpf.c
>>> +++ b/tools/testing/selftests/seccomp/seccomp_bpf.c
>>> @@ -37,7 +37,7 @@
>>>  #include <unistd.h>
>>>  #include <sys/syscall.h>
>>>
>>> -#include "test_harness.h"
>>> +#include "../test_harness.h"
>>>
>>>  #ifndef PR_SET_PTRACER
>>>  # define PR_SET_PTRACER 0x59616d61
>>> diff --git a/tools/testing/selftests/seccomp/test_harness.h b/tools/testing/selftests/test_harness.h
>>> similarity index 100%
>>> rename from tools/testing/selftests/seccomp/test_harness.h
>>> rename to tools/testing/selftests/test_harness.h
>>> --
>>> 2.11.0
>>>
>>
>>
>>
>> --
>> Kees Cook
>> Pixel Security
> 


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

  reply index

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-30 12:26 Mickaël Salaün
2017-04-30 17:39 ` Kees Cook
2017-04-30 18:22   ` Will Drewry
2017-05-01 15:11     ` Mickaël Salaün [this message]
2017-05-01 19:23     ` Shuah Khan

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5e655775-b2ec-3660-ae52-b7df7706db57@digikod.net \
    --to=mic@digikod.net \
    --cc=keescook@chromium.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=luto@amacapital.net \
    --cc=shuah@kernel.org \
    --cc=wad@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

LKML Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/lkml/0 lkml/git/0.git
	git clone --mirror https://lore.kernel.org/lkml/1 lkml/git/1.git
	git clone --mirror https://lore.kernel.org/lkml/2 lkml/git/2.git
	git clone --mirror https://lore.kernel.org/lkml/3 lkml/git/3.git
	git clone --mirror https://lore.kernel.org/lkml/4 lkml/git/4.git
	git clone --mirror https://lore.kernel.org/lkml/5 lkml/git/5.git
	git clone --mirror https://lore.kernel.org/lkml/6 lkml/git/6.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 lkml lkml/ https://lore.kernel.org/lkml \
		linux-kernel@vger.kernel.org linux-kernel@archiver.kernel.org
	public-inbox-index lkml


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-kernel


AGPL code for this site: git clone https://public-inbox.org/ public-inbox