linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 0/4] ARM: dts: keystone: k2g: Update dts node for yaml
@ 2021-05-10 14:43 Nishanth Menon
  2021-05-10 14:43 ` [PATCH 1/4 RESEND] ARM: dts: keystone: k2g: Rename message-manager node Nishanth Menon
                   ` (4 more replies)
  0 siblings, 5 replies; 6+ messages in thread
From: Nishanth Menon @ 2021-05-10 14:43 UTC (permalink / raw)
  To: Santosh Shilimkar
  Cc: linux-kernel, devicetree, linux-arm-kernel, kristo, Nishanth Menon

Hi,

Series of patches to cleanup the dts for k2g to sync the dts
with yaml fixups (information provided per patch)


Basic tests performed on k2g-evm. Series has been based on v5.13-rc1 -
will be good to get it in the 5.13 window if possible.

Nishanth Menon (4):
  ARM: dts: keystone: k2g: Rename message-manager node
  ARM: dts: keystone: k2g: Rename the TI-SCI node
  ARM: dts: keystone: k2g: Rename the TI-SCI clocks node name
  ARM: dts: keystone: k2g-evm: Move audio oscillator assigned clock to
    mcasp

 arch/arm/boot/dts/keystone-k2g-evm.dts | 11 +++--------
 arch/arm/boot/dts/keystone-k2g.dtsi    |  6 +++---
 2 files changed, 6 insertions(+), 11 deletions(-)

-- 
2.31.0


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH 1/4 RESEND] ARM: dts: keystone: k2g: Rename message-manager node
  2021-05-10 14:43 [PATCH 0/4] ARM: dts: keystone: k2g: Update dts node for yaml Nishanth Menon
@ 2021-05-10 14:43 ` Nishanth Menon
  2021-05-10 14:43 ` [PATCH 2/4] ARM: dts: keystone: k2g: Rename the TI-SCI node Nishanth Menon
                   ` (3 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: Nishanth Menon @ 2021-05-10 14:43 UTC (permalink / raw)
  To: Santosh Shilimkar
  Cc: linux-kernel, devicetree, linux-arm-kernel, kristo,
	Nishanth Menon, Suman Anna

Rename message-manager instance node name to be better aligned with
current style of device tree nodes for mailboxes.

Acked-by: Suman Anna <s-anna@ti.com>
Signed-off-by: Nishanth Menon <nm@ti.com>
---
Original patch:
https://lore.kernel.org/linux-arm-kernel/20210414001926.20002-1-nm@ti.com/
Change since original patch (subject line update keystone: k2g instead of
keystone-k2g)

Schema update:
https://lore.kernel.org/linux-arm-kernel/20210415213502.GA1921174@robh.at.kernel.org/

 arch/arm/boot/dts/keystone-k2g.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/keystone-k2g.dtsi b/arch/arm/boot/dts/keystone-k2g.dtsi
index 05a75019275e..e5c813b5556d 100644
--- a/arch/arm/boot/dts/keystone-k2g.dtsi
+++ b/arch/arm/boot/dts/keystone-k2g.dtsi
@@ -242,7 +242,7 @@ dsp0: dsp@10800000 {
 			status = "disabled";
 		};
 
-		msgmgr: msgmgr@2a00000 {
+		msgmgr: mailbox@2a00000 {
 			compatible = "ti,k2g-message-manager";
 			#mbox-cells = <2>;
 			reg-names = "queue_proxy_region",
-- 
2.31.0


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH 2/4] ARM: dts: keystone: k2g: Rename the TI-SCI node
  2021-05-10 14:43 [PATCH 0/4] ARM: dts: keystone: k2g: Update dts node for yaml Nishanth Menon
  2021-05-10 14:43 ` [PATCH 1/4 RESEND] ARM: dts: keystone: k2g: Rename message-manager node Nishanth Menon
@ 2021-05-10 14:43 ` Nishanth Menon
  2021-05-10 14:43 ` [PATCH 3/4] ARM: dts: keystone: k2g: Rename the TI-SCI clocks node name Nishanth Menon
                   ` (2 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: Nishanth Menon @ 2021-05-10 14:43 UTC (permalink / raw)
  To: Santosh Shilimkar
  Cc: linux-kernel, devicetree, linux-arm-kernel, kristo, Nishanth Menon

Lets rename the node name of TI-SCI node to be system-controller as it
is a better standardized name for the function that TI-SCI plays in
the SoC.

Signed-off-by: Nishanth Menon <nm@ti.com>
---

yaml fixup series:
https://lore.kernel.org/linux-arm-kernel/20210503190824.GA2192378@robh.at.kernel.org

Specific yaml:
https://lore.kernel.org/linux-arm-kernel/20210426155457.21221-5-nm@ti.com/

 arch/arm/boot/dts/keystone-k2g.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/keystone-k2g.dtsi b/arch/arm/boot/dts/keystone-k2g.dtsi
index e5c813b5556d..d7fc6057ca41 100644
--- a/arch/arm/boot/dts/keystone-k2g.dtsi
+++ b/arch/arm/boot/dts/keystone-k2g.dtsi
@@ -254,7 +254,7 @@ msgmgr: mailbox@2a00000 {
 				     <GIC_SPI 327 IRQ_TYPE_LEVEL_HIGH>;
 		};
 
-		pmmc: pmmc@2921c00 {
+		pmmc: system-controller@2921c00 {
 			compatible = "ti,k2g-sci";
 			/*
 			 * In case of rare platforms that does not use k2g as
-- 
2.31.0


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH 3/4] ARM: dts: keystone: k2g: Rename the TI-SCI clocks node name
  2021-05-10 14:43 [PATCH 0/4] ARM: dts: keystone: k2g: Update dts node for yaml Nishanth Menon
  2021-05-10 14:43 ` [PATCH 1/4 RESEND] ARM: dts: keystone: k2g: Rename message-manager node Nishanth Menon
  2021-05-10 14:43 ` [PATCH 2/4] ARM: dts: keystone: k2g: Rename the TI-SCI node Nishanth Menon
@ 2021-05-10 14:43 ` Nishanth Menon
  2021-05-10 14:43 ` [PATCH 4/4] ARM: dts: keystone: k2g-evm: Move audio oscillator assigned clock to mcasp Nishanth Menon
  2021-05-11  7:16 ` [PATCH 0/4] ARM: dts: keystone: k2g: Update dts node for yaml Tero Kristo
  4 siblings, 0 replies; 6+ messages in thread
From: Nishanth Menon @ 2021-05-10 14:43 UTC (permalink / raw)
  To: Santosh Shilimkar
  Cc: linux-kernel, devicetree, linux-arm-kernel, kristo, Nishanth Menon

We currently use clocks as the node name for the node representing
TI-SCI clock nodes. This is better renamed to being clock-controller
as that is a better representative of the system controller function
as a clock controller for the SoC.

Signed-off-by: Nishanth Menon <nm@ti.com>
---
yaml fixup series:
https://lore.kernel.org/linux-arm-kernel/20210503190824.GA2192378@robh.at.kernel.org

Specific yaml:
https://lore.kernel.org/linux-arm-kernel/20210426155457.21221-3-nm@ti.com/

 arch/arm/boot/dts/keystone-k2g.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/keystone-k2g.dtsi b/arch/arm/boot/dts/keystone-k2g.dtsi
index d7fc6057ca41..37198294f4b2 100644
--- a/arch/arm/boot/dts/keystone-k2g.dtsi
+++ b/arch/arm/boot/dts/keystone-k2g.dtsi
@@ -272,7 +272,7 @@ k2g_pds: power-controller {
 				#power-domain-cells = <1>;
 			};
 
-			k2g_clks: clocks {
+			k2g_clks: clock-controller {
 				compatible = "ti,k2g-sci-clk";
 				#clock-cells = <2>;
 			};
-- 
2.31.0


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH 4/4] ARM: dts: keystone: k2g-evm: Move audio oscillator assigned clock to mcasp
  2021-05-10 14:43 [PATCH 0/4] ARM: dts: keystone: k2g: Update dts node for yaml Nishanth Menon
                   ` (2 preceding siblings ...)
  2021-05-10 14:43 ` [PATCH 3/4] ARM: dts: keystone: k2g: Rename the TI-SCI clocks node name Nishanth Menon
@ 2021-05-10 14:43 ` Nishanth Menon
  2021-05-11  7:16 ` [PATCH 0/4] ARM: dts: keystone: k2g: Update dts node for yaml Tero Kristo
  4 siblings, 0 replies; 6+ messages in thread
From: Nishanth Menon @ 2021-05-10 14:43 UTC (permalink / raw)
  To: Santosh Shilimkar
  Cc: linux-kernel, devicetree, linux-arm-kernel, kristo, Nishanth Menon

Setting assigned clock with a dependency on itself for k2g_clks
creates a circular dependency. Instead, Lets model the audio clock
as a assigned-clock configuration for mcasp and set it up as the
first clock assigned-clock to be satisfied. Following the standard
convention, we use null entries to indicate entries that doesn't need
to be programmed.

References:
[1] schematics: https://www.ti.com/lit/df/sprr302/sprr302.pdf
[2] TRM: https://www.ti.com/lit/ug/spruhy8i/spruhy8i.pdf

Signed-off-by: Nishanth Menon <nm@ti.com>
---
yaml fixup series:
https://lore.kernel.org/linux-arm-kernel/20210503190824.GA2192378@robh.at.kernel.org

Specific yaml:
https://lore.kernel.org/linux-arm-kernel/20210426155457.21221-3-nm@ti.com/

 arch/arm/boot/dts/keystone-k2g-evm.dts | 11 +++--------
 1 file changed, 3 insertions(+), 8 deletions(-)

diff --git a/arch/arm/boot/dts/keystone-k2g-evm.dts b/arch/arm/boot/dts/keystone-k2g-evm.dts
index 14e26a4fd62a..d800f26b6275 100644
--- a/arch/arm/boot/dts/keystone-k2g-evm.dts
+++ b/arch/arm/boot/dts/keystone-k2g-evm.dts
@@ -544,20 +544,15 @@ dpi_out: endpoint {
 	};
 };
 
-&k2g_clks {
-	/* on the board 22.5792MHz is connected to AUDOSC_IN */
-	assigned-clocks = <&k2g_clks 0x4c 2>;
-	assigned-clock-rates = <22579200>;
-};
-
 &mcasp2 {
 	#sound-dai-cells = <0>;
 
 	pinctrl-names = "default";
 	pinctrl-0 = <&mcasp2_pins>;
 
-	assigned-clocks = <&k2g_clks 0x6 1>;
-	assigned-clock-parents = <&k2g_clks 0x6 2>;
+	assigned-clocks = <&k2g_clks 0x4c 2>, <&k2g_clks 0x6 1>;
+	assigned-clock-parents = <0>, <&k2g_clks 0x6 2>;
+	assigned-clock-rates = <22579200>, <0>;
 
 	status = "okay";
 
-- 
2.31.0


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH 0/4] ARM: dts: keystone: k2g: Update dts node for yaml
  2021-05-10 14:43 [PATCH 0/4] ARM: dts: keystone: k2g: Update dts node for yaml Nishanth Menon
                   ` (3 preceding siblings ...)
  2021-05-10 14:43 ` [PATCH 4/4] ARM: dts: keystone: k2g-evm: Move audio oscillator assigned clock to mcasp Nishanth Menon
@ 2021-05-11  7:16 ` Tero Kristo
  4 siblings, 0 replies; 6+ messages in thread
From: Tero Kristo @ 2021-05-11  7:16 UTC (permalink / raw)
  To: Nishanth Menon, Santosh Shilimkar
  Cc: linux-kernel, devicetree, linux-arm-kernel

On 10/05/2021 17:43, Nishanth Menon wrote:
> Hi,
> 
> Series of patches to cleanup the dts for k2g to sync the dts
> with yaml fixups (information provided per patch)
> 
> 
> Basic tests performed on k2g-evm. Series has been based on v5.13-rc1 -
> will be good to get it in the 5.13 window if possible.
> 
> Nishanth Menon (4):
>    ARM: dts: keystone: k2g: Rename message-manager node
>    ARM: dts: keystone: k2g: Rename the TI-SCI node
>    ARM: dts: keystone: k2g: Rename the TI-SCI clocks node name
>    ARM: dts: keystone: k2g-evm: Move audio oscillator assigned clock to
>      mcasp
> 
>   arch/arm/boot/dts/keystone-k2g-evm.dts | 11 +++--------
>   arch/arm/boot/dts/keystone-k2g.dtsi    |  6 +++---
>   2 files changed, 6 insertions(+), 11 deletions(-)
> 

For the whole series:

Reviewed-by: Tero Kristo <kristo@kernel.org>

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2021-05-11  7:16 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-10 14:43 [PATCH 0/4] ARM: dts: keystone: k2g: Update dts node for yaml Nishanth Menon
2021-05-10 14:43 ` [PATCH 1/4 RESEND] ARM: dts: keystone: k2g: Rename message-manager node Nishanth Menon
2021-05-10 14:43 ` [PATCH 2/4] ARM: dts: keystone: k2g: Rename the TI-SCI node Nishanth Menon
2021-05-10 14:43 ` [PATCH 3/4] ARM: dts: keystone: k2g: Rename the TI-SCI clocks node name Nishanth Menon
2021-05-10 14:43 ` [PATCH 4/4] ARM: dts: keystone: k2g-evm: Move audio oscillator assigned clock to mcasp Nishanth Menon
2021-05-11  7:16 ` [PATCH 0/4] ARM: dts: keystone: k2g: Update dts node for yaml Tero Kristo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).