From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752797AbdK0SNK (ORCPT <rfc822;w@1wt.eu>);
        Mon, 27 Nov 2017 13:13:10 -0500
Received: from mout.web.de ([217.72.192.78]:57764 "EHLO mout.web.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751752AbdK0SNH (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 27 Nov 2017 13:13:07 -0500
Subject: Re: omapfb/dss: Delete an error message for a failed memory
 allocation in three functions
To: Ladislav Michl <ladis@linux-mips.org>, linux-omap@vger.kernel.org,
        linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org
Cc: "Andrew F. Davis" <afd@ti.com>,
        Arvind Yadav <arvind.yadav.cs@gmail.com>,
        Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
        Tomi Valkeinen <tomi.valkeinen@ti.com>,
        LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org
References: <c48a01db-c477-3bd3-5cb4-548e47810ccb@users.sourceforge.net>
 <d29a0bae-7b6f-b8f6-6809-5a097cd5a26a@ti.com>
 <502de06b-ca86-d0ff-bd50-d260fbe46fe5@users.sourceforge.net>
 <20171127174454.GA18851@lenoch>
From: SF Markus Elfring <elfring@users.sourceforge.net>
Message-ID: <5e90409f-fcb0-cdb6-9bc3-26ad30a1f7c9@users.sourceforge.net>
Date: Mon, 27 Nov 2017 19:12:50 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.5.0
MIME-Version: 1.0
In-Reply-To: <20171127174454.GA18851@lenoch>
Content-Type: text/plain; charset=utf-8
Content-Language: en-GB
Content-Transfer-Encoding: 7bit
X-Provags-ID: V03:K0:wp6kwfS1hCE4IkXNHYfZ4wASj/aKzOnJuEbkRIWTO5iiiwffvdJ
 a7UMkviJxWwrh6FAR2SH7mUMytFqyyqcoyTHO44xu24WWfH2yn4QMqenh2pGU3g9/ZYHPR4
 o8vzXhN5SMqfGeGulC5vt+KBjCugv3vIP+VMLIzdJVulPxyToDK1jr+24cgza5pAj2eYcqb
 EnbyebVNH5AI0JoWkSdtw==
X-UI-Out-Filterresults: notjunk:1;V01:K0:eHUl5m9BCdU=:yOFRwI+kAIdBLP0qOtBkdG
 vHlYW5S9KG+bf3s0kzX7heOVa6O5zXgm7wp0SZvFyptkzilZG1xrU2GB/YdJNXY4vzrO2gy9f
 uXH9RmtvBHE9T42WdvEYnDq3p3yaKc/gsQdCkGyB5hyRwESd1yH1uU6Vhz2NY3yCQpev1f3aL
 vwlLm+Zns+7pUTiZCAPpqmfzB7H7OITofq7K7lqsK0lW+1e11KF8P3t5GqoLoN3xK6jsJ5znu
 ShAgD2tmNLFTHbMgjw4fNHAVRykztJPJfJaEgTyxEwV8FEwM1RUWKybqeuiwlLkQRnvtXifnR
 THkzidYyTA7UwLMRrdEr8tJL5ShQG+kIJwkg7R5qccs5qo3ET4yMnHRCK1pYolmKhzW6GIwM2
 +WVns0b/vAc/4Co3cODGQlrc6RTWWNCagP/poeUw6LcwEaxcti7/L8d0TYLrLAzTu213c4wes
 u3J25Y6ZN2hfKbIZiXkbfsLuJnK0EuZrIdf62ij1Xu+ohtVzcYlqOvSiPmiL/Bm6vUiipXpte
 WJ0SVeN47yYL5R77M8glz63Kwr7iOAJO8Vc6FB5V1ZKwZOdLDrRcrv+BpDMWY01EnuuELhKf8
 CQR427WJ7RMSRWcPxzwQwCUGHQ/3F50RKnC2cIB7hfArmdDM7SMaqJeSAlaxuPPI0wIeZJqH0
 09HON0QZP3TUSFZC9Dg8ts/ODGPyQYXJToK59ARxOE4mw4OOkUoZeLttTVokg9SNwRIMBDAVg
 L41JISlXoFoSjQB9jGP6tdzvc8P8IRcZymWR2mXDo8VT/t9DYrZ7Z6DeffjdSR3fHqGcORyrt
 woYkOuYwJQ/bBFLr/PvH+ChYEhCVQFeeikLxOL9XKlcLQxdShU=
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>> Can a default allocation failure report provide the information
>> which you might expect so far?
> 
> You should be able to answer that question yourself.

I can not answer this detail completely myself because my knowledge
is incomplete about your concrete expectations for the exception handling
which can lead to different views for the need of additional error messages.


> And if you are unable to do so, just do not sent changes pointed
> by any code analysis tools.

They can point aspects out for further software development considerations,
can't they?


> As a side note, if you look at whole call chain, you'll find quite some
> room for optimizations - look how dev and pdev are used. That also applies
> to other patches.

Would you prefer to improve the source code in other ways?

Regards,
Markus