From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1171600AbdDXPqe (ORCPT <rfc822;w@1wt.eu>);
        Mon, 24 Apr 2017 11:46:34 -0400
Received: from mx2.suse.de ([195.135.220.15]:46709 "EHLO mx1.suse.de"
        rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP
        id S1170447AbdDXPqA (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 24 Apr 2017 11:46:00 -0400
Subject: Re: [PATCH 1/2] perf tools: Guard _GNU_SOURCE in pmu-events/jevents.c
To: Andi Kleen <ak@linux.intel.com>
References: <20170424042633.14423-1-tonyj@suse.de>
 <20170424130547.GS4021@tassilo.jf.intel.com>
Cc: mingo@kernel.org, linux-kernel@vger.kernel.org
From: Tony Jones <tonyj@suse.de>
Message-ID: <5e91ca3e-248a-0882-094d-60c37446483b@suse.de>
Date: Mon, 24 Apr 2017 08:45:48 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.5.1
MIME-Version: 1.0
In-Reply-To: <20170424130547.GS4021@tassilo.jf.intel.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 04/24/2017 06:05 AM, Andi Kleen wrote:
> On Sun, Apr 23, 2017 at 09:26:32PM -0700, Tony Jones wrote:
>> Guard _GNU_SOURCE (as done in pt-decoder/intel-pt-decoder.c) to prevent 
>> possible redefinition error.
> 
> Who defines it? 
> 
> If it's always defined somewhere else it can be just removed.
> 
> -Andi

sometimes it's defaulted on (I believe) by the toolchain.    it fails on our SLE12-SP3 toolchain.
I assumed the existing guard in pt-decoder/intel-pt-decoder.c (only other use) was for a reason.

tony