linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Randy Dunlap <rdunlap@infradead.org>
To: Barry Song <song.bao.hua@hisilicon.com>,
	hch@lst.de, m.szyprowski@samsung.com, robin.murphy@arm.com,
	will@kernel.org, ganapatrao.kulkarni@cavium.com,
	catalin.marinas@arm.com, akpm@linux-foundation.org
Cc: iommu@lists.linux-foundation.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, prime.zeng@hisilicon.com,
	huangdaode@huawei.com, linuxarm@huawei.com,
	Jonathan Cameron <Jonathan.Cameron@huawei.com>,
	Nicolas Saenz Julienne <nsaenzjulienne@suse.de>,
	Steve Capper <steve.capper@arm.com>,
	Mike Rapoport <rppt@linux.ibm.com>
Subject: Re: [PATCH v7 1/3] dma-contiguous: provide the ability to reserve per-numa CMA
Date: Fri, 21 Aug 2020 09:08:27 -0700	[thread overview]
Message-ID: <5eafce91-cc92-e6ed-23b0-98f253129e1b@infradead.org> (raw)
In-Reply-To: <20200821113355.6140-2-song.bao.hua@hisilicon.com>

On 8/21/20 4:33 AM, Barry Song wrote:
> ---
>  -v7: with respect to Will's comments
>  * move to use for_each_online_node
>  * add description if users don't specify pernuma_cma
>  * provide default value for CONFIG_DMA_PERNUMA_CMA
> 
>  .../admin-guide/kernel-parameters.txt         |  11 ++
>  include/linux/dma-contiguous.h                |   6 ++
>  kernel/dma/Kconfig                            |  11 ++
>  kernel/dma/contiguous.c                       | 100 ++++++++++++++++--
>  4 files changed, 118 insertions(+), 10 deletions(-)
> 
> diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin-guide/kernel-parameters.txt
> index bdc1f33fd3d1..c609527fc35a 100644
> --- a/Documentation/admin-guide/kernel-parameters.txt
> +++ b/Documentation/admin-guide/kernel-parameters.txt
> @@ -599,6 +599,17 @@
>  			altogether. For more information, see
>  			include/linux/dma-contiguous.h
>  
> +	pernuma_cma=nn[MG]
> +			[ARM64,KNL]
> +			Sets the size of kernel per-numa memory area for
> +			contiguous memory allocations. A value of 0 disables
> +			per-numa CMA altogether. And If this option is not
> +			specificed, the default value is 0.
> +			With per-numa CMA enabled, DMA users on node nid will
> +			first try to allocate buffer from the pernuma area
> +			which is located in node nid, if the allocation fails,
> +			they will fallback to the global default memory area.
> +

Entries in kernel-parameters.txt are supposed to be in alphabetical order
but this one is not.  If you want to keep it near the cma= entry, you can
rename it like Mike suggested.  Otherwise it needs to be moved.


>  	cmo_free_hint=	[PPC] Format: { yes | no }
>  			Specify whether pages are marked as being inactive
>  			when they are freed.  This is used in CMO environments



-- 
~Randy


  parent reply	other threads:[~2020-08-21 16:09 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-21 11:33 [PATCH v7 0/3] make dma_alloc_coherent NUMA-aware by per-NUMA CMA Barry Song
2020-08-21 11:33 ` [PATCH v7 1/3] dma-contiguous: provide the ability to reserve per-numa CMA Barry Song
2020-08-21 14:28   ` Mike Rapoport
2020-08-21 19:14     ` Song Bao Hua (Barry Song)
2020-08-21 16:08   ` Randy Dunlap [this message]
2020-08-21 19:17     ` Song Bao Hua (Barry Song)
2020-08-21 11:33 ` [PATCH v7 2/3] arm64: mm: reserve per-numa CMA to localize coherent dma buffers Barry Song
2020-08-21 11:33 ` [PATCH v7 3/3] mm: cma: use CMA_MAX_NAME to define the length of cma name array Barry Song
2020-08-21 17:52 ` [PATCH v7 0/3] make dma_alloc_coherent NUMA-aware by per-NUMA CMA Mike Kravetz
2020-08-21 19:29   ` Song Bao Hua (Barry Song)
2020-08-21 20:47   ` Song Bao Hua (Barry Song)
2020-08-21 21:10     ` Mike Kravetz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5eafce91-cc92-e6ed-23b0-98f253129e1b@infradead.org \
    --to=rdunlap@infradead.org \
    --cc=Jonathan.Cameron@huawei.com \
    --cc=akpm@linux-foundation.org \
    --cc=catalin.marinas@arm.com \
    --cc=ganapatrao.kulkarni@cavium.com \
    --cc=hch@lst.de \
    --cc=huangdaode@huawei.com \
    --cc=iommu@lists.linux-foundation.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxarm@huawei.com \
    --cc=m.szyprowski@samsung.com \
    --cc=nsaenzjulienne@suse.de \
    --cc=prime.zeng@hisilicon.com \
    --cc=robin.murphy@arm.com \
    --cc=rppt@linux.ibm.com \
    --cc=song.bao.hua@hisilicon.com \
    --cc=steve.capper@arm.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).