From: Vignesh Raghavendra <vigneshr@ti.com>
To: Rob Herring <robh@kernel.org>
Cc: Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Santosh Shilimkar <ssantosh@kernel.org>,
<linux-clk@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, Tero Kristo <t-kristo@ti.com>
Subject: Re: [PATCH v3 1/2] dt-bindings: clock: Add binding documentation for TI syscon gate clock
Date: Wed, 19 Feb 2020 09:39:39 +0530 [thread overview]
Message-ID: <5eb5521b-2752-68a3-c11d-eea38e325666@ti.com> (raw)
In-Reply-To: <20200219025811.GA20054@bogus>
Hi,
On 19/02/20 8:28 am, Rob Herring wrote:
> On Sat, Feb 15, 2020 at 07:47:23PM +0530, Vignesh Raghavendra wrote:
>> Add dt bindings for TI syscon gate clock driver that is used to control
>> EHRPWM's TimeBase clock (TBCLK) on TI's AM654 SoC.
>>
>> Signed-off-by: Vignesh Raghavendra <vigneshr@ti.com>
>> ---
>> .../bindings/clock/ti,am654-ehrpwm-tbclk.yaml | 35 +++++++++++++++++++
>> 1 file changed, 35 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/clock/ti,am654-ehrpwm-tbclk.yaml
>>
>> diff --git a/Documentation/devicetree/bindings/clock/ti,am654-ehrpwm-tbclk.yaml b/Documentation/devicetree/bindings/clock/ti,am654-ehrpwm-tbclk.yaml
>> new file mode 100644
>> index 000000000000..3bf954ecb803
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/clock/ti,am654-ehrpwm-tbclk.yaml
>> @@ -0,0 +1,35 @@
>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/clock/ti,am654-ehrpwm-tbclk.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: TI syscon gate clock driver
>
> Bindings are for h/w blocks, not drivers.
>
Will drop driver from the title and commit msg
>> +
>> +maintainers:
>> + - Vignesh Raghavendra <vigneshr@ti.com>
>> +
>> +properties:
>> + compatible:
>> + items:
>> + - const: ti,am654-ehrpwm-tbclk
>> + - const: syscon
>
> Why is this a syscon? Are there other functions or it's just the easy
> way to get a regmap.
>
Register that has tbclk enable/disable bit also contains bits to control
other functionalities and would need to be shared. Therefore its modeled
as syscon.
Regards
Vignesh
>> +
>> + "#clock-cells":
>> + const: 1
>> +
>> + reg:
>> + maxItems: 1
>> +
>> +required:
>> + - compatible
>> + - "#clock-cells"
>> + - reg
>> +
>> +examples:
>> + - |
>> + ehrpwm_tbclk: syscon@4140 {
>> + compatible = "ti,am654-ehrpwm-tbclk", "syscon";
>> + reg = <0x4140 0x18>;
>> + #clock-cells = <1>;
>> + };
>> --
>> 2.25.0
>>
--
Regards
Vignesh
next prev parent reply other threads:[~2020-02-19 4:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-15 14:17 [PATCH v3 0/2] clk: keystone: Add new driver to handle ehrpwm tbclk Vignesh Raghavendra
2020-02-15 14:17 ` [PATCH v3 1/2] dt-bindings: clock: Add binding documentation for TI syscon gate clock Vignesh Raghavendra
2020-02-19 2:58 ` Rob Herring
2020-02-19 4:09 ` Vignesh Raghavendra [this message]
2020-02-15 14:17 ` [PATCH v3 2/2] clk: keystone: Add new driver to handle syscon based clocks Vignesh Raghavendra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5eb5521b-2752-68a3-c11d-eea38e325666@ti.com \
--to=vigneshr@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mturquette@baylibre.com \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
--cc=ssantosh@kernel.org \
--cc=t-kristo@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).