From: Wenchao Hao <haowenchao@huawei.com>
To: "James E . J . Bottomley" <jejb@linux.ibm.com>,
"Martin K . Petersen" <martin.petersen@oracle.com>,
<linux-scsi@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Cc: Zhiqiang Liu <liuzhiqiang26@huawei.com>,
Wenchao Hao <haowenchao@huawei.com>
Subject: Re: [PATCH] scsi: Do not break scan luns loop if add single lun failed
Date: Wed, 12 Jan 2022 10:28:36 +0800 [thread overview]
Message-ID: <5ec37028-052c-3851-6a89-983ab5ed4ae2@huawei.com> (raw)
In-Reply-To: <20211225232911.1117843-1-haowenchao@huawei.com>
On 2021/12/26 7:29, Wenchao Hao wrote:
> Failed to add a single lun does not mean all luns are unaccessible,
> if we break the scan luns loop, the other luns reported by REPORT LUNS
> command would not be probed any more.
>
> In this case, we might loss some luns which are accessible.
>
> Signed-off-by: Wenchao Hao <haowenchao@huawei.com>
> ---
> drivers/scsi/scsi_scan.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/scsi/scsi_scan.c b/drivers/scsi/scsi_scan.c
> index 23e1c0acdeae..fee7ce082103 100644
> --- a/drivers/scsi/scsi_scan.c
> +++ b/drivers/scsi/scsi_scan.c
> @@ -1476,13 +1476,13 @@ static int scsi_report_lun_scan(struct scsi_target *starget, blist_flags_t bflag
> lun, NULL, NULL, rescan, NULL);
> if (res == SCSI_SCAN_NO_RESPONSE) {
> /*
> - * Got some results, but now none, abort.
> + * Got some results, but now none, abort this lun
> */
> sdev_printk(KERN_ERR, sdev,
> "Unexpected response"
> " from lun %llu while scanning, scan"
> " aborted\n", (unsigned long long)lun);
> - break;
> + continue;
> }
> }
> }
>
ping ...
prev parent reply other threads:[~2022-01-12 2:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-25 23:29 [PATCH] scsi: Do not break scan luns loop if add single lun failed Wenchao Hao
2021-12-30 17:55 ` Steffen Maier
2022-01-04 12:10 ` Wenchao Hao
2022-01-12 2:28 ` Wenchao Hao [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5ec37028-052c-3851-6a89-983ab5ed4ae2@huawei.com \
--to=haowenchao@huawei.com \
--cc=jejb@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=liuzhiqiang26@huawei.com \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).