From: Amelie DELAUNAY <amelie.delaunay@st.com>
To: Rob Herring <robh@kernel.org>
Cc: Minas Harutyunyan <hminas@synopsys.com>,
Felipe Balbi <balbi@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Mark Rutland <mark.rutland@arm.com>, <linux-usb@vger.kernel.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-stm32@st-md-mailman.stormreply.com>,
Fabrice Gasnier <fabrice.gasnier@st.com>,
Benjamin Gaignard <benjamin.gaignard@st.com>
Subject: Re: [PATCHv2 1/2] dt-bindings: usb: dwc2: add support for STM32MP15 SoCs USB OTG HS and FS
Date: Fri, 17 Jan 2020 16:24:49 +0100 [thread overview]
Message-ID: <5eca6d14-27d8-0ac9-5c4f-9e0bc40d7f93@st.com> (raw)
In-Reply-To: <20200117144837.GA27455@bogus>
On 1/17/20 3:48 PM, Rob Herring wrote:
> On Thu, Jan 16, 2020 at 03:45:23PM +0100, Amelie Delaunay wrote:
>> Add the specific compatible string for the DWC2 IP found in the STM32MP15
>> SoCs.
>> STM32MP15 SoCs uses sensing comparators to detect Vbus valid levels and
>> ID pin state. usb33d-supply described the regulator supplying Vbus and ID
>> sensing comparators.
>>
>> Signed-off-by: Amelie Delaunay <amelie.delaunay@st.com>
>> ---
>> Documentation/devicetree/bindings/usb/dwc2.yaml | 6 ++++++
>> 1 file changed, 6 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/usb/dwc2.yaml b/Documentation/devicetree/bindings/usb/dwc2.yaml
>> index 71cf7ba32237..0b86250b97a9 100644
>> --- a/Documentation/devicetree/bindings/usb/dwc2.yaml
>> +++ b/Documentation/devicetree/bindings/usb/dwc2.yaml
>> @@ -58,6 +58,8 @@ properties:
>> - const: st,stm32f4x9-fsotg
>> - const: st,stm32f4x9-hsotg
>> - const: st,stm32f7-hsotg
>> + - const: st,stm32mp15-fsotg
>> + - const: st,stm32mp15-hsotg
>> - const: samsung,s3c6400-hsotg
>>
>> reg:
>> @@ -103,6 +105,10 @@ properties:
>> vusb_a-supply:
>> description: phandle to voltage regulator of analog section.
>>
>> + vusb33d_supply:
>
> Not a valid regulator property.
>
arrgh, was ok in the v1 in .txt. Will send a v3 fixing it with
vusb33d-supply instead.
>> + description: reference to the external VBUS and ID sensing comparators, in
>> + order to perform OTG operation, used on STM32MP15 SoCs.
>
> Are they external or part of the SoC? When we have Vbus sense and ID
> GPIOs, those go in the connector node, so this probably should too if
> these are board components.
>
Yes, they are part of the SoC but external of the DWC2 IP. You can find
them in the box "3V3 USB Detector" of PWR block diagram of STM32MP15x
[1]. In OTG block diagram also, it corresponds to "OTG detection" box.
Behind this vusb33d supply, it is a regulator provided by PWR regulator
driver. Maybe I should say "reference to the VBUS and ID sensing
comparators *supply*.
[1]
https://www.st.com/content/ccc/resource/technical/document/reference_manual/group0/51/ba/9e/5e/78/5b/4b/dd/DM00327659/files/DM00327659.pdf/jcr:content/translations/en.DM00327659.pdf
Regards,
Amelie
> Rob
>
next prev parent reply other threads:[~2020-01-17 15:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-16 14:45 [PATCHv2 0/2] USB DWC2 support for STM32MP15 SoCs USB OTG Amelie Delaunay
2020-01-16 14:45 ` [PATCHv2 1/2] dt-bindings: usb: dwc2: add support for STM32MP15 SoCs USB OTG HS and FS Amelie Delaunay
2020-01-17 14:48 ` Rob Herring
2020-01-17 15:24 ` Amelie DELAUNAY [this message]
2020-01-16 14:45 ` [PATCHv2 2/2] " Amelie Delaunay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5eca6d14-27d8-0ac9-5c4f-9e0bc40d7f93@st.com \
--to=amelie.delaunay@st.com \
--cc=balbi@kernel.org \
--cc=benjamin.gaignard@st.com \
--cc=devicetree@vger.kernel.org \
--cc=fabrice.gasnier@st.com \
--cc=gregkh@linuxfoundation.org \
--cc=hminas@synopsys.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=linux-usb@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).