From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by smtp.lore.kernel.org (Postfix) with ESMTP id A84EAC433EF
	for <linux-kernel@archiver.kernel.org>; Sat, 20 Nov 2021 21:51:13 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S232118AbhKTVyQ (ORCPT <rfc822;linux-kernel@archiver.kernel.org>);
        Sat, 20 Nov 2021 16:54:16 -0500
Received: from mail-4018.proton.ch ([185.70.40.18]:30417 "EHLO
        mail-4018.proton.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S231846AbhKTVyP (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Sat, 20 Nov 2021 16:54:15 -0500
Date:   Sat, 20 Nov 2021 21:51:05 +0000
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=connolly.tech;
        s=protonmail; t=1637445070;
        bh=YrdUs9a9Pkb/YPdOak/pS/H8ZRR0hMElATwxRnAmpcY=;
        h=Date:To:From:Cc:Reply-To:Subject:In-Reply-To:References:From;
        b=MKdWm7h5Lj2xA108qaTCYY/V2U8C3ps84Ufclbf17EXC2SofvV0ktiFgqtqDnJgV/
         VYTqXMw5hV9ZYs9WQZzs0+fut/I+pjE24lBgPCFpB3XYj3I5o/mgMpxqucTTEZSYoK
         ufeMKDx0brMzDHq4POemGFVMyWj3jbIbJOQVqvcw=
To:     Dang Huynh <danct12@riseup.net>
From:   Caleb Connolly <caleb@connolly.tech>
Cc:     Andy Gross <agross@kernel.org>,
        Bjorn Andersson <bjorn.andersson@linaro.org>,
        Rob Herring <robh+dt@kernel.org>,
        linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, Alexey Min <alexey.min@gmail.com>,
        Martin Botka <martin.botka@somainline.org>,
        Konrad Dybcio <konradybcio@gmail.com>
Reply-To: Caleb Connolly <caleb@connolly.tech>
Subject: Re: [PATCH v4 5/8] arm64: dts: qcom: sdm660-xiaomi-lavender: Add volume up button
Message-ID: <5ecda386-0ae3-cf46-9f91-1f54c3b4f89d@connolly.tech>
In-Reply-To: <20211120214227.779742-6-danct12@riseup.net>
References: <20211120214227.779742-1-danct12@riseup.net> <20211120214227.779742-6-danct12@riseup.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org



On 20/11/2021 21:42, Dang Huynh wrote:
> This enables the volume up key.
>
> Signed-off-by: Dang Huynh <danct12@riseup.net>
> ---
>   .../arm64/boot/dts/qcom/sdm660-xiaomi-lavender.dts | 14 ++++++++++++++
>   1 file changed, 14 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sdm660-xiaomi-lavender.dts b/arch/a=
rm64/boot/dts/qcom/sdm660-xiaomi-lavender.dts
> index 9a6684922804..c7bdf4c28be4 100644
> --- a/arch/arm64/boot/dts/qcom/sdm660-xiaomi-lavender.dts
> +++ b/arch/arm64/boot/dts/qcom/sdm660-xiaomi-lavender.dts
> @@ -9,6 +9,8 @@
>   #include "sdm660.dtsi"
>   #include "pm660.dtsi"
>   #include "pm660l.dtsi"
> +#include <dt-bindings/input/input.h>
> +#include <dt-bindings/input/gpio-keys.h>
>
>   / {
>   =09model =3D "Xiaomi Redmi Note 7";
> @@ -33,6 +35,18 @@ vph_pwr: vph-pwr-regulator {
>   =09=09regulator-boot-on;
>   =09};
>
> +=09gpio-keys {
> +=09=09compatible =3D "gpio-keys";
> +=09=09input-name =3D "gpio-keys";
I don't think input-name is used anymore.
> +
> +=09=09volup {
> +=09=09=09label =3D "Volume Up";
> +=09=09=09gpios =3D <&pm660l_gpios 7 GPIO_ACTIVE_LOW>;
> +=09=09=09linux,code =3D <KEY_VOLUMEUP>;
> +=09=09=09debounce-interval =3D <15>;
> +=09=09};
> +=09};
> +
>   =09reserved-memory {
>   =09=09#address-cells =3D <2>;
>   =09=09#size-cells =3D <2>;
> --
> 2.33.1
>

--
Kind Regards,
Caleb