From: Florian Fainelli <f.fainelli@gmail.com>
To: Alexander Kochetkov <al.kochet@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Philippe Reynes <tremyfr@gmail.com>,
Peter Chen <peter.chen@nxp.com>,
Wei Yongjun <weiyongjun1@huawei.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: arc_emac: switch to phy_start()/phy_stop()
Date: Wed, 19 Apr 2017 14:08:49 -0700 [thread overview]
Message-ID: <5ed9e534-d134-2ba1-0276-0bc8bd949eb1@gmail.com> (raw)
In-Reply-To: <1492612195-16601-1-git-send-email-al.kochet@gmail.com>
On 04/19/2017 07:29 AM, Alexander Kochetkov wrote:
> The patch replace phy_start_aneg() with phy_start(). phy_start() call
> phy_start_aneg() as a part of startup sequence and allow recover from
> error (PHY_HALTED) state.
>
> Also added call phy_stop() to arc_emac_remove() to stop PHY state machine
> when MAC is down.
This looks fine. If you wanted to go further, you could move the
phy_connect(), phy_disconnect() calls down to the arc_emac_open()
respectively arc_emac_stop() as this would also allow the PHY device to
be fully suspended when the interface is unused.
>
> Signed-off-by: Alexander Kochetkov <al.kochet@gmail.com>
> ---
> drivers/net/ethernet/arc/emac_main.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/arc/emac_main.c b/drivers/net/ethernet/arc/emac_main.c
> index abc9f2a..188676d 100644
> --- a/drivers/net/ethernet/arc/emac_main.c
> +++ b/drivers/net/ethernet/arc/emac_main.c
> @@ -434,7 +434,7 @@ static int arc_emac_open(struct net_device *ndev)
> /* Enable EMAC */
> arc_reg_or(priv, R_CTRL, EN_MASK);
>
> - phy_start_aneg(ndev->phydev);
> + phy_start(ndev->phydev);
>
> netif_start_queue(ndev);
>
> @@ -556,6 +556,8 @@ static int arc_emac_stop(struct net_device *ndev)
> napi_disable(&priv->napi);
> netif_stop_queue(ndev);
>
> + phy_stop(ndev->phydev);
> +
> /* Disable interrupts */
> arc_reg_clr(priv, R_ENABLE, RXINT_MASK | TXINT_MASK | ERR_MASK);
>
>
--
Florian
next prev parent reply other threads:[~2017-04-19 21:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-19 14:29 [PATCH] net: arc_emac: switch to phy_start()/phy_stop() Alexander Kochetkov
2017-04-19 18:22 ` Sergei Shtylyov
2017-04-19 21:08 ` Florian Fainelli [this message]
2017-04-19 21:19 ` Alexander Kochetkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5ed9e534-d134-2ba1-0276-0bc8bd949eb1@gmail.com \
--to=f.fainelli@gmail.com \
--cc=al.kochet@gmail.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=peter.chen@nxp.com \
--cc=tremyfr@gmail.com \
--cc=weiyongjun1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).