From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752704AbcLFLgN (ORCPT ); Tue, 6 Dec 2016 06:36:13 -0500 Received: from mailout3.w1.samsung.com ([210.118.77.13]:13032 "EHLO mailout3.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751998AbcLFLgI (ORCPT ); Tue, 6 Dec 2016 06:36:08 -0500 MIME-version: 1.0 Content-type: text/plain; charset=utf-8; format=flowed X-AuditID: cbfec7ef-f79e76d000005b57-89-5846a2667fbb Subject: Re: [PATCH] DT: leds: Improve examples by adding some context To: =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= , Richard Purdie , linux-leds@vger.kernel.org Cc: Rob Herring , Mark Rutland , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= From: Jacek Anaszewski Message-id: <5eee6421-1e6c-3955-652c-dedd275b5827@samsung.com> Date: Tue, 06 Dec 2016 12:34:55 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 In-reply-to: <20161206083203.1726-1-zajec5@gmail.com> Content-transfer-encoding: 8bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprOKsWRmVeSWpSXmKPExsWy7djPc7ppi9wiDF5eV7KYf+Qcq8XlXXPY LLa+WcdosfT6RSaL3WsXMVm07j3CbrF711NWizUnUx04PNbMW8PosXPWXXaPTas62TzOT/X0 2DP/B6vH501yAWxRXDYpqTmZZalF+nYJXBnrdqxmLlgqULF8d2QDYx9vFyMnh4SAicSc59vZ IGwxiQv31gPZXBxCAssYJRb+OckK4XxmlJjY18YG0/H9Qy8jXNX594sYQRK8AoISPybfYwGx mQWsJJ79a4XqfsYo0fVwK1i3sICbxO47Z8FsEYFKiQl9j1hAipgF9gBN2vSeFSTBJmAo8fPF ayaIqXYSOxY+Zu9i5OBgEVCVWNGuCGKKCkRI7L6bClLBKWAq0fnyOTPEXnmJg1ees0Acuo1d YuMVa5ByCQFZiU0HmCHCLhIPbi1hhbCFJV4d38IOYctIdHYcZAK5RkJgMqPExWM3WSGc1YwS Gzs7oYZaSzT8/wX1JJ/EpG3TmSEW8Ep0tAlBlHhIrHt0Gmqoo8TFNVfBFgsJdDBKzPtZPoFR fhZScM1CCq5ZSF5YwMi8ilEktbQ4Nz212FCvODG3uDQvXS85P3cTIzC5nP53/P0OxqfNIYcY BTgYlXh4PzS4RgixJpYVV+YeYpTgYFYS4T01zy1CiDclsbIqtSg/vqg0J7X4EKM0B4uSOO/e BVfChQTSE0tSs1NTC1KLYLJMHJxSDYxKEy8v4br/r0b89IJ1ihJveUyK9JY+mL+05N2cC4oh K6Sibx+dLXRuwyNh3/pVP36YNKybcPW8zeqASz87Na6GZnWdbzqQmxG4d8nSxyfsfjQdb3po e7k//3fl5Kld/fcTMi78X7QxJX1f2pITkucuf+PfkBxrOn/L4WWvNiT3PHt0QXXjgcB9y5VY ijMSDbWYi4oTAbSwbG8qAwAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrBIsWRmVeSWpSXmKPExsVy+t/xK7pVi9wiDOb8MbaYf+Qcq8XlXXPY LLa+WcdosfT6RSaL3WsXMVm07j3CbrF711NWizUnUx04PNbMW8PosXPWXXaPTas62TzOT/X0 2DP/B6vH501yAWxRbjYZqYkpqUUKqXnJ+SmZeem2SqEhbroWSgp5ibmptkoRur4hQUoKZYk5 pUCekQEacHAOcA9W0rdLcMtYt2M1c8FSgYrluyMbGPt4uxg5OSQETCS+f+hlhLDFJC7cW88G YgsJLGGU+PSVB8TmFRCU+DH5HguIzSxgJvHl5WHWLkYuoJpnjBIz1xxhBUkIC7hJ7L5zFqxZ RKBSYvL5yWwQRV2MEk/2v2EEcZgF9jBKNE74DjaKTcBQ4ueL10wQK+wkdix8zN7FyMHBIqAq saJdESQsKhAhcWvVR7DrOAVMJTpfPmeGuEJe4uCV5ywTGAVmITlwFpIDZyEpW8DIvIpRJLW0 ODc9t9hQrzgxt7g0L10vOT93EyMw1rYd+7l5B+OljcGHGAU4GJV4eD80uEYIsSaWFVfmHmKU 4GBWEuE9Nc8tQog3JbGyKrUoP76oNCe1+BCjKdCtE5mlRJPzgWkgryTe0MTQ3NLQyNjCwtzI SEmct+TDlXAhgfTEktTs1NSC1CKYPiYOTqkGRl4rhYsJcnGaB6Z5MBrmKPps3rAi5Hfelx7v +fzz0vLnZgjoLvog2lmsnq/tVFvE+GKpucKZz2fuTZyu5++xcE3IswOzdwroVr+e9rhi1lau fK8Kz9kMctOmLvu1uVRQ+uX5pVvzmkL5O+a/YGzZbHOo5Ng5I5U77s/Sv24VZD6rmvXc6ovO YyWW4oxEQy3mouJEAHmITq3LAgAA X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20161206113500eucas1p18010b5686b156deeec25c076ce419b19 X-Msg-Generator: CA X-Sender-IP: 182.198.249.179 X-Local-Sender: =?UTF-8?B?SmFjZWsgQW5hc3pld3NraRtTUlBPTC1TeXN0ZW0gRlcgIChN?= =?UTF-8?B?Qikb7IK87ISx7KCE7J6QG1NlbmlvciBTb2Z0d2FyZSBFbmdpbmVlcg==?= X-Global-Sender: =?UTF-8?B?SmFjZWsgQW5hc3pld3NraRtTUlBPTC1TeXN0ZW0gRlcgIChN?= =?UTF-8?B?QikbU2Ftc3VuZyBFbGVjdHJvbmljcxtTZW5pb3IgU29mdHdhcmUgRW5naW5l?= =?UTF-8?B?ZXI=?= X-Sender-Code: =?UTF-8?B?QzEwG0VIURtDMTBDRDAyQ0QwMjc1MjY=?= CMS-TYPE: 201P X-HopCount: 7 X-CMS-RootMailID: 20161206083302epcas1p170eb3f7dd0ca9b86d580563605182225 X-RootMTR: 20161206083302epcas1p170eb3f7dd0ca9b86d580563605182225 References: <20161206083203.1726-1-zajec5@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Rafał, Thanks for the patch. On 12/06/2016 09:32 AM, Rafał Miłecki wrote: > From: Rafał Miłecki > > During my work on some new LED trigger I tried adding example similar to > the existing ones which received following comment from Rob: >> It's not really clear in the example this is an LED node as it is >> incomplete. > > Keeping that in mind I suggest adding context for the existing example > entries in hope to make documentation more clear. > > Signed-off-by: Rafał Miłecki > --- > Should this patch go through linux-leds tree? > > Richard, Jacek: would you take it? > --- > Documentation/devicetree/bindings/leds/common.txt | 28 +++++++++++++++-------- > 1 file changed, 18 insertions(+), 10 deletions(-) > > diff --git a/Documentation/devicetree/bindings/leds/common.txt b/Documentation/devicetree/bindings/leds/common.txt > index 696be57..24b6560 100644 > --- a/Documentation/devicetree/bindings/leds/common.txt > +++ b/Documentation/devicetree/bindings/leds/common.txt > @@ -61,16 +61,24 @@ property can be omitted. > > Examples: > > -system-status { > - label = "Status"; > - linux,default-trigger = "heartbeat"; > - ... > +gpio-leds { > + compatible = "gpio-leds"; > + > + system-status { > + label = "Status"; > + linux,default-trigger = "heartbeat"; > + gpios = <&gpio0 0 GPIO_ACTIVE_HIGH>; > + }; > }; > > -camera-flash { > - label = "Flash"; > - led-sources = <0>, <1>; > - led-max-microamp = <50000>; > - flash-max-microamp = <320000>; > - flash-max-timeout-us = <500000>; > +max77693-led { > + compatible = "maxim,max77693-led"; > + > + camera-flash { > + label = "Flash"; > + led-sources = <0>, <1>; > + led-max-microamp = <50000>; > + flash-max-microamp = <320000>; > + flash-max-timeout-us = <500000>; > + }; > }; > Although this file documents a sub-node properties it will be indeed useful to have the parent node in the example as well. Applied to the for-4.11 branch of linux-leds.git. -- Best regards, Jacek Anaszewski