linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Slark Xiao" <slark_xiao@163.com>
To: "Bjorn Helgaas" <helgaas@kernel.org>
Cc: bhelgaas@google.com, linux-pci@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re:Re: [PATCH] PCI: Add vendor ID for Quectel and Cinterion
Date: Fri, 28 Oct 2022 10:41:55 +0800 (CST)	[thread overview]
Message-ID: <5ef2b67c.fb2.1841c77abf2.Coremail.slark_xiao@163.com> (raw)
In-Reply-To: <20221027142742.GA826519@bhelgaas>

















At 2022-10-27 22:27:42, "Bjorn Helgaas" <helgaas@kernel.org> wrote:
>On Thu, Oct 27, 2022 at 07:51:23PM +0800, Slark Xiao wrote:
>> In MHI driver, there are some companies product still
>> do not have their own PCI vendor macro. So we add it
>> here to make the code neat. Ref ID could be found in
>> link https://pcisig.com/membership/member-companies.
>
>Rewrap to fill 75 columns.
>
>Post along with the patch that uses the definitions.
>
>> Signed-off-by: Slark Xiao <slark_xiao@163.com>
>> ---
>>  include/linux/pci_ids.h | 4 ++++
>>  1 file changed, 4 insertions(+)
>> 
>> diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h
>> index b362d90eb9b0..e3bfea06b90e 100644
>> --- a/include/linux/pci_ids.h
>> +++ b/include/linux/pci_ids.h
>> @@ -172,6 +172,10 @@
>>  #define PCI_DEVICE_ID_BERKOM_A4T		0xffa4
>>  #define PCI_DEVICE_ID_BERKOM_SCITEL_QUADRO	0xffa8
>>  
>> +#define PCI_VENDOR_ID_CINTERION		0x1269
>
>The URL above says 0x1269 belongs to Thales.  Maybe add a comment to
>that effect, similar to the one for PCI_VENDOR_ID_CB.
>
>> +#define PCI_VENDOR_ID_QUECTEL		0x1eac
>
>Both new definitions look like they're dropped in a random location.
>Please move them so the vendor IDs in the file remain sorted by
>numeric value.
>
Hi Bjorn,
  V2 version is sent. I add explanation about the relationship between Thales 
and CInterion. And I just  find these VIDs are sorted by numeric, so I fix it in v2.

Thanks. 
>>  #define PCI_VENDOR_ID_COMPAQ		0x0e11
>>  #define PCI_DEVICE_ID_COMPAQ_TOKENRING	0x0508
>>  #define PCI_DEVICE_ID_COMPAQ_TACHYON	0xa0fc
>> -- 
>> 2.34.1
>> 

      reply	other threads:[~2022-10-28  3:27 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-27 11:51 [PATCH] PCI: Add vendor ID for Quectel and Cinterion Slark Xiao
2022-10-27 14:27 ` Bjorn Helgaas
2022-10-28  2:41   ` Slark Xiao [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5ef2b67c.fb2.1841c77abf2.Coremail.slark_xiao@163.com \
    --to=slark_xiao@163.com \
    --cc=bhelgaas@google.com \
    --cc=helgaas@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).