From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932712AbdESVHu (ORCPT ); Fri, 19 May 2017 17:07:50 -0400 Received: from mail-cys01nam02on0061.outbound.protection.outlook.com ([104.47.37.61]:19168 "EHLO NAM02-CY1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932518AbdESVHm (ORCPT ); Fri, 19 May 2017 17:07:42 -0400 Authentication-Results: google.com; dkim=none (message not signed) header.d=none;google.com; dmarc=none action=none header.from=amd.com; Subject: Re: [PATCH v5 28/32] x86/mm, kexec: Allow kexec to be used with SME To: Borislav Petkov References: <20170418211612.10190.82788.stgit@tlendack-t1.amdoffice.net> <20170418212121.10190.94885.stgit@tlendack-t1.amdoffice.net> <20170517191755.h2xluopk2p6suw32@pd.tnic> <1b74e0e6-3dda-f638-461b-f73af9904360@amd.com> <20170519205836.3wvl3nztqyyouje3@pd.tnic> CC: , , , , , , , , , , Rik van Riel , =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= , Toshimitsu Kani , Arnd Bergmann , Jonathan Corbet , Matt Fleming , "Michael S. Tsirkin" , Joerg Roedel , Konrad Rzeszutek Wilk , Paolo Bonzini , Larry Woodman , Brijesh Singh , Ingo Molnar , Andy Lutomirski , "H. Peter Anvin" , Andrey Ryabinin , Alexander Potapenko , Dave Young , Thomas Gleixner , Dmitry Vyukov From: Tom Lendacky Message-ID: <5ef96f3a-6ebd-1d4d-7ac9-05dbed45d998@amd.com> Date: Fri, 19 May 2017 16:07:24 -0500 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20170519205836.3wvl3nztqyyouje3@pd.tnic> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [165.204.78.1] X-ClientProxiedBy: CY4PR04CA0038.namprd04.prod.outlook.com (10.172.133.24) To BN6PR12MB1138.namprd12.prod.outlook.com (10.168.226.140) X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN6PR12MB1138: X-MS-Office365-Filtering-Correlation-Id: 6d435c6e-9202-40d5-45f5-08d49efb1036 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(48565401081)(201703131423075)(201703031133081);SRVR:BN6PR12MB1138; X-Microsoft-Exchange-Diagnostics: 1;BN6PR12MB1138;3:5qL4AxtjSyvqMjXnYQj5r9CkJjMNZuofsujwQq2WK8fu3YYx/swHP2cvVBJXR9sKwD7AgNkoaH45Rp/eJAKhMybjkZfRY+jWuAxdkSfNO8O4N7c47glN10WjmCG/7MrHLMN86KlKqkgS9N6RN1fCv/GHb4JGaCaC5h005G8gwY0hphnJbs2uic6w4q/9nnB61WA/3T4T2C/L82QTlBCYqPxjS4ToXroY74hGuuzYH/zb5JhzAJB7+rgQYGGqx57wn2ZsRqS0o4nJZMdfK38zzXiDlyTiY32fJkN7W53r64F2NQJMy4Xot6FY/qO2PoRtSiQt+CkpFWN+KGTOS5sFGe7J26ahdvFaOt4bTimjXNU=;25:LkpO1c5ki37JsvBdcxz6lnwkrmpfuQ4TrzY8CW2wKR+MdSKDeJjXWD+Mz3/EW/WigVhx+L+DoVRztYAqafvYfOe3OIVAgAvuj68dw+6onAlOgr17gtoKqisiRoiHXZmRXKdNznPaIy0/WanBpalUoXDZIRGuD6cQ/fOcc5JlO5O3V0+atlVHmMszG0u67bV08GPxOyuI2V+7FdBjSax/QEELA0Km7nScePbpYW0w+vzhjbq/5N8fekBdUQd3ICLirtg77jOtJVBryT/ZXkO2t114/Y3/TWnr9dwALPVf5b0g9MOcPxfqfqQqr76B5GSaYV1ymxBtv7aFYs4m0YFDITmb31Q14gjsaOM1tqDaRAEagb+Of5WfAaCOU3r93Q2FxZ5GX4hWKjYaCZI0JeXyo2fXvLK/Qm7/lKLx+M5myT40GJoY2ZM7FHrCKe/sI9jLvthwzqygmeTodBV9kZ77w7nav32Ljf12J9xX/D4BVMQ= X-Microsoft-Exchange-Diagnostics: 1;BN6PR12MB1138;31:DvZiBvjhOxkIYZqsRunRc9glItV8z43dX77bCiHdrvoc4UsaVWyDxxxx7UNRk/CSlzJCaYlTglU2YtTVf53sY7QIMFm3lI5GXka1y3uiNPkN5oXuK2lUf75IgeFkql+3ESyvTqQhniRilYpTzKaZBKUIRoviZFHTaktDHgiuAjR3OWlY8IPzdmI/XjfK20cOc0cAoNoYuqQmcX6aQIp9fN+ODDtWiSOWM/80Tc2ppgs=;20:AtKm4NmAd3pznL0TvPtED3VYbRPou19Y6d8VCV0rQ3SVRVdtAjPTzyrLDA9Zctaa7ITYjNf0QKm/wbpIfH2vej5Yk/o8kKzdQhWqlW4VURd9yasL47UemGBDenOz8QYg/a/RGrRqGWtqe1PvGri9pTso3tLgH4AURwDRlgMV8xfEPXG0LD320klBzoF3Tap65Az/q07XNVQEqomuDYcI84yJd/xP6OByoe8mHSOu+WoyJ7cTjp+XHfFaNM0xuthkctas/5xfBxkeObI7o4e7qgIsRYqTRU9YQcUcHzjqWxYaqMrWtPXQZz6qfTwrQDll6eXp47iXxdYXKfCc9PtCVCxlce1+kWc7VUTJy4is049nQFHi/l5gfKfAedCHpGDAF+ZAbofjQvaQdFSdeFBqIVO1Yc5y3F8+eTkhTkFEMZaJwAz8+XGFc8x9qo1shES3kjNfZ7zRr8Mf7xAGa8qLagmDypy5hkVNw6Fx7SGbOKy8yJfnv1x41f4wMJ7OXnj+ X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040450)(601004)(2401047)(8121501046)(5005006)(93006095)(93001095)(10201501046)(3002001)(6055026)(6041248)(20161123562025)(20161123560025)(20161123558100)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123555025)(20161123564025)(6072148);SRVR:BN6PR12MB1138;BCL:0;PCL:0;RULEID:;SRVR:BN6PR12MB1138; X-Microsoft-Exchange-Diagnostics: 1;BN6PR12MB1138;4:mQACRLqRkgm9zoTKldslPj3GmkYo4BkWhOxF1DHHivjjrbCLXL8P3iFuVmx8d4kWWaJsggKzCMNbqJF355Rs3QQ87uAsAbtAKvEhMJWa/Mp1zDis2KtGt/AI8b96X289OhposvaS6rcN9CBm1/Ne6LJdWdnZ8XWLNWqMixtXdf9T+fhLSqatXUbWOEP7O3e2JwgaCgZGXonpLo5Ny4gQKVGD5ReuhgKCFyKy3y4AhDh/grlYZbRmVUJITwTMnHpgp2oq0hBnVO82EcYKkGu4UWNViHefa7xsHElVsUnp0z7tf/ytbZ+IrzdQU/8a3mAkh0BlrCJW9iw6XADTc+LnsR5AWDdw46KTnhiWlG5jnHH1OKCglUEVsfYzdQoS8AgbaKRdDSCCfLcn7TwXr0Aws1xJV3tuneloxhY97sPUuNajE8p9+eN7GCPxjxJVstMwhDLOQqqud4KF2rIdSKOuJSaJ1f5FmM7znd9wbBUk3f7dpTKsX1NKxfswDZ3pvwLAXUZWV+GmyVFMZ0flDq9OKt+xvGwEEn+poV44qygLRMYX1LV8wP+YGHgnkDMCQFqCmWwAY9mDMN8mpOuBUn0jl0/xr/oygLdhAUcsSC9qfjwEDMYafPbjy9cITFoxLMy2kWmEZCh7OAletV9RIR/BFUZSnHFFPdmRLZkwJhnpFV3ZCwY0HH0ArzdQt0MeK9feOeUg2LIqUEcj7TwqIWDO+HRc7YjXaaEWMFKk+wgxWw0YK0D0ZeUP36aa9153KE/K0TEUMfUDNJgwCnNzUrlExfoDh75d2Pwi9qz1nal9zL5V6sKHAfpWJj5ZjwHUnziU X-Forefront-PRVS: 031257FE13 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(6049001)(39840400002)(39860400002)(39410400002)(39400400002)(39450400003)(39850400002)(377454003)(24454002)(90366009)(53936002)(54906002)(33646002)(229853002)(110136004)(8676002)(4001350100001)(6916009)(38730400002)(23676002)(81166006)(305945005)(31696002)(31686004)(42186005)(6246003)(93886004)(2950100002)(478600001)(86362001)(6666003)(54356999)(50986999)(6116002)(189998001)(3846002)(65956001)(230700001)(36756003)(66066001)(76176999)(2906002)(65826007)(6486002)(47776003)(3260700006)(53546009)(77096006)(72206003)(25786009)(64126003)(50466002)(7416002)(5660300001)(83506001)(4326008);DIR:OUT;SFP:1101;SCL:1;SRVR:BN6PR12MB1138;H:[10.236.64.250];FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtCTjZQUjEyTUIxMTM4OzIzOnhjTXI5ZzRMbU55ZjI1c0NWMDNjcmZCVy80?= =?utf-8?B?REQ5YnNtdlVBSDFjL1FVL3pNOVo1cDNPemZBWk1ZdGpSTXhuZnNyZk5TMk1M?= =?utf-8?B?ak9vRGJxQWlFbUQ1UkpvNEFFRFE4TURUSGVVcERadFRIMEdLY2JvSnkvKzlt?= =?utf-8?B?aDNkdmZkd0tPNmYzTFRvQVYwMmJobnowc242akhRM1R5cFFodTFMSHQyUmlh?= =?utf-8?B?NlZSVzV4RWRxRitvdXJtcDBySUtHWUZCdWZXNlRUNTBDT2RIdEZaT1hLdzR4?= =?utf-8?B?bVh2Q2Vqbno4K0dFQWJxcnpnbGlETURNSnZoc2NkY0ZzNDA4bE5VRE5acGgr?= =?utf-8?B?LzRDaFI0VUZNYWlLazBpcVQ1aXpncUdlWitRd2JERzRNdmpFQnp3VG83VGVN?= =?utf-8?B?RFdWcEpOM1JPTVVUOVNHKytPOUVWeDZVRkU2SHJEU05ZTTRMQ1owWGp1S2wz?= =?utf-8?B?enVEcHpJUVBsVTdKdkVUNEZSc3ZRR2lJUUZEbnlWNStLZUNKNWZQMHBZYW1l?= =?utf-8?B?bmE3S0JKb0ZXaE84eURkOU5rSy9ZRktZVGdISi9vdU5NbnJhY3lWL25kRkpy?= =?utf-8?B?U2cvUHMxd2FRREtPN0J6RFpnMUZabU5COUpwTjU3bDhCcVYyTFEySUxCVGZm?= =?utf-8?B?NVJvd1h3bkszSXFTaGsvVlNEeTVkUW5mdDBPNDJpOFJWMHJXZ1IvM0RQQmFC?= =?utf-8?B?U213OVNxbXZEUlFTWlErMTFtTzkvOGcrSm01U1Y1TmdxUzc3bnBDa1dKVEhK?= =?utf-8?B?UzU1a0xrWDV5aHlGdTFWN3pyOHJaMmI5d2l1d3RDdjN2Mll5cEg5cG0xSFdq?= =?utf-8?B?TEQ4MDh6aFdQM2p5S1NXanJPZFlMZk40WXNmNlZqY01lOHAyZjdWSURPb1lq?= =?utf-8?B?WWhPZ0VVN1UreUFpWlkzaUp2MHlENCtYMmdJZ0QyMmlxZVd4WVFyY3BpSTBZ?= =?utf-8?B?ZjlhczhYSXc1WFBJemVVWjZBQnpiQTFWTDBQNHRXUXM3SFAwc1JRN0FKODls?= =?utf-8?B?WXVzWFpzTkc3RXN2RVZ6ZXljYjFBRzF5dVVIZm9QUStHdEJLUU5SKzFIWEpq?= =?utf-8?B?bTV0OFBTbklNS3NTcGZEbE05VUFzUkQ0QmZya2t1MGZPR1RvTkRud1RsamFk?= =?utf-8?B?WER5SUFrVFBBQVJ2Y0U5akpUVU1leGtDU0NWbEhUSUt6SHlhZnc4QWY1N3hh?= =?utf-8?B?YUoyL3YwT1ZLck9JT1ZJcUFud3BLQnlDMnpYMWtyQkQ2SndRRVBzR1l1RVpk?= =?utf-8?B?ajdVNnJjMnlwQ25yZmNRM3dKTjNNZU9mMDVWTGZGSFB2dldxMFB0MUE1ejRx?= =?utf-8?B?SlJhTGU1aStleUdGZHZzYkdpcDN3dkIwL1lQWnJoOFZWRFZzWDhnaGc2ZnpN?= =?utf-8?B?d0dpMHZURmEwZENWRUNLK0FqcXBsdVh1SUFwUDhZQytsbVEzcFd0MS9MdWlj?= =?utf-8?B?L1ZZUzJpeURlSXlOWUdVOXlWK05sUDNvQjR5NzRhY0k4bWZZcHpUVnJxWXQ4?= =?utf-8?B?dnIxZm91QTJTVVlnRE4yTG9HdnlXZ1o0R3VxNDlzVDhUbG03QmJIVkdqanJx?= =?utf-8?B?SmM3b21KQjNQZVI4ZGFTT1I0aFZndzNpdllIUG0rZUR6K1VPc1Y2enJ5cCto?= =?utf-8?B?akdwL3dCbmFELzljajZ6S21DOWhLL3c4UExKYXpROHkzYytoMGJRUUtKYWw3?= =?utf-8?B?Q2kzOVZIYm45UU9uSW01c2dsbEJWeEdHclI2bGl2Vm11Nnl5czZwMlNZSk9Q?= =?utf-8?B?NFB2enVYNkFSWHBpM1lDa3lOYnBGdisrVGhKQzF1UGRGZnpnZjRpcklvelMy?= =?utf-8?B?bmlNMVJGZmQzY1MvSnh5YndaTDROSy9FWW1pVzZSNzRocG1zWm1VNVd2UG1W?= =?utf-8?B?UmdRbFZXem4yUzdMc3A1ZlJadm14MEpSdldEc3ExcWRnSGZzS0dSR3pQZjkv?= =?utf-8?B?ZzZyU3o4YkdnPT0=?= X-Microsoft-Exchange-Diagnostics: 1;BN6PR12MB1138;6:YhM84CpKyJ2eGFJO7IC63VFlXu/uEyRa06yz6ItGPax4U3dSC7xbC8xyqiTS8SHNeoxPw/4jXMNcCnE3MDwoQ04xxO/6gxJ0CxJUq9elhyfMj5+QbzogVJJBr74ejqOTRHQab3jrz12Y+jzgRr9fh7vlh5k09WVRwJ6F/8PG2vc3Gv4g350Ic5fyS21EwqpmQRAT7O/CbwjAgU/qm7wDym1EdTJvhRaXh7heYyuyDioZHCw/HyPFbAqPamTyf4KTttI3EvBEW/sSsa48li51qViBCaPctP4PFaiHoGonZEEp0PwmCiE+xrVGBBgy3oxjavkgYn+zy6QvLLvmZ1tAmeA2WlH2yBFo9bHSb2Vs7kdgQ5QfgOCx7cKwten0+UB5c3VGYEBVqQPoc8vylg7DL8mOsedf85D2SsTHbzaLGNNI92GWnR17OqdNiXcOEjfYoU2fddus1NBM5k4u+kLKNdIKWk2ToORWE6fUqVGnUnA7iUxY7AaQ3OvMy9/0tccG7CvsukHHshoG5e3/4Jh+LvOCx7EpTvqd3u5rHvuSw+4=;5:gZwmjDm6DSbym4pNrL1g0ePYMpwZ8/vG0XGHTGYX9FgWjN/kXDrIQr6p2oGBsFo6VeHU9ofVBrsSz9/iZK80vktmyXYgqIfVw5x4Atz6WiqYHL+ouk/NrWNlQoInedkO/R/0j/hh44UPqIhPj2h3IA==;24:I8kRL237Go+AuMRo1YqOj612mE94MU1DsUKfTPbuhLmlQJmjEIsV0MUzWLy73lWyh5DvAzl7u4ZjsdYxJ2Pk3F2CFfIpYDDLpHcB8Als6bc= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;BN6PR12MB1138;7:YlBOaW8cxI9SMRFDlR3gcM4FeUvyBJSj5CC6XIZeANokEY47unwBpnDQrPoR6B4veFKoG5rd9XCIO8y5oBVPP/y/IiIb7bLv2YO7kte8iqkvwvjRYjgaW5kCAj8ArY43Qq8bZdarkTmkn3Rmuuwl6T9AiFPkYd9xN3Ev4PZQ5bPMS7xhC8w5pcMxu2ctA4FL1OB8jOiXPCQchpBN8G77YJzwd3BX5n9nCabgwz9nwIKrjz877MAIJo1fYj7ZrbaBreyxjIocCHibHeqPhOFLMM7zoTtCaand0cBvwwpSTxv5oz6DNKsNNK5TR2CPbuEgHSwPRYFcr115D3DZnPQScQ==;20:Ju6hGGUrXz5lKHytNWTE6o+kf4cgBQr9PXOPwJ2/Vl4apUqnPAU+QUPSPfHMS8a21MkKW6VL+w+ec4ue5s/qSOEzxkXuaUXzA7k5jXxXTnlNBSx/qhPJm2gyov/QwvqMrOOoswbEJae04+6mY7cbLzqhuFxSOsYIwDJm/CRTtSrs8uNQ/JXO5OOxTndu6b2GqkmnkCBupwJvZuia6YwIiiZqHndnZUj4TIoqbEtCHJzL/5OJ1b7MKCWOmV8aZ1CF X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 May 2017 21:07:28.2560 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR12MB1138 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/19/2017 3:58 PM, Borislav Petkov wrote: > On Fri, May 19, 2017 at 03:45:28PM -0500, Tom Lendacky wrote: >> Actually there is. The above will result in data in the cache because >> halt() turns into a function call if CONFIG_PARAVIRT is defined (refer >> to the comment above where do_wbinvd_halt is set to true). I could make >> this a native_wbinvd() and native_halt() > > That's why we have the native_* versions - to bypass paravirt crap. As long as those never change from static inline everything will be fine. I can change it, but I really like how it explicitly indicates what is needed in this case. Even if the function gets changed from static inline the fact that the instructions are sequential in the function covers that case. Thanks, Tom >