From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0DF70C433E6 for ; Tue, 5 Jan 2021 08:57:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B9E6822582 for ; Tue, 5 Jan 2021 08:57:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727298AbhAEI5x (ORCPT ); Tue, 5 Jan 2021 03:57:53 -0500 Received: from smtprelay0213.hostedemail.com ([216.40.44.213]:48806 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726982AbhAEI5w (ORCPT ); Tue, 5 Jan 2021 03:57:52 -0500 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay01.hostedemail.com (Postfix) with ESMTP id 55201100E7B44; Tue, 5 Jan 2021 08:57:11 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: snail54_12179a2274d7 X-Filterd-Recvd-Size: 2375 Received: from [192.168.1.159] (unknown [47.151.137.21]) (Authenticated sender: joe@perches.com) by omf04.hostedemail.com (Postfix) with ESMTPA; Tue, 5 Jan 2021 08:57:10 +0000 (UTC) Message-ID: <5f01770454d163605406265b1bf316e0452753cf.camel@perches.com> Subject: Re: [PATCH v3 3/5] checkpatch: kconfig: enforce help text indentation From: Joe Perches To: Nicolai Fischer , linux-kernel@vger.kernel.org Cc: apw@canonical.com, akpm@linux-foundation.org, johannes.czekay@fau.de, linux-kernel@i4.cs.fau.de Date: Tue, 05 Jan 2021 00:57:09 -0800 In-Reply-To: <0e8754d14cb5624704159ba85b18f8a6bb703b27.camel@perches.com> References: <20201226140511.662368-1-nicolai.fischer@fau.de> <20210103075015.23946-1-nicolai.fischer@fau.de> <20210103075015.23946-4-nicolai.fischer@fau.de> <0e8754d14cb5624704159ba85b18f8a6bb703b27.camel@perches.com> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.38.1-1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2021-01-04 at 14:09 -0800, Joe Perches wrote: > On Sun, 2021-01-03 at 08:50 +0100, Nicolai Fischer wrote: > > Adds a new warning in case the indentation level of the > > first line of a Kconfig help message is not at least two spaces > > higher than the keyword itself. > > Blank lines between the message and the help keyword > > are ignored. > > > > Co-developed-by: Johannes Czekay > > Signed-off-by: Johannes Czekay > > Signed-off-by: Nicolai Fischer > > --- > > > > Now matches indentation of two or more spaces, instead of exactly two. > > No, this should match exactly 2 and warn on any other use. To clarify, only the first line after the help keyword needs to have a 2 space indent more than the help keyword and the help block may start with Kconfig keywords. Subsequent help block lines may have more than 2 chars. The help block line count should end when the indent is less than the help keyword indent and is a non-blank line. This should be valid: help line 1 -- reason 1 -- reason 2 continuation -- reason 3 But this should warn only on line 1: help line 1 has a 3 space indent -- reason 1 -- reason 2 continuation -- reason 3