From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S941478AbcIHNVS (ORCPT ); Thu, 8 Sep 2016 09:21:18 -0400 Received: from ducie-dc1.codethink.co.uk ([185.25.241.215]:34854 "EHLO ducie-dc1.codethink.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933159AbcIHNVP (ORCPT ); Thu, 8 Sep 2016 09:21:15 -0400 Subject: Re: [PATCH 0/2] spi: meson: Add Amlogic GXBB compatible To: =?UTF-8?Q?Andreas_F=c3=a4rber?= , Neil Armstrong References: <1473321206-32284-1-git-send-email-narmstrong@baylibre.com> <293061a8-e867-4d91-20cb-6e5df8e9b543@suse.de> <4a199a95-3ee6-a3a0-bc8a-63bd0912e7d2@suse.de> Cc: devicetree , khilman@baylibre.com, linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, broonie@kernel.org, carlo@caione.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org From: Ben Dooks Organization: Codethink Limited. Message-ID: <5f05c488-1889-057b-7068-8e070ff95611@codethink.co.uk> Date: Thu, 8 Sep 2016 14:21:04 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Icedove/45.2.0 MIME-Version: 1.0 In-Reply-To: <4a199a95-3ee6-a3a0-bc8a-63bd0912e7d2@suse.de> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/09/16 13:50, Andreas Färber wrote: > Am 08.09.2016 um 14:04 schrieb Andreas Färber: >> Am 08.09.2016 um 09:53 schrieb Neil Armstrong: >>> This patchset adds a specific compatible string in the Meson SPIFC driver for >>> the Amlogic Meson GXBB SoC. >> >> Any particular reason? We could just reuse the meson6 one since there >> appear to be no code changes so far. > > So Neil is essentially telling me they don't know whether there are any > differences in the IP block, so a separate compatible string was chosen. > > No objection from my side, but a general clarification from device tree > maintainers when and when not to would be appreciated. (+ devicetree) I prefer to add both the device-tree itself, so if there are differences found later then it can be dealt with without rebuilding both the DT and kernel. It is nice to have the new ones added to the driver so that you know the hardware choices in play. -- Ben Dooks http://www.codethink.co.uk/ Senior Engineer Codethink - Providing Genius