From: Daniel Thompson <daniel.thompson@linaro.org>
To: Christophe Leroy <christophe.leroy@c-s.fr>
Cc: Jason Wessel <jason.wessel@windriver.com>,
Michael Ellerman <mpe@ellerman.id.au>,
linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
kgdb-bugreport@lists.sourceforge.net, stable@vger.kernel.org,
me@tobin.cc
Subject: Re: Re: [PATCH] kdb: use correct pointer when 'btc' calls 'btt'
Date: Wed, 26 Sep 2018 12:11:06 +0100 [thread overview]
Message-ID: <5f0e0241-b7ab-b5fa-de0e-01abdbc85770@linaro.org> (raw)
In-Reply-To: <20180916190610.vzqxwps7zqy2zc6o@holly.lan>
On 16/09/2018 20:06, Daniel Thompson wrote:
> On Fri, Sep 14, 2018 at 12:35:44PM +0000, Christophe Leroy wrote:
>> On a powerpc 8xx, 'btc' fails as follows:
>>
>> Entering kdb (current=0x(ptrval), pid 282) due to Keyboard Entry
>> kdb> btc
>> btc: cpu status: Currently on cpu 0
>> Available cpus: 0
>> kdb_getarea: Bad address 0x0
>>
>> when booting the kernel with 'debug_boot_weak_hash', it fails as well
>>
>> Entering kdb (current=0xba99ad80, pid 284) due to Keyboard Entry
>> kdb> btc
>> btc: cpu status: Currently on cpu 0
>> Available cpus: 0
>> kdb_getarea: Bad address 0xba99ad80
>>
>> On other platforms, Oopses have been observed too, see
>> https://github.com/linuxppc/linux/issues/139
>>
>> This is due to btc calling 'btt' with %p pointer as an argument.
>>
>> This patch replaces %p by %px to get the real pointer value as
>> expected by 'btt'
>>
>> Signed-off-by: Christophe Leroy <christophe.leroy@c-s.fr>
>> Cc: <stable@vger.kernel.org> # 4.15+
>
> Would a Fixes: be better here?
> Fixes: ad67b74d2469d9b82 ("printk: hash addresses printed with %p")
Christophe, When you add the Fixes: could you also add my
Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org>
Thanks.
>
> No blame attached to Tobin, but the fixes makes it super clear what
> changed and why this breaks kdb (which was not explicitly called out
> the patch description).
>
>
> Daniel.
>
>> ---
>> kernel/debug/kdb/kdb_bt.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/kernel/debug/kdb/kdb_bt.c b/kernel/debug/kdb/kdb_bt.c
>> index 6ad4a9fcbd6f..7921ae4fca8d 100644
>> --- a/kernel/debug/kdb/kdb_bt.c
>> +++ b/kernel/debug/kdb/kdb_bt.c
>> @@ -179,14 +179,14 @@ kdb_bt(int argc, const char **argv)
>> kdb_printf("no process for cpu %ld\n", cpu);
>> return 0;
>> }
>> - sprintf(buf, "btt 0x%p\n", KDB_TSK(cpu));
>> + sprintf(buf, "btt 0x%px\n", KDB_TSK(cpu));
>> kdb_parse(buf);
>> return 0;
>> }
>> kdb_printf("btc: cpu status: ");
>> kdb_parse("cpu\n");
>> for_each_online_cpu(cpu) {
>> - sprintf(buf, "btt 0x%p\n", KDB_TSK(cpu));
>> + sprintf(buf, "btt 0x%px\n", KDB_TSK(cpu));
>> kdb_parse(buf);
>> touch_nmi_watchdog();
>> }
>> --
>> 2.13.3
>>
next prev parent reply other threads:[~2018-09-26 11:11 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-14 12:35 [PATCH] kdb: use correct pointer when 'btc' calls 'btt' Christophe Leroy
2018-09-16 19:06 ` Daniel Thompson
2018-09-16 22:18 ` Tobin C. Harding
2018-09-26 11:11 ` Daniel Thompson [this message]
2018-09-26 11:19 ` Christophe LEROY
2018-09-27 11:09 ` Michael Ellerman
2018-09-27 11:30 ` Christophe LEROY
2018-09-28 12:57 ` Michael Ellerman
2018-10-01 19:52 ` Jason Wessel
2018-11-10 21:42 ` Olof Johansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5f0e0241-b7ab-b5fa-de0e-01abdbc85770@linaro.org \
--to=daniel.thompson@linaro.org \
--cc=christophe.leroy@c-s.fr \
--cc=jason.wessel@windriver.com \
--cc=kgdb-bugreport@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=me@tobin.cc \
--cc=mpe@ellerman.id.au \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).