From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01288C64EC4 for ; Thu, 9 Mar 2023 02:54:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229874AbjCICyr (ORCPT ); Wed, 8 Mar 2023 21:54:47 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34078 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229523AbjCICyp (ORCPT ); Wed, 8 Mar 2023 21:54:45 -0500 Received: from ex01.ufhost.com (ex01.ufhost.com [61.152.239.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E871469CC2; Wed, 8 Mar 2023 18:54:43 -0800 (PST) Received: from EXMBX166.cuchost.com (unknown [175.102.18.54]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "EXMBX166", Issuer "EXMBX166" (not verified)) by ex01.ufhost.com (Postfix) with ESMTP id 82E7224E1DB; Thu, 9 Mar 2023 10:54:41 +0800 (CST) Received: from EXMBX061.cuchost.com (172.16.6.61) by EXMBX166.cuchost.com (172.16.6.76) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Thu, 9 Mar 2023 10:54:41 +0800 Received: from [192.168.125.128] (183.27.96.115) by EXMBX061.cuchost.com (172.16.6.61) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Thu, 9 Mar 2023 10:54:40 +0800 Message-ID: <5f11e476-6017-46e3-f601-d192765c5fb2@starfivetech.com> Date: Thu, 9 Mar 2023 10:54:43 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v4 3/3] riscv: dts: starfive: jh7100: Add watchdog node Content-Language: en-US To: Emil Renner Berthing CC: , , , Wim Van Sebroeck , Guenter Roeck , Krzysztof Kozlowski , Emil Renner Berthing , Conor Dooley , Rob Herring , "Paul Walmsley" , Palmer Dabbelt , Albert Ou , Philipp Zabel , Samin Guo , References: <20230308034036.99213-1-xingyu.wu@starfivetech.com> <20230308034036.99213-4-xingyu.wu@starfivetech.com> From: Xingyu Wu In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [183.27.96.115] X-ClientProxiedBy: EXCAS064.cuchost.com (172.16.6.24) To EXMBX061.cuchost.com (172.16.6.61) X-YovoleRuleAgent: yovoleflag Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2023/3/9 0:09, Emil Renner Berthing wrote: > On Wed, 8 Mar 2023 at 04:42, Xingyu Wu wrote: >> >> Add watchdog node for the StarFive JH7100 RISC-V SoC. >> >> Signed-off-by: Xingyu Wu >> --- >> arch/riscv/boot/dts/starfive/jh7100.dtsi | 10 ++++++++++ >> 1 file changed, 10 insertions(+) >> >> diff --git a/arch/riscv/boot/dts/starfive/jh7100.dtsi b/arch/riscv/boot/dts/starfive/jh7100.dtsi >> index 000447482aca..1eb7c21a94fd 100644 >> --- a/arch/riscv/boot/dts/starfive/jh7100.dtsi >> +++ b/arch/riscv/boot/dts/starfive/jh7100.dtsi >> @@ -238,5 +238,15 @@ i2c3: i2c@12460000 { >> #size-cells = <0>; >> status = "disabled"; >> }; >> + >> + wdog: watchdog@12480000 { > > I don't see anything referencing this node, so the label can be dropped. > With that fixed: > Reviewed-by: Emil Renner Berthing > Will drop the label and just use: watchdog@12480000 { Best regards, Xingyu Wu