From: cang@codeaurora.org
To: Doug Anderson <dianders@chromium.org>
Cc: subhashj@codeaurora.org, Asutosh Das <asutoshd@codeaurora.org>,
Vivek Gautam <vivek.gautam@codeaurora.org>,
Evan Green <evgreen@chromium.org>,
Rajendra Nayak <rnayak@codeaurora.org>,
Vinayak Holikatti <vinholikatti@gmail.com>,
jejb@linux.vnet.ibm.com,
"Martin K. Petersen" <martin.petersen@oracle.com>,
linux-scsi@vger.kernel.org,
linux-arm-msm <linux-arm-msm@vger.kernel.org>,
venkatg@codeaurora.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 1/1] scsi: ufs: make UFS Tx lane1 clock optional for QCOM platforms
Date: Sat, 13 Oct 2018 10:13:02 +0800 [thread overview]
Message-ID: <5f2d152941aed6411f54d47dd7ec199e@codeaurora.org> (raw)
In-Reply-To: <CAD=FV=WjO9YvKHDiEDt8+8TJ_JjnzcVAqB99nhP5LwnWO0fuLw@mail.gmail.com>
On 2018-10-13 00:55, Doug Anderson wrote:
> Hi,
>
> On Thu, Oct 11, 2018 at 6:12 PM Can Guo <cang@codeaurora.org> wrote:
>> + if (err != -EPROBE_DEFER)
>> + dev_err(dev, "failed to get %s err %d",
>> + name, err);
>
> I wouldn't spin just for this, but if you spin for some other reason
> you could move the above "dev_err" onto one line now. Sorry: I should
> have noticed that / done that on my patch...
>
>
Yeah... I didn't notice it too. Shall push a new one to address it.
>> @@ -141,24 +147,21 @@ static int ufs_qcom_enable_lane_clks(struct
>> ufs_qcom_host *host)
>
> Idea for a future patch: now that I look at what's left of this
> function you're basically re-implementing clk_bulk_prepare_enable()
> and clk_bulk_disable_unprepare() now. I bet your code would be
> cleaner / nicer by switching to that.
>
> ...possibly you might need to improve the clk_bulk_get() API to allow
> for some clock to be optional, but that would be a pretty easy patch
> to post up.
>
> In any case I think it's better to do the clk_bulk switch in a future
> / separate patch, so:
>
> Reviewed-by: Douglas Anderson <dianders@chromium.org>
> Tested-by: Douglas Anderson <dianders@chromium.org>
>
>
> -Doug
That is a good idea, I shall follow up after this one is merged.
Thank you.
-Can Guo
prev parent reply other threads:[~2018-10-13 2:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-12 1:12 [PATCH v3 1/1] scsi: ufs: make UFS Tx lane1 clock optional for QCOM platforms Can Guo
2018-10-12 6:10 ` Vivek Gautam
2018-10-12 6:46 ` cang
2018-10-12 16:55 ` Doug Anderson
2018-10-13 2:13 ` cang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5f2d152941aed6411f54d47dd7ec199e@codeaurora.org \
--to=cang@codeaurora.org \
--cc=asutoshd@codeaurora.org \
--cc=dianders@chromium.org \
--cc=evgreen@chromium.org \
--cc=jejb@linux.vnet.ibm.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=rnayak@codeaurora.org \
--cc=subhashj@codeaurora.org \
--cc=venkatg@codeaurora.org \
--cc=vinholikatti@gmail.com \
--cc=vivek.gautam@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).