From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C2C3FC47254 for ; Tue, 5 May 2020 12:20:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A0A9E20735 for ; Tue, 5 May 2020 12:20:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="WU/xSzDR" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728737AbgEEMUW (ORCPT ); Tue, 5 May 2020 08:20:22 -0400 Received: from lelv0143.ext.ti.com ([198.47.23.248]:46578 "EHLO lelv0143.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727090AbgEEMUV (ORCPT ); Tue, 5 May 2020 08:20:21 -0400 Received: from fllv0035.itg.ti.com ([10.64.41.0]) by lelv0143.ext.ti.com (8.15.2/8.15.2) with ESMTP id 045CKC1d091262; Tue, 5 May 2020 07:20:12 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1588681212; bh=33urkOujjL8eDQqLN/MMIk9++M7FiWab7tR7NHM+1C0=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=WU/xSzDRKiMWoIZl6UWuffzuHpkfOvdCh6Y3DXwDOWiXZlIXtr/D5CaznKuHQgHnm jlmaeanMLpur4FCZnp8CnrJkwTd71CUhBx9R+0iNNTeNqMQiyYaBWQS3EqLGlGGRwy 16PvEiMps7CVR1mDG3PqsWF1vDCGfViAzDjaEfF8= Received: from DFLE114.ent.ti.com (dfle114.ent.ti.com [10.64.6.35]) by fllv0035.itg.ti.com (8.15.2/8.15.2) with ESMTP id 045CKCwJ040109; Tue, 5 May 2020 07:20:12 -0500 Received: from DFLE111.ent.ti.com (10.64.6.32) by DFLE114.ent.ti.com (10.64.6.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3; Tue, 5 May 2020 07:20:11 -0500 Received: from fllv0040.itg.ti.com (10.64.41.20) by DFLE111.ent.ti.com (10.64.6.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3 via Frontend Transport; Tue, 5 May 2020 07:20:11 -0500 Received: from [10.250.100.73] (ileax41-snat.itg.ti.com [10.172.224.153]) by fllv0040.itg.ti.com (8.15.2/8.15.2) with ESMTP id 045CK7qD102805; Tue, 5 May 2020 07:20:08 -0500 Subject: Re: [PATCH net-next 3/7] net: ethernet: ti: am65-cpsw-nuss: enable packet timestamping support To: Anders Roxell CC: Richard Cochran , Murali Karicheri , "David S. Miller" , Rob Herring , Tero Kristo , Lokesh Vutla , Networking , Sekhar Nori , Linux Kernel Mailing List , , Linux ARM , Clay McClure References: <20200501205011.14899-1-grygorii.strashko@ti.com> <20200501205011.14899-4-grygorii.strashko@ti.com> <1bf51157-9fee-1948-f9ff-116799d12731@ti.com> From: Grygorii Strashko Message-ID: <5f338763-b35b-e2b4-7f15-df3a5bcbb799@ti.com> Date: Tue, 5 May 2020 15:20:06 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Anders, On 05/05/2020 14:59, Anders Roxell wrote: > On Tue, 5 May 2020 at 13:16, Anders Roxell wrote: >> On Tue, 5 May 2020 at 13:05, Grygorii Strashko wrote: >>> On 05/05/2020 13:17, Anders Roxell wrote: >>>> On Fri, 1 May 2020 at 22:50, Grygorii Strashko wrote: >>>>> >>>>> The MCU CPSW Common Platform Time Sync (CPTS) provides possibility to >>>>> timestamp TX PTP packets and all RX packets. >>>>> >>>>> This enables corresponding support in TI AM65x/J721E MCU CPSW driver. >>>>> >>>>> Signed-off-by: Grygorii Strashko >>>>> --- >>>>> drivers/net/ethernet/ti/Kconfig | 1 + >>>>> drivers/net/ethernet/ti/am65-cpsw-ethtool.c | 24 ++- >>>>> drivers/net/ethernet/ti/am65-cpsw-nuss.c | 172 ++++++++++++++++++++ >>>>> drivers/net/ethernet/ti/am65-cpsw-nuss.h | 6 +- >>>>> 4 files changed, 201 insertions(+), 2 deletions(-) >>>>> >>>>> diff --git a/drivers/net/ethernet/ti/Kconfig b/drivers/net/ethernet/ti/Kconfig >>>>> index 1f4e5b6dc686..2c7bd1ccaaec 100644 >>>>> --- a/drivers/net/ethernet/ti/Kconfig >>>>> +++ b/drivers/net/ethernet/ti/Kconfig >>>>> @@ -100,6 +100,7 @@ config TI_K3_AM65_CPSW_NUSS >>>>> depends on ARCH_K3 && OF && TI_K3_UDMA_GLUE_LAYER >>>>> select TI_DAVINCI_MDIO >>>>> imply PHY_TI_GMII_SEL >>>>> + imply TI_AM65_CPTS >>>> >>>> Should this be TI_K3_AM65_CPTS ? > > instead of 'imply TI_K3_AM65_CPTS' don't you want to do this: > 'depends on TI_K3_AM65_CPTS || !TI_K3_AM65_CPTS' > > Right, I'll try. It seems your defconfig is produced by randconfig as I can't get broken cfg TI_AM65_CPTS=m and TI_K3_AM65_CPSW_NUSS=y with neither one below: make ARCH=arm64 O=k3-arm64 defconfig make ARCH=arm64 O=k3-arm64 allnoconfig make ARCH=arm64 O=k3-arm64 allyesconfig make ARCH=arm64 O=k3-arm64 allmodconfig make ARCH=arm64 O=k3-arm64 alldefconfig make ARCH=arm64 O=k3-arm64 yes2modconfig make ARCH=arm64 O=k3-arm64 mod2yesconfig Related legacy TI CPTS threads: https://lkml.org/lkml/2020/5/2/344 https://lkml.org/lkml/2020/5/1/1348 I'd try summarize goal TI_K3_AM65_CPSW_NUSS TI_AM65_CPTS Y Y/N M Y/M/N N Y/M/N -- Best regards, grygorii