From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 570E7C10F14 for ; Thu, 11 Apr 2019 11:31:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 16FF02184E for ; Thu, 11 Apr 2019 11:31:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726825AbfDKLbo convert rfc822-to-8bit (ORCPT ); Thu, 11 Apr 2019 07:31:44 -0400 Received: from smtp.asem.it ([151.1.184.197]:61040 "EHLO smtp.asem.it" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726599AbfDKLbn (ORCPT ); Thu, 11 Apr 2019 07:31:43 -0400 Received: from webmail.asem.it by asem.it (smtp.asem.it) (SecurityGateway 5.5.0) with ESMTP id SG003807162.MSG for ; Thu, 11 Apr 2019 13:31:40 +0200S Received: from ASAS044.asem.intra (172.16.16.44) by ASAS044.asem.intra (172.16.16.44) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1261.35; Thu, 11 Apr 2019 13:31:38 +0200 Received: from ASAS044.asem.intra ([::1]) by ASAS044.asem.intra ([::1]) with mapi id 15.01.1261.035; Thu, 11 Apr 2019 13:31:38 +0200 From: Flavio Suligoi To: Mark Brown CC: Daniel Mack , Haojian Zhuang , Robert Jarzmik , "linux-arm-kernel@lists.infradead.org" , "linux-spi@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: RE: [PATCH 2/2] spi: pxa2xx: use a module softdep for dw_dmac Thread-Topic: [PATCH 2/2] spi: pxa2xx: use a module softdep for dw_dmac Thread-Index: AQHU75yQbkDNn+rZPkCFgi0S9cPL1qY1OMwAgAAnBxCAAAN6AIABJ5/AgAAaxACAAC8xIA== Date: Thu, 11 Apr 2019 11:31:38 +0000 Message-ID: <5f59962528d343938ae5978da8edd68d@asem.it> References: <1554900696-28858-1-git-send-email-f.suligoi@asem.it> <1554900696-28858-2-git-send-email-f.suligoi@asem.it> <20190410125612.GR6106@sirena.org.uk> <6eeaf42f4d3f42c58546c429194213b8@asem.it> <20190410152820.GT6106@sirena.org.uk> <7ad025c8049e4e828ce75ef1e41dcbfd@asem.it> <20190411104212.GA7953@sirena.org.uk> In-Reply-To: <20190411104212.GA7953@sirena.org.uk> Accept-Language: it-IT, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [172.16.17.208] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-SGHeloLookup-Result: pass smtp.helo=webmail.asem.it (ip=172.16.16.44) X-SGSPF-Result: none (smtp.asem.it) X-SGOP-RefID: str=0001.0A0C020F.5CAF259A.008B,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0 (_st=1 _vt=0 _iwf=0) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > > > Right, yes - that analysis seems correct. The interfaces seem a bit > > > weird here but fixing them looks like the most complete and robust > fix. > > > Ok Mark, I'll fix this problem as soon as I can, using EPROBE_DEFER. > > For now, in my application, I use the patch that I already sent, > > with the "softdep" workaround: > > > MODULE_SOFTDEP("pre: dw_dmac"); > > > I tested it a lot, with more than 2000 cold reboot (automatic > > switch on/off using a controlled power supply) and it always worked > good. > > Right, and to be clear that patch is good and useful independently of > the deferred probe fix so assuming nothing else comes up in review I'll > apply it. Thanks Mark, Flavio