From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B48E0C432C3 for ; Tue, 19 Nov 2019 01:26:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 959BE20692 for ; Tue, 19 Nov 2019 01:26:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727126AbfKSB0L (ORCPT ); Mon, 18 Nov 2019 20:26:11 -0500 Received: from mga09.intel.com ([134.134.136.24]:25527 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726775AbfKSB0L (ORCPT ); Mon, 18 Nov 2019 20:26:11 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Nov 2019 17:26:10 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,322,1569308400"; d="scan'208";a="380852691" Received: from linux.intel.com ([10.54.29.200]) by orsmga005.jf.intel.com with ESMTP; 18 Nov 2019 17:26:10 -0800 Received: from [10.226.38.254] (unknown [10.226.38.254]) by linux.intel.com (Postfix) with ESMTP id 9E0795800FE; Mon, 18 Nov 2019 17:26:07 -0800 (PST) Subject: Re: [PATCH v7 2/3] dwc: PCI: intel: PCIe RC controller driver To: Jingoo Han , "gustavo.pimentel@synopsys.com" , "lorenzo.pieralisi@arm.com" , "andrew.murray@arm.com" , "helgaas@kernel.org" , "robh@kernel.org" , "martin.blumenstingl@googlemail.com" , "linux-pci@vger.kernel.org" , "devicetree@vger.kernel.org" , "andriy.shevchenko@intel.com" Cc: "linux-kernel@vger.kernel.org" , "cheol.yong.kim@intel.com" , "chuanhua.lei@linux.intel.com" , "qi-ming.wu@intel.com" References: <99a29f5a4ce18df26bd300ac6728433ec025631b.1573784557.git.eswara.kota@linux.intel.com> <50dabbc6-eae5-5ae5-95a0-f195c1ef7362@linux.intel.com> From: Dilip Kota Message-ID: <5fc0001f-e73c-af1d-4182-d2d2448741fd@linux.intel.com> Date: Tue, 19 Nov 2019 09:26:06 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/19/2019 12:40 AM, Jingoo Han wrote: > > On 11/18/19, 2:58 AM, Dilip Kota wrote: > >> On 11/16/2019 4:40 AM, Jingoo Han wrote: >>> On 11/14/19, 9:31 PM, Dilip Kota wrote: >>> >>>> Add support to PCIe RC controller on Intel Gateway SoCs. >>>> PCIe controller is based of Synopsys DesignWare PCIe core. >>>> >>>> Intel PCIe driver requires Upconfigure support, Fast Training >>>> Sequence and link speed configurations. So adding the respective >>>> helper functions in the PCIe DesignWare framework. >>>> It also programs hardware autonomous speed during speed >>>> configuration so defining it in pci_regs.h. >>>> >>>> Signed-off-by: Dilip Kota >>>> Reviewed-by: Andrew Murray >>>> Acked-by: Gustavo Pimentel >>>> --- >>> [.....] >>> >>>> drivers/pci/controller/dwc/Kconfig | 10 + >>>> drivers/pci/controller/dwc/Makefile | 1 + >>>> drivers/pci/controller/dwc/pcie-designware.c | 57 +++ >>>> drivers/pci/controller/dwc/pcie-designware.h | 12 + >>>> drivers/pci/controller/dwc/pcie-intel-gw.c | 542 +++++++++++++++++++++++++++ >>>> include/uapi/linux/pci_regs.h | 1 + >>>> 6 files changed, 623 insertions(+) >>>> create mode 100644 drivers/pci/controller/dwc/pcie-intel-gw.c >>>> >>>> diff --git a/drivers/pci/controller/dwc/Kconfig b/drivers/pci/controller/dwc/Kconfig >>>> index 0ba988b5b5bc..fb6d474477df 100644 >>>> --- a/drivers/pci/controller/dwc/Kconfig >>>> +++ b/drivers/pci/controller/dwc/Kconfig >>>> @@ -82,6 +82,16 @@ config PCIE_DW_PLAT_EP >>>> order to enable device-specific features PCI_DW_PLAT_EP must be >>>> selected. >>>> >>>> +config PCIE_INTEL_GW >>>> + bool "Intel Gateway PCIe host controller support" >>>> + depends on OF && (X86 || COMPILE_TEST) >>>> + select PCIE_DW_HOST >>>> + help >>>> + Say 'Y' here to enable PCIe Host controller support on Intel >>>> + Gateway SoCs. >>>> + The PCIe controller uses the DesignWare core plus Intel-specific >>>> + hardware wrappers. >>>> + >>> Please add this config alphabetical order! >>> So, this config should be after 'config PCI_IMX6'. >>> There is no reason to put this config at the first place. >>> >>>> config PCI_EXYNOS >>>> bool "Samsung Exynos PCIe controller" >>>> depends on SOC_EXYNOS5440 || COMPILE_TEST >>>> diff --git a/drivers/pci/controller/dwc/Makefile b/drivers/pci/controller/dwc/Makefile >>>> index b30336181d46..99db83cd2f35 100644 >>>> --- a/drivers/pci/controller/dwc/Makefile >>>> +++ b/drivers/pci/controller/dwc/Makefile >>>> @@ -3,6 +3,7 @@ obj-$(CONFIG_PCIE_DW) += pcie-designware.o >>>> obj-$(CONFIG_PCIE_DW_HOST) += pcie-designware-host.o >>>> obj-$(CONFIG_PCIE_DW_EP) += pcie-designware-ep.o >>>> obj-$(CONFIG_PCIE_DW_PLAT) += pcie-designware-plat.o >>>> +obj-$(CONFIG_PCIE_INTEL_GW) += pcie-intel-gw.o >>> Ditto. >> PCIE_INTEL_GW wouldnt come after PCI_IMX6, the complete Makefile and >> Kconfig are not in order,( PCI_* and PCIE_* are not in any order). So i >> just followed PCIE_DW and placed PCIE_INTEL_GW after PCIE_DW as I is >> after D (and i see PCI_* immediately after the PCIE_DW*, so i placed >> PCIE_INTEL_GW after PCIE_DW* and before PCI_*). > Hey, although some of them are not in order, you don't have a right to do so. > If some people do not follow the law, it does not mean that you can break the law. > Anyway, if you don't follow an alphabetical order, my answer is NACK. > Also, other people or I will send a patch to fix the order of other drivers. I am not against following the order. I kept PCIE_INTEL_GW after PCIE_DW* by checking the best possible order. As per the alphabetical order, i see all CONFIG_PCIE_* comes first and CONFIG_PCI_* follows. So, by following this, i placed PCIE_INTEL_GW after PCIE_DW* (for the same reason PCIE_INTEL_GW cannot be placed after PCI_IMX6). Even after re-ordering the Kconfig and Makefile, still PCIE_INTEL_GW comes after PCIE_DW_PLAT( and PCIE_HISI_STB). Regards, Dilip > > >> Regards, >> Dilip >> Best regards, >> Jingoo Han >> >>> obj-$(CONFIG_PCI_DRA7XX) += pci-dra7xx.o >>> obj-$(CONFIG_PCI_EXYNOS) += pci-exynos.o >>> obj-$(CONFIG_PCI_IMX6) += pci-imx6.o >>> diff --git a/drivers/pci/controller/dwc/pcie-designware.c b/drivers/pci/controller/dwc/pcie-designware.c >>> index 820488dfeaed..479e250695a0 100644 >> [.....]