From: Mathias Nyman <mathias.nyman@linux.intel.com>
To: "Walt Jr. Brake" <mr.yming81@gmail.com>
Cc: chunfeng.yun@mediatek.com, matthias.bgg@gmail.com,
nishadkamdar@gmail.com, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, eddie.hung@mediatek.com,
Alan Stern <stern@rowland.harvard.edu>,
Greg KH <gregkh@linuxfoundation.org>
Subject: Re: [PATCH] xhci: Fix USB 3.1 enumeration issues by increasing roothub power-on-good delay
Date: Fri, 5 Nov 2021 21:41:24 +0200 [thread overview]
Message-ID: <5fc1dc0b-6fd0-2162-4e1d-9420ecabc337@linux.intel.com> (raw)
In-Reply-To: <8301c7f7-4c63-5681-af53-9edc67d96d17@gmail.com>
On 5.11.2021 19.32, Walt Jr. Brake wrote:
> On 6/11/2021 00:09, Mathias Nyman wrote:
>> On 5.11.2021 18.00, Mathias Nyman wrote:
>>> Some USB 3.1 enumeration issues were reported after the hub driver removed
>>> the minimum 100ms limit for the power-on-good delay.
>>>
>>> Since commit 90d28fb53d4a ("usb: core: reduce power-on-good delay time of
>>> root hub") the hub driver sets the power-on-delay based on the
>>> bPwrOn2PwrGood value in the hub descriptor.
>>>
>>> xhci driver has a 20ms bPwrOn2PwrGood value for both roothubs based
>>> on xhci spec section 5.4.8, but it's clearly not enough for the
>>> USB 3.1 devices, causing enumeration issues.
>>>
>>> Tests indicate full 100ms delay is needed.
>>>
>>> Reported-by: Walt Jr. Brake <mr.yming81@gmail.com>
>>> Signed-off-by: Mathias Nyman <mathias.nyman@linux.intel.com>
>>>
>> Walt Jr Brake, just to be sure could you test this one as well?
>>
>> As Alan suggested this sets 100ms for the USB 3 roothub but
>> keeps the 20ms for the USB 2 roothub.
>>
>> Thanks
>> -Mathias
>
> Yes I tested, it works too.
>
Thank you
-Mathias
next prev parent reply other threads:[~2021-11-05 19:40 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-10 1:20 [PATCH v2] usb: core: reduce power-on-good delay time of root hub Chunfeng Yun
2021-11-01 3:33 ` Walt Jr. Brake
[not found] ` <5e907ccd-40bb-2ece-fe05-1a65a74f3aa2@gmail.com>
2021-11-01 14:06 ` Alan Stern
2021-11-02 9:05 ` Mathias Nyman
2021-11-02 20:29 ` Walt Jr. Brake
2021-11-03 20:37 ` Mathias Nyman
2021-11-05 10:00 ` Greg Kroah-Hartman
2021-11-05 13:30 ` Alan Stern
2021-11-05 16:00 ` [PATCH] xhci: Fix USB 3.1 enumeration issues by increasing roothub power-on-good delay Mathias Nyman
2021-11-05 16:09 ` Mathias Nyman
2021-11-05 17:32 ` Walt Jr. Brake
2021-11-05 19:41 ` Mathias Nyman [this message]
2021-11-05 16:15 ` Greg KH
2021-11-05 19:56 ` Mathias Nyman
2021-11-06 14:41 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5fc1dc0b-6fd0-2162-4e1d-9420ecabc337@linux.intel.com \
--to=mathias.nyman@linux.intel.com \
--cc=chunfeng.yun@mediatek.com \
--cc=eddie.hung@mediatek.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-usb@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=mr.yming81@gmail.com \
--cc=nishadkamdar@gmail.com \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).