From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
To: Boris Ostrovsky <boris.ostrovsky@oracle.com>,
Oleksandr Andrushchenko <andr2000@gmail.com>,
xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org, linux-media@vger.kernel.org,
jgross@suse.com, konrad.wilk@oracle.com
Cc: daniel.vetter@intel.com, dongwon.kim@intel.com,
matthew.d.roper@intel.com
Subject: Re: [PATCH v5 0/8] xen: dma-buf support for grant device
Date: Mon, 23 Jul 2018 18:50:56 +0300 [thread overview]
Message-ID: <5fc34b4b-3587-791a-d17c-7da955b393bd@epam.com> (raw)
In-Reply-To: <9d2889f6-32d3-03d7-2a6d-341e691287b3@oracle.com>
On 07/23/2018 06:22 PM, Boris Ostrovsky wrote:
> On 07/23/2018 09:26 AM, Oleksandr Andrushchenko wrote:
>> On 07/23/2018 11:38 AM, Oleksandr Andrushchenko wrote:
>>>> data/upstream/linux-xen/drivers/xen/gntdev-dmabuf.c: In function
>>>> ‘gntdev_ioctl_dmabuf_exp_from_refs’:
>>>> /data/upstream/linux-xen/drivers/xen/gntdev-dmabuf.c:503:6: warning:
>>>> ‘args.fd’ may be used uninitialized in this function
>>>> [-Wmaybe-uninitialized]
>>>> *fd = args.fd;
>>>> ~~~~^~~~~~~~~
>>>> /data/upstream/linux-xen/drivers/xen/gntdev-dmabuf.c:467:35: note:
>>>> ‘args.fd’ was declared here
>>>> struct gntdev_dmabuf_export_args args;
>>>> ^~~~
>>> Strangely, but my i386 build goes smooth.
>>> Which version of gcc you use and could you please give me your
>>> .config, so I can test the same?
>> Now I see this warning which seems to be a false positive.
>> Boris, could you please apply the following:
>>
>> diff --git a/drivers/xen/gntdev-dmabuf.c b/drivers/xen/gntdev-dmabuf.c
>> index e4c9f1f74476..0680dbcba616 100644
>> --- a/drivers/xen/gntdev-dmabuf.c
>> +++ b/drivers/xen/gntdev-dmabuf.c
>> @@ -495,6 +495,7 @@ static int dmabuf_exp_from_refs(struct gntdev_priv
>> *priv, int flags,
>> args.dmabuf_priv = priv->dmabuf_priv;
>> args.count = map->count;
>> args.pages = map->pages;
>> + args.fd = -1;
>>
>> ret = dmabuf_exp_from_pages(&args);
>> if (ret < 0)
>>
>> or please let me know if you want me to resend with this fix?
>
> Missed this message. Yes, this obviously fixes the problem. And it is
> due to the code fragment that I mentioned in the earlier response.
>
> Which patch is this for? I can add this when committing.
Thank you, this is for "[PATCH v5 7/8] xen/gntdev: Implement dma-buf
export functionality"
> -boris
Thank you,
Oleksandr
next prev parent reply other threads:[~2018-07-23 15:51 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-20 9:01 [PATCH v5 0/8] xen: dma-buf support for grant device Oleksandr Andrushchenko
2018-07-20 9:01 ` [PATCH v5 1/8] xen/grant-table: Make set/clear page private code shared Oleksandr Andrushchenko
2018-07-20 9:01 ` [PATCH v5 2/8] xen/balloon: Share common memory reservation routines Oleksandr Andrushchenko
2018-07-20 9:01 ` [PATCH v5 3/8] xen/grant-table: Allow allocating buffers suitable for DMA Oleksandr Andrushchenko
2018-07-20 9:01 ` [PATCH v5 4/8] xen/gntdev: Allow mappings for DMA buffers Oleksandr Andrushchenko
2018-07-20 9:01 ` [PATCH v5 5/8] xen/gntdev: Make private routines/structures accessible Oleksandr Andrushchenko
2018-07-20 9:01 ` [PATCH v5 6/8] xen/gntdev: Add initial support for dma-buf UAPI Oleksandr Andrushchenko
2018-07-20 9:01 ` [PATCH v5 7/8] xen/gntdev: Implement dma-buf export functionality Oleksandr Andrushchenko
2018-07-20 9:01 ` [PATCH v5 8/8] xen/gntdev: Implement dma-buf import functionality Oleksandr Andrushchenko
2018-07-20 14:08 ` [PATCH v5 0/8] xen: dma-buf support for grant device Boris Ostrovsky
2018-07-23 8:38 ` Oleksandr Andrushchenko
2018-07-23 13:26 ` Oleksandr Andrushchenko
2018-07-23 15:22 ` Boris Ostrovsky
2018-07-23 15:50 ` Oleksandr Andrushchenko [this message]
2018-07-23 15:16 ` Boris Ostrovsky
2018-07-31 17:04 ` Boris Ostrovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5fc34b4b-3587-791a-d17c-7da955b393bd@epam.com \
--to=oleksandr_andrushchenko@epam.com \
--cc=andr2000@gmail.com \
--cc=boris.ostrovsky@oracle.com \
--cc=daniel.vetter@intel.com \
--cc=dongwon.kim@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jgross@suse.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=matthew.d.roper@intel.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).