From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92135C43613 for ; Mon, 24 Jun 2019 16:21:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 62FC820657 for ; Mon, 24 Jun 2019 16:21:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="j/ELAhg2" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732084AbfFXQV4 (ORCPT ); Mon, 24 Jun 2019 12:21:56 -0400 Received: from mail-io1-f67.google.com ([209.85.166.67]:33646 "EHLO mail-io1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732035AbfFXQVx (ORCPT ); Mon, 24 Jun 2019 12:21:53 -0400 Received: by mail-io1-f67.google.com with SMTP id u13so1759970iop.0 for ; Mon, 24 Jun 2019 09:21:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=EO8eeZ48f6EoVfLk0+Ia7DkcWqdLXYNwWud7QgwjUxA=; b=j/ELAhg2UmVVT/WszfKjP0eVP6XomPXTVwyKZdSvtL+ZfxzgYeaOtX9ahKvHpdamwH yVYSC/sOcvC8M2NmLy8DvQG5D7Z/9PyPVOM9lRo7OPF78WmueHL0Jgp1zGC2hWPlPP4l hTKVN++WoXD0aVpQikgglS80GZqpeLwsNlRnC3v8TH9LiWO6KIVVwG513TZgIvq6yUod bz50kbawIi6oofsSlwp9FymUCenj4mpFg7X7Uv9wYKx04iWTbcLMvqdhMU/A6/BaGxR+ Uv4bT5iOViDyTKoOUWZaxUnDw0W0DlptJe0+0yKvAjAmhuuHpCDLUYaCza9GBCGYL7XJ R2aQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=EO8eeZ48f6EoVfLk0+Ia7DkcWqdLXYNwWud7QgwjUxA=; b=pbag3YHDeXe4Le2a7+tj6VD28fVuZBuLx40F+/BFe34UguzH9gEMVRNGBzDQaoUg7b Qa9fzZCNUsC4p/7S2irvlJfSAjQ5Un/76egy/+bBX+iAuk6Y759L4NfiveqQ5IH93ewa EgQHGP3Y30oGqHjaDX60YIew+mmBcuZX2xvalOxbsYbUQbTIo5rbzOtGeH2DMDfawsUF PK8mW1XeyFjc59dGqMIODnQm+RAM+c+jqNqZVcrtHusd8/j+mmzJLUTM5ZzsrqtpFriJ ZsvERuej5808yNfYnqJDdnoyBH9RFRTo+RYeC0ilYIGqFw+LNNys0jaujc87MLNBRCK5 rjkw== X-Gm-Message-State: APjAAAV5S5OMKr/8ecexl68gQ/9HFkkqh10nauKxGQ1VZMxLL55N1hnA ozfOXxGeTVeffs0nSzmImsIgaw== X-Google-Smtp-Source: APXvYqxz3FaFhWw2FnWfg4aUKQQZ6vaEckamt/BYnOdzvhusMwszWyk5+OepCRBdKbupvmmVwjgR3w== X-Received: by 2002:a5e:9308:: with SMTP id k8mr266555iom.143.1561393312086; Mon, 24 Jun 2019 09:21:52 -0700 (PDT) Received: from [172.22.22.26] (c-71-195-29-92.hsd1.mn.comcast.net. [71.195.29.92]) by smtp.googlemail.com with ESMTPSA id l11sm14545587ioj.32.2019.06.24.09.21.50 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 24 Jun 2019 09:21:51 -0700 (PDT) Subject: Re: [PATCH v2 00/17] net: introduce Qualcomm IPA driver To: Johannes Berg , Arnd Bergmann Cc: abhishek.esse@gmail.com, Ben Chan , Bjorn Andersson , cpratapa@codeaurora.org, David Miller , Dan Williams , DTML , Eric Caruso , evgreen@chromium.org, Ilias Apalodimas , Linux ARM , linux-arm-msm@vger.kernel.org, Linux Kernel Mailing List , linux-soc@vger.kernel.org, Networking , Subash Abhinov Kasiviswanathan , syadagir@codeaurora.org References: <380a6185-7ad1-6be0-060b-e6e5d4126917@linaro.org> <583907409fad854bd3c18be688ec2724ad7a60e9.camel@sipsolutions.net> <31c2c94c-c6d3-595b-c138-faa54d0bfc00@linaro.org> From: Alex Elder Message-ID: <5ffbcce1-f93d-5746-5037-9dcc03cd73f0@linaro.org> Date: Mon, 24 Jun 2019 11:21:50 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/18/19 2:22 PM, Johannes Berg wrote: > On Tue, 2019-06-18 at 09:00 -0500, Alex Elder wrote: . . . > Anyway, I think for now we could probably live with not having this > configurable for the IPA driver, and if it *does* need to be > configurable, it seems like it should be a driver configuration, not a > channel configuration - so something like a debugfs hook if you really > just need to play with it for performance testing, or a module > parameter, or something else? > > Or even, in the WWAN framework, a knob that we provide there for the > WWAN device, rather than for the (newly created) channel. Agreed. I think a knob is appropriate, it's just a question of how that control exposed. Same answer to your question below. -Alex >> The hardware is capable of aggregating QMAP packets >> arriving on a connection into a single buffer, so this provides >> a way of requesting it do that. >> >>>> #define RMNET_FLAGS_INGRESS_MAP_COMMANDS (1U << 1) >>> >>> Similar here? If you have flow control you probably want to use it? >> >> I agree with that, though perhaps there are cases where it >> is pointless, or can't be supported, so one might want to >> simply *not* implement/advertise the feature. I don't know. > > Sure, but then that's likely something the driver would need to know, > not necessarily userspace? > > johannes >