Re: [PATCH 0/7] perf tools: Add switch-output size and time threshold options

["Wangnan (F)" <wangnan0@huawei.com>]

On 2017/1/3 16:19, Jiri Olsa wrote:
> hi,
> adding a way to configure switch data output
> for size and time, like:
>
>    $ sudo perf record -e 'sched:*' --switch-output=10M -avg
>    callchain: type FP
>    switch-output with 10M size threshold
>    mmap size 528384B
>    [ perf record: dump data: Woken up 37 times ]
>    [ perf record: Dump perf.data.2017010309135512 ]
>    [ perf record: dump data: Woken up 39 times ]
>    [ perf record: Dump perf.data.2017010309135771 ]
>    [ perf record: dump data: Woken up 38 times ]
>    [ perf record: Dump perf.data.2017010309140005 ]
>    ^C[ perf record: Woken up 16 times to write data ]
>    [ perf record: Dump perf.data.2017010309140111 ]
>    [ perf record: Captured and wrote 4.748 MB perf.data.<timestamp> ]
>    ...
>
> the default for switch-output option stays
> and does the SIGUSR2 output switch
>
> Also available in:
>    git://git.kernel.org/pub/scm/linux/kernel/git/jolsa/perf.git
>    perf/fixes
>
> thanks,
> jirka
>
>
> Cc: Wang Nan <wangnan0@huawei.com>
> ---

Good functions, and thank you for fixing documentations.

You didn't cc patch 1 and 2 to me.

Tested-by: Wang Nan <wangnan0@huawei.com>


> Jiri Olsa (7):
>        tools lib subcmd: Add OPT_STRING_OPTARG_SET option
>        perf record: Make __record_options static
>        perf record: Fix --switch-output documentation and comment
>        perf record: Add struct switch_output
>        perf record: Change switch-output option to take optional argument
>        perf record: Add switch-output size option argument
>        perf record: Add switch-output time option argument
>
>   tools/lib/subcmd/parse-options.c         |   3 ++
>   tools/lib/subcmd/parse-options.h         |   5 ++++
>   tools/perf/Documentation/perf-record.txt |  13 +++++++--
>   tools/perf/builtin-record.c              | 134 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++----------
>   4 files changed, 139 insertions(+), 16 deletions(-)