Patch submission question [not in the FAQ]

Patch submission question [not in the FAQ]

[Gabriele Gorla]

Hello,
I have submitted a patch for the 3x-xxxx driver on
alpha several months ago to both the driver maintainer
and the linux-scsi mailing list.
I have read all the FAQ and I tried to stick to the
instructions to the letter.
However the patch has been completely ignored. No
reply, no comment, no flames, absolutely nothing...

the original email submission is at the end of the
email.

could anyone please explain what I am doing wrong?

thanks,
GG


[PATCH 2.6.22] 3w-xxxx: Fix bad unaligned accesses on
alpha SMP

disable packing of the TAG_TW_Device_Extension
structure to prevent kernel unaligned accesses when
accessing ioctl_wqueue.
Fixes smartmontools kernel panic on alpha SMP

Signed-off-by: Gabriele Gorla <gorlik@yahoo.com>
---


--- linux-2.6.22/drivers/scsi/3w-xxxx.h.orig
2007-09-01 17:49:22.000000000 -0700
+++ linux-2.6.22/drivers/scsi/3w-xxxx.h 2007-09-01
17:49:45.000000000 -0700
@@ -392,6 +392,8 @@ typedef struct TAG_TW_Passthru
        unsigned char padding[12];
 } TW_Passthru;
 
+#pragma pack()
+
 typedef struct TAG_TW_Device_Extension {
        u32                     base_addr;
        unsigned long
*alignment_virtual_address[TW_Q_LENGTH];
@@ -430,6 +432,4 @@ typedef struct
TAG_TW_Device_Extension {
        wait_queue_head_t       ioctl_wqueue;
 } TW_Device_Extension;
 
-#pragma pack()
-
 #endif /* _3W_XXXX_H */


      ____________________________________________________________________________________
Be a better friend, newshound, and 
know-it-all with Yahoo! Mobile.  Try it now.  http://mobile.yahoo.com/;_ylt=Ahu06i62sR8HDtDypao8Wcj9tAcJ 

Re: Patch submission question [not in the FAQ]

[WANG Cong]

On Wed, Dec 05, 2007 at 03:36:54AM -0800, Gabriele Gorla wrote:
>Hello,
>I have submitted a patch for the 3x-xxxx driver on
>alpha several months ago to both the driver maintainer
>and the linux-scsi mailing list.
>I have read all the FAQ and I tried to stick to the
>instructions to the letter.
>However the patch has been completely ignored. No
>reply, no comment, no flames, absolutely nothing...
>
>the original email submission is at the end of the
>email.
>
>could anyone please explain what I am doing wrong?
>
>thanks,
>GG
>
>
>[PATCH 2.6.22] 3w-xxxx: Fix bad unaligned accesses on
>alpha SMP
>
>disable packing of the TAG_TW_Device_Extension
>structure to prevent kernel unaligned accesses when
>accessing ioctl_wqueue.
>Fixes smartmontools kernel panic on alpha SMP
>
>Signed-off-by: Gabriele Gorla <gorlik@yahoo.com>
>---
>
>
>--- linux-2.6.22/drivers/scsi/3w-xxxx.h.orig
>2007-09-01 17:49:22.000000000 -0700
>+++ linux-2.6.22/drivers/scsi/3w-xxxx.h 2007-09-01
>17:49:45.000000000 -0700

It seems that your email client wraps lines.
Please don't do this when you submit patches.


>@@ -392,6 +392,8 @@ typedef struct TAG_TW_Passthru
>        unsigned char padding[12];
> } TW_Passthru;

And also your email clients eats tabs.

Read Documentation/SubmittingPatches, please.
And read Documentation/email-clients.txt to learn more.

Regards.


 Cong

Re: Patch submission question [not in the FAQ]

[Jan Engelhardt]

On Dec 5 2007 03:36, Gabriele Gorla wrote:
>@@ -392,6 +392,8 @@ typedef struct TAG_TW_Passthru
>        unsigned char padding[12];
> } TW_Passthru;
> 
>+#pragma pack()
>+
> typedef struct TAG_TW_Device_Extension {
>        u32                     base_addr;
>        unsigned long
>*alignment_virtual_address[TW_Q_LENGTH];
>@@ -430,6 +432,4 @@ typedef struct
>TAG_TW_Device_Extension {
>        wait_queue_head_t       ioctl_wqueue;
> } TW_Device_Extension;
> 
>-#pragma pack()
>-

Hmpf. Can't you __attribute__((packed))-ify the structs rather
than use #pragma?

Re: Patch submission question [not in the FAQ]

[adam radford]

On Dec 5, 2007 3:36 AM, Gabriele Gorla <gorlik@yahoo.com> wrote:
> Hello,
> I have submitted a patch for the 3x-xxxx driver on
> alpha several months ago to both the driver maintainer
> and the linux-scsi mailing list.
> I have read all the FAQ and I tried to stick to the
> instructions to the letter.
> However the patch has been completely ignored. No
> reply, no comment, no flames, absolutely nothing...
>
> the original email submission is at the end of the
> email.
>
> could anyone please explain what I am doing wrong?
>
> thanks,
> GG

Gabriele,

I ignored your patch because:

1. I do not believe you have the 3w-xxxx driver running on an
   alpha SMP system.

2. I removed the bitfields from the 3w-xxxx driver but I have
   yet to add full big endian support due to lack of demand.  I have
   such a patch for this driver (which already includes the unpacking
   of the wait_queue_head_t variable) but I have not submitted it to
   the main-line kernel.  The in-kernel 3w-xxxx driver is still missing
   the byte-swaps.

   The 3w-9xxx (9000 series 3ware driver) has full big endian support.

3. Your patch was garbled.

Is this an official request for big endian support for the 3w-xxxx driver or
are you looking for anybody who has a packed 'wait_queue_head_t' and
submitting a patch to fix it?

-Adam

Re: Patch submission question [not in the FAQ]

[Geert Uytterhoeven]

On Thu, 6 Dec 2007, adam radford wrote:
> 2. I removed the bitfields from the 3w-xxxx driver but I have
>    yet to add full big endian support due to lack of demand.  I have
>    such a patch for this driver (which already includes the unpacking
>    of the wait_queue_head_t variable) but I have not submitted it to
>    the main-line kernel.  The in-kernel 3w-xxxx driver is still missing
>    the byte-swaps.
> 
>    The 3w-9xxx (9000 series 3ware driver) has full big endian support.
> 
> Is this an official request for big endian support for the 3w-xxxx driver or
> are you looking for anybody who has a packed 'wait_queue_head_t' and
> submitting a patch to fix it?

Alpha is little endian.

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds