From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6B0E5C2D0FD for ; Wed, 13 May 2020 06:31:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4AEFF20708 for ; Wed, 13 May 2020 06:31:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="ZSVlgXkk" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731970AbgEMGbh (ORCPT ); Wed, 13 May 2020 02:31:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46596 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732396AbgEMGbd (ORCPT ); Wed, 13 May 2020 02:31:33 -0400 Received: from mail-pj1-x1043.google.com (mail-pj1-x1043.google.com [IPv6:2607:f8b0:4864:20::1043]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D5910C061A0E for ; Tue, 12 May 2020 23:31:32 -0700 (PDT) Received: by mail-pj1-x1043.google.com with SMTP id mq3so10669871pjb.1 for ; Tue, 12 May 2020 23:31:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=2csGsD+au94C9xmTiACbfUOMQ7XhAMYTWeJo+alYFFI=; b=ZSVlgXkkpJtSfN7qkaqSe1HuEAcdJz+206DgqQ9a8bBTg1j86M/AV1JMXsfvt6a2jG yj/qedw70QPli6gaJfIS7IWASeacoIDxNbSyu9WdaQPEBjWsWQcEo5g5MJrVhANXE2rX 0zouj2RZsoJ6qnQ2ByQjeFr7YxZ7NE5uAypGs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=2csGsD+au94C9xmTiACbfUOMQ7XhAMYTWeJo+alYFFI=; b=YYXEwDAViHHlP8fMNUpSU6oQCV5EV+EtbDOkGMjJC3ztrIfCtox57UbfVlAmpgcCjK x2lsHZAuYof6JO+btIRtmfp2T1khNbJ7bN2PSloANyT2PvnUofPvImA91SKr2jQvuWfj F0xTWca5OZE0eR9lop1Ha+PmVSA/9UK1St9veFYJJgU4wfj9Q2d5hj/HmZsYDctmpGsB 7OjjcmWMfACyGlAi74RMvPV3GJGUjFXDPpeWBX2iJaGX3sHv4YLtbUPMFm5Mtm/4/cZw atQL4hsXsnG7h0xIOUoyaZ5lOOxft1wNCdXWdHlzv0mMqakzj/QvleEw6+UxPZJyaleJ helg== X-Gm-Message-State: AOAM530slZ6d1jd/8sSxNX1WclKvCwEUMDbCYm4XaC1axSa5jKVbwI6E 2+BCHGYOybt8jR3PWQyQltpMZA== X-Google-Smtp-Source: ABdhPJzun7l0BGdVwIAv5LpJTCZ51XWx8WkOrhjqdl2WVdRNTqaM1ew0r90ShpQV04nRKtPQ735vBg== X-Received: by 2002:a17:902:8505:: with SMTP id bj5mr7220884plb.192.1589351492246; Tue, 12 May 2020 23:31:32 -0700 (PDT) Received: from [10.136.13.65] ([192.19.228.250]) by smtp.gmail.com with ESMTPSA id c1sm13716735pfo.152.2020.05.12.23.31.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 12 May 2020 23:31:31 -0700 (PDT) Subject: Re: [PATCH v5 6/7] misc: bcm-vk: add Broadcom VK driver To: Luis Chamberlain Cc: Greg Kroah-Hartman , David Brown , Alexander Viro , Shuah Khan , bjorn.andersson@linaro.org, Shuah Khan , Arnd Bergmann , "Rafael J . Wysocki" , linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-fsdevel@vger.kernel.org, BCM Kernel Feedback , Olof Johansson , Andrew Morton , Dan Carpenter , Colin Ian King , Kees Cook , Takashi Iwai , linux-kselftest@vger.kernel.org, Andy Gross , Desmond Yan , James Hu References: <20200508002739.19360-1-scott.branden@broadcom.com> <20200508002739.19360-7-scott.branden@broadcom.com> <20200513003830.GJ11244@42.do-not-panic.com> From: Scott Branden Message-ID: <60372b2f-c03d-6384-43a7-8b97413b6672@broadcom.com> Date: Tue, 12 May 2020 23:31:28 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <20200513003830.GJ11244@42.do-not-panic.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Luis, On 2020-05-12 5:38 p.m., Luis Chamberlain wrote: > On Thu, May 07, 2020 at 05:27:38PM -0700, Scott Branden wrote: >> +#if defined(CONFIG_REQ_FW_INTO_BUF_PRIV) >> + >> +#define KERNEL_PREAD_FLAG_PART 0x0001 /* Allow reading part of file */ >> +#define REQUEST_FIRMWARE_INTO_BUF request_firmware_into_buf_priv >> +int request_firmware_into_buf_priv(const struct firmware **firmware_p, >> + const char *name, struct device *device, >> + void *buf, size_t size, >> + size_t offset, unsigned int pread_flags); >> + >> +#else >> + >> +#define REQUEST_FIRMWARE_INTO_BUF request_firmware_into_buf >> + >> +#endif >> + >> +#endif > Please clean this up, the code must reflect only the code upstream. No > config stuff like this should be used on the driver. I had to stop my > review here. The CONFIG_ prefix shouldn't have been there as there is no Kconfig option to select this. Would like to just change it to a normal define without CONFIG_ prefix instead? This code is here to allow a limited version of the driver to run on older kernels which do not have the necessary partial file read support. By having it in the upstream codebase we don't need to maintain an internal version of the driver.  User can take the upstream kernel module and compile it against an old version of the kernel by via the define. > Luis Regards, Scott