From: Krzysztof Kozlowski <firstname.lastname@example.org> To: Luca Weiss <email@example.com>, firstname.lastname@example.org Cc: ~email@example.com, firstname.lastname@example.org, Dmitry Torokhov <email@example.com>, Rob Herring <firstname.lastname@example.org>, Krzysztof Kozlowski <email@example.com>, firstname.lastname@example.org, email@example.com Subject: Re: [PATCH 1/3] dt-bindings: input: Add bindings for Awinic AW8695 haptics Date: Mon, 11 Apr 2022 14:52:26 +0200 [thread overview] Message-ID: <firstname.lastname@example.org> (raw) In-Reply-To: <CJ79EIW9Z89J.YZTZ6AU91TGE@otso> On 11/04/2022 10:15, Luca Weiss wrote: (...) >>> + awinic,f0-detection-play-time: >>> + $ref: /schemas/types.yaml#/definitions/uint32 >>> + description: Drive waveform play times in the first period in the f0 detection >> >> Use standard unit suffixes for known units (e.g. time). > > While the datasheet doesn't mention any time unit, the value is used to > calculate the f0_trace_ms variable (which is milliseconds) but the > result also depends on the awinic,f0-preset value, so it's not a raw > time value. I see, ok. > >> >>> + >>> + awinic,f0-detection-wait-time: >>> + $ref: /schemas/types.yaml#/definitions/uint32 >>> + description: Waveform wait times in the f0 detection >> >> Ditto. >> >>> + >>> + awinic,f0-detection-repeat: >>> + $ref: /schemas/types.yaml#/definitions/uint32 >>> + description: Repeat times in the f0 detection >>> + >>> + awinic,f0-detection-trace: >>> + $ref: /schemas/types.yaml#/definitions/uint32 >>> + description: Drive waveform play times in the second period and later in the f0 detection >>> + >>> + awinic,boost-debug: >>> + $ref: /schemas/types.yaml#/definitions/uint8-array >>> + minItems: 3 >>> + maxItems: 3 >>> + description: Values for BSTDBG1-3 registers >> >> Do not encode device programming model (registers) into the binding. You >> need to define it as a property related to hardware itself, not its >> registers (e.g. boost value in mV). > > Unfortunately I couldn't figure the meaning for this and the two values > below. > > The datasheet doesn't mention these registers at all and the downstream > driver doesn't do anything meaningful with them (other than setting them) > nor has any comment to indicate what they do. > In the datasheet there's only BSTDBG4 mentioned where bits [5:1] mean > PVDD output voltage setting so for these registers it could really be > anthing :( > > Maybe someone with more knowledge about LRAs might be able to decipher > what tset and r_spare is at least? I unfortunately didn't manage. Do you have to define them in such case in DT? Maybe it should be part of driver? Best regards, Krzysztof
next prev parent reply other threads:[~2022-04-11 12:52 UTC|newest] Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-04-08 11:53 Luca Weiss 2022-04-08 11:53 ` [PATCH 2/3] Input - aw8695: Add driver for " Luca Weiss 2022-04-08 17:25 ` kernel test robot 2022-04-09 21:15 ` Jeff LaBundy 2022-04-11 9:57 ` Luca Weiss 2022-04-12 2:44 ` Jeff LaBundy 2022-04-08 11:53 ` [PATCH 3/3] arm64: dts: qcom: sm7225-fairphone-fp4: Add " Luca Weiss 2022-04-08 19:49 ` kernel test robot 2022-04-08 15:05 ` [PATCH 1/3] dt-bindings: input: Add bindings for Awinic " Krzysztof Kozlowski 2022-04-11 8:15 ` Luca Weiss 2022-04-11 12:52 ` Krzysztof Kozlowski [this message] 2022-04-11 15:11 ` Luca Weiss
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --subject='Re: [PATCH 1/3] dt-bindings: input: Add bindings for Awinic AW8695 haptics' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).