From: "Vaittinen, Matti" <Matti.Vaittinen@fi.rohmeurope.com> To: unlisted-recipients:; (no To-header on input) Cc: "firstname.lastname@example.org" <email@example.com>, "firstname.lastname@example.org" <email@example.com>, "firstname.lastname@example.org" <email@example.com>, "firstname.lastname@example.org" <email@example.com> Subject: short-circuit and over-current IRQs Date: Wed, 27 Jan 2021 12:01:55 +0000 [thread overview] Message-ID: <firstname.lastname@example.org> (raw) Hi dee Ho peeps, I just noticed the 390af53e04114f790d60b63802a4de9d815ade03 ("regulator: qcom-labibb: Implement short-circuit and over-current IRQs") in regulator tree. No worries - I haven't hit any problem with it :] I've been working with ROHM BD9576MUF - which implements warning IRQs for over/under-voltage and high temperature. (Short-circuit detection does also generate IRQ but it also automatically shuts down the regulators by HW). BD9576MUF does also keep the IRQ activated for as long as the 'troubling condition' stays active in HW. This is why BD9576MUF driver does also need to implement some logic to disable IRQ for some time period just to keep CPU out of the IRQ loop. https://email@example.com/ My implementation lacks of the retry counter and regulator shut-down (BD9576 has also OCP - "Over Current Protection/OVP - "Over Voltage Protection"/TSD - "Thermal Shutdown" features so that HW will shut down outputs if things get worse so those are not so crucial). I've also had some hard time when trying to test this - I guess others have faced similar problems too... Anyways - I was wondering if this is common thing amongst many PMICs? If yes - then, perhaps some generally useful regulator helper could be added to help implementing the IRQ disabling + scheduling worker to check status and re-enable IRQs? I think it *might* save some time in the future - and help making same mistakes many times :] I *might* be able to find some time to draft out some code for this (not promising, I am currently having few patch series pending but I could at least try) - but I am not able to do thorough testing with BD9576... Any possibility to co-operate? Maybe we could try this also onqcom-labibb? Or do you think this is overall just a dead idea? Best Regards Matti Vaittinen
next reply other threads:[~2021-01-27 12:05 UTC|newest] Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-01-27 12:01 Vaittinen, Matti [this message] 2021-01-27 12:27 ` Mark Brown 2021-01-27 12:56 ` Matti Vaittinen 2021-01-27 14:34 ` AngeloGioacchino Del Regno 2021-01-27 14:42 ` Vaittinen, Matti 2021-01-27 16:32 ` Mark Brown 2021-01-28 9:23 ` Vaittinen, Matti 2021-01-28 12:10 ` Mark Brown 2021-01-28 12:49 ` Vaittinen, Matti [not found] ` <firstname.lastname@example.org> 2021-01-30 15:43 ` AngeloGioacchino Del Regno 2021-02-01 7:14 ` Matti Vaittinen 2021-02-01 13:17 ` Mark Brown
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --subject='Re: short-circuit and over-current IRQs' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).