From: "Chew, Chiau Ee" <chiau.ee.chew@intel.com>
To: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Cc: Thierry Reding <thierry.reding@gmail.com>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
Alan Cox <alan@linux.intel.com>,
"linux-pwm@vger.kernel.org" <linux-pwm@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] pwm: lpss: remove dependency on clk framework
Date: Wed, 14 May 2014 08:54:51 +0000 [thread overview]
Message-ID: <604BF5F4C5D71041942BC7E84ED659EA0B004E18@PGSMSX108.gar.corp.intel.com> (raw)
In-Reply-To: <20140514083929.GA12238@xps8300>
>
> Hi,
>
> On Wed, May 14, 2014 at 07:00:59AM +0000, Chew, Chiau Ee wrote:
> > Heikki,
> > For ACPI mode, the clock rate information for PWM is being setup in the
> acpi_lpss.c layer.
> > Thus, only PCI mode depends on the driver_data to pass in the clock rate
> information.
>
> The goal with this patch is actually to free acpi_lpss.c from delivering the clock
> for this driver.
>
> The LPSS PWM does not get it's clock from the LPSS 100Mhz source clock,
> which means we have to have the rate of it's clock hard-coded.
> Since it's already hard coded also in this driver for PCI mode in any case, it
> makes no sense to also have it there.
>
> So this patch will allow us to cleanup acpi_lpss.c. We can now remove the
> confusing "shared clock" structure where the hard coded rates are held. This
> device is the only one that would need it.
>
Oh ya...you are right. Sorry about that. I have mixed up the context with other I/O components.
Reviewed-by: Chew, Chiau Ee <chiau.ee.chew@intel.com>
>
> Thanks,
>
> --
> heikki
next prev parent reply other threads:[~2014-05-14 8:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-09 8:35 [PATCH] pwm: lpss: remove dependency on clk framework Heikki Krogerus
2014-05-12 7:09 ` Mika Westerberg
2014-05-14 7:00 ` Chew, Chiau Ee
2014-05-14 8:39 ` Heikki Krogerus
2014-05-14 8:54 ` Chew, Chiau Ee [this message]
2014-08-07 11:19 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=604BF5F4C5D71041942BC7E84ED659EA0B004E18@PGSMSX108.gar.corp.intel.com \
--to=chiau.ee.chew@intel.com \
--cc=alan@linux.intel.com \
--cc=heikki.krogerus@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).