From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D82CAC433FE for ; Wed, 11 May 2022 04:57:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234139AbiEKE5X (ORCPT ); Wed, 11 May 2022 00:57:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42016 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229464AbiEKE5U (ORCPT ); Wed, 11 May 2022 00:57:20 -0400 Received: from lelv0143.ext.ti.com (lelv0143.ext.ti.com [198.47.23.248]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5BA3EBA981; Tue, 10 May 2022 21:57:17 -0700 (PDT) Received: from fllv0034.itg.ti.com ([10.64.40.246]) by lelv0143.ext.ti.com (8.15.2/8.15.2) with ESMTP id 24B4v8MD009060; Tue, 10 May 2022 23:57:08 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1652245028; bh=nTz7YT0yRqP5kLgxJz0n83SBM4tCZh4oJr4tKzF560c=; h=Date:Subject:To:CC:References:From:In-Reply-To; b=Prioy0KvgkySR8MuJXpUWhWdXwff8EzSci6WKuhIVkun72tmhLVL5ZgvO59qepVVV PMgv6zLrdirZvFcetVI372ORxY9p4vhwzyrcxpqZ9znLKd4hS6b+pDZesMS+1k8HNZ Y/SepBW3GWN/pswogDyK+UyJ7ehR8t6GCTIjYzvE= Received: from DFLE104.ent.ti.com (dfle104.ent.ti.com [10.64.6.25]) by fllv0034.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 24B4v8rJ108735 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 10 May 2022 23:57:08 -0500 Received: from DFLE114.ent.ti.com (10.64.6.35) by DFLE104.ent.ti.com (10.64.6.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.14; Tue, 10 May 2022 23:57:08 -0500 Received: from lelv0327.itg.ti.com (10.180.67.183) by DFLE114.ent.ti.com (10.64.6.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.14 via Frontend Transport; Tue, 10 May 2022 23:57:08 -0500 Received: from [172.24.145.176] (ileax41-snat.itg.ti.com [10.172.224.153]) by lelv0327.itg.ti.com (8.15.2/8.15.2) with ESMTP id 24B4v4bK026680; Tue, 10 May 2022 23:57:05 -0500 Message-ID: <6054e7e6-928e-1378-fed5-587fd7fe3442@ti.com> Date: Wed, 11 May 2022 10:27:04 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH v6 4/4] thermal: k3_j72xx_bandgap: Add the bandgap driver support Content-Language: en-US To: "J, KEERTHY" , Daniel Lezcano , , , , , CC: , , References: <20220427064635.24898-1-j-keerthy@ti.com> <20220427064635.24898-5-j-keerthy@ti.com> <78a3cc4d-8ce4-0dae-2f4e-7522a0a3aa0b@ti.com> From: Vignesh Raghavendra In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/05/22 22:47, J, KEERTHY wrote: > > > On 5/10/2022 8:55 PM, Daniel Lezcano wrote: >> On 09/05/2022 05:10, J, KEERTHY wrote: >>> >>> >>> On 4/27/2022 12:16 PM, Keerthy wrote: >>>> Add VTM thermal support. In the Voltage Thermal Management >>>> Module(VTM), K3 J72XX supplies a voltage reference and a temperature >>>> sensor feature that are gathered in the band gap voltage and >>>> temperature sensor (VBGAPTS) module. The band gap provides current and >>>> voltage reference for its internal circuits and other analog IP >>>> blocks. The analog-to-digital converter (ADC) produces an output value >>>> that is proportional to the silicon temperature. >>>> >>>> Currently reading temperatures only is supported.  There are no >>>> active/passive cooling agent supported. >>>> >>>> J721e SoCs have errata i2128: https://www.ti.com/lit/pdf/sprz455 >>>> >>>> The VTM Temperature Monitors (TEMPSENSORs) are trimmed during >>>> production, >>>> with the resulting values stored in software-readable registers. >>>> Software >>>> should use these  register values when translating the Temperature >>>> Monitor output codes to temperature values. >>>> >>>> It has an involved workaround. Software needs to read the error >>>> codes for >>>> -40C, 30C, 125C from the efuse for each device & derive a new look >>>> up table >>>> for adc to temperature conversion. Involved calculating slopes & >>>> constants >>>> using 3 different straight line equations with adc refernce codes as >>>> the >>>> y-axis & error codes in the x-axis. >>>> >>>> -40C to 30C >>>> 30C to 125C >>>> 125C to 150C >>>> >>>> With the above 2 line equations we derive the full look-up table to >>>> workaround the errata i2128 for j721e SoC. >>> >>> Hi Daniel, >>> >>> Any feedback on this series? Let me know. >> >> There are a few but that would be nit picking and I don't want to >> postpone this driver any longer. >> >> How do you want to proceed? Shall I take it through my tree? > > Hi Daniel, > > Patch 1 & 4 i.e Documentation patch and driver patch can be picked by > you. I believe Vignesh will take the dts patches. > > Vignesh, > > Can you confirm? > Yes, please decouple DT patches from driver+binding patches as they are to be applied to different trees. -- Regards Vignesh