From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE3A8EB64D7 for ; Tue, 13 Jun 2023 21:37:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232345AbjFMVh2 (ORCPT ); Tue, 13 Jun 2023 17:37:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41864 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229947AbjFMVhY (ORCPT ); Tue, 13 Jun 2023 17:37:24 -0400 Received: from mail-ej1-x632.google.com (mail-ej1-x632.google.com [IPv6:2a00:1450:4864:20::632]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 77E401BF5 for ; Tue, 13 Jun 2023 14:37:19 -0700 (PDT) Received: by mail-ej1-x632.google.com with SMTP id a640c23a62f3a-977c89c47bdso4261866b.2 for ; Tue, 13 Jun 2023 14:37:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1686692238; x=1689284238; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=oip7SqC/cNKZpwuyshsaw2zREje6DYUcsApGrxnqSjc=; b=i1xbrWeSBBDDeChk2v1jFQ8oNrFfLHyhMK5pCcLQkja3OqbHo2bJ/wFHW7uutFX9XZ i6B51pldX5oeo7lYYaDlHiTKsm3/u5OCvL6YNOnA4lmfBx8a7VyTS7N9SzxKcGs57wnC 8mxdIiwnNcJ2FlyXtMEyA/0/wBdPgaVhyqfO45QxRPAoBTT+nQbHDzy9uF69dhqIcI2W YetKdFtdwJTU5y2CCz1KyLhQgYgzrxUF9Vky5XdyrtXP992Uz8lCG4PAr11dJpPmNO6b Re0941tRW3KeLKZgV89XErY04JlNHWHSMzNtAWQ7qXUP/V8UU59V4mLSIl8GHpkHDOxN yVuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686692238; x=1689284238; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=oip7SqC/cNKZpwuyshsaw2zREje6DYUcsApGrxnqSjc=; b=deK0oNnLqCp48ddfW5CBef6tzTnFr5Db3mk7LJGPF5yHn08n7Wrq6m81T0ve44eZ4O wFHzsPWH7c5qaNfUechyGiX6OdwXjwsRZevbUNEEf3z36wAUrXUBR4mDMUaeiqZ6smhz 5j/u4RBArlglJB5Rc/232uEByUQZGqx0Ynl+LcG/vmEsHoU3lc2XFT/lg+9mWEb1uxV9 0pV4OHM6ixPxdWpxrJKmqDH76U00EXqMmQ3MNfbVHPrqAYd41JuwwKZbQA16pHdouW/N bZvlJ+UKIQy33LeKhdhS4QiUMDyOHNoYpKDLY/D8A7+KaU3ga2OzVa//xUl3DC0GfeSk fbwA== X-Gm-Message-State: AC+VfDz1O1zi2uExNsBQVkJHiIwpv+EJG5MFsvBxFgZGokj99pcMbIaI M8652bRidYLdj63tFEENZlqz7A== X-Google-Smtp-Source: ACHHUZ6a2hnnxxgRqbHde0/z6M1zAJKLjWqTWlBx8ZNIxyQ4NWlh0GA2OLSUJCuN3o03XaigIgk1JA== X-Received: by 2002:a17:906:ef03:b0:977:d676:d3ca with SMTP id f3-20020a170906ef0300b00977d676d3camr16308640ejs.33.1686692237898; Tue, 13 Jun 2023 14:37:17 -0700 (PDT) Received: from [192.168.1.20] ([178.197.219.26]) by smtp.gmail.com with ESMTPSA id gu4-20020a170906f28400b0096fbc516a93sm7107806ejb.211.2023.06.13.14.37.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 13 Jun 2023 14:37:17 -0700 (PDT) Message-ID: <605616cd-d0f9-a430-7cf2-b2f36d07ffe3@linaro.org> Date: Tue, 13 Jun 2023 23:37:15 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH v2 3/8] dt-bindings: rtc: isl12022: add bindings for battery alarm trip levels Content-Language: en-US To: Rasmus Villemoes , Alessandro Zummo , Alexandre Belloni Cc: Andy Shevchenko , devicetree@vger.kernel.org, Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230612113059.247275-1-linux@rasmusvillemoes.dk> <20230613130011.305589-1-linux@rasmusvillemoes.dk> <20230613130011.305589-4-linux@rasmusvillemoes.dk> <0600a505-d1bf-f4be-57ef-51d34c77501e@linaro.org> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 13/06/2023 21:51, Rasmus Villemoes wrote: >>> diff --git a/Documentation/devicetree/bindings/rtc/intersil,isl12022.yaml b/Documentation/devicetree/bindings/rtc/intersil,isl12022.yaml >>> index 7c1e638d657a..d5d3a687a34d 100644 >>> --- a/Documentation/devicetree/bindings/rtc/intersil,isl12022.yaml >>> +++ b/Documentation/devicetree/bindings/rtc/intersil,isl12022.yaml >>> @@ -22,6 +22,18 @@ properties: >>> interrupts: >>> maxItems: 1 >>> >>> + isil,trip-level85-microvolt: >> >> Why encoding level85 in the property name? Your commit msg (datasheet) >> suggests this is quite flexible, so why it cannot be just list of two >> trip levels - for first and second interrupt? > > Yeah, so I did consider just making it a two-element array > isil,trip-levels-microvolt. But then I didn't know how to express the > enum constraint, i.e. that the first must be one of the 2125000, ..., > 4675000 values and the second one of the 1875000, ..., 4125000 ones. Is > that possible, without providing a list of 49 possible pairs? Or is it > sufficient to just write this out in prose? items: - enum: [ a, b, c ] - enum: [ f, d, e ] Best regards, Krzysztof