From: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
To: Ping-Ke Shih <pkshih@realtek.com>,
Kalle Valo <kvalo@codeaurora.org>,
"David S. Miller" <davem@davemloft.net>,
Larry Finger <Larry.Finger@lwfinger.net>
Cc: linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, Kees Cook <keescook@chromium.org>
Subject: Re: [PATCH v2 wireless-drivers-next] rtlwifi: rtl8723ae: Fix missing break in switch statement
Date: Wed, 24 Apr 2019 17:17:12 -0500 [thread overview]
Message-ID: <6056eaca-5120-ec0f-6e72-2e1bfbde52a9@embeddedor.com> (raw)
In-Reply-To: <20190416151722.GA31598@embeddedor>
Hi all,
Friendly ping:
Who can take this?
Thanks
--
Gustavo
On 4/16/19 10:17 AM, Gustavo A. R. Silva wrote:
> Add missing break statement in order to prevent the code from falling
> through to case 0x1025, and erroneously setting rtlhal->oem_id to
> RT_CID_819X_ACER when rtlefuse->eeprom_svid is equal to 0x10EC and
> none of the cases in switch (rtlefuse->eeprom_smid) match.
>
> This bug was found thanks to the ongoing efforts to enable
> -Wimplicit-fallthrough.
>
> Fixes: 238ad2ddf34b ("rtlwifi: rtl8723ae: Clean up the hardware info routine")
> Cc: stable@vger.kernel.org
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
> ---
> Changes in v2:
> - Update tag from wireless-drivers to wireless-drivers-next
>
> drivers/net/wireless/realtek/rtlwifi/rtl8723ae/hw.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/hw.c b/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/hw.c
> index 6bab162e1bb8..655460f61bbc 100644
> --- a/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/hw.c
> +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/hw.c
> @@ -1675,6 +1675,7 @@ static void _rtl8723e_read_adapter_info(struct ieee80211_hw *hw,
> rtlhal->oem_id = RT_CID_819X_LENOVO;
> break;
> }
> + break;
> case 0x1025:
> rtlhal->oem_id = RT_CID_819X_ACER;
> break;
>
next prev parent reply other threads:[~2019-04-24 22:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-16 15:17 [PATCH v2 wireless-drivers-next] rtlwifi: rtl8723ae: Fix missing break in switch statement Gustavo A. R. Silva
2019-04-24 22:17 ` Gustavo A. R. Silva [this message]
2019-04-25 9:37 ` Kalle Valo
2019-04-25 14:27 ` Gustavo A. R. Silva
2019-04-25 16:56 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6056eaca-5120-ec0f-6e72-2e1bfbde52a9@embeddedor.com \
--to=gustavo@embeddedor.com \
--cc=Larry.Finger@lwfinger.net \
--cc=davem@davemloft.net \
--cc=keescook@chromium.org \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pkshih@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).