From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F486C433E9 for ; Fri, 5 Mar 2021 11:26:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 33ADA6501E for ; Fri, 5 Mar 2021 11:26:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229591AbhCEL0G (ORCPT ); Fri, 5 Mar 2021 06:26:06 -0500 Received: from youngberry.canonical.com ([91.189.89.112]:51992 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229576AbhCELZm (ORCPT ); Fri, 5 Mar 2021 06:25:42 -0500 Received: from mail-wr1-f69.google.com ([209.85.221.69]) by youngberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1lI8aT-00036J-7f for linux-kernel@vger.kernel.org; Fri, 05 Mar 2021 11:25:41 +0000 Received: by mail-wr1-f69.google.com with SMTP id m9so931211wrx.6 for ; Fri, 05 Mar 2021 03:25:41 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=nj2PrFHb6kGq6ooWb10NVgoyTadWZycXGzOn28nDuhA=; b=jwJo13dtR8xjI3Mo+Onub5+1a09ddlVrPiX7W5etyPb2ZZK5VgIyXkH9mG49RrFtAN Zlw0D7t04n6kdR/X1JbVjzewfMulwF5NIXMVHfze1fTJee3h+YM19kDhEHmaBiKmM0Sx u6DSr1DPZr3GmnlgxbB0kF9INio4gWdZ3D3EuDGXNiFuDNOLmmM4WhnmfwBMfKDMwyVd /kGdPqVxmvfTCB7S/Z05BcSB9X1n2wQdQN6Ec5r19St9vB0oS79Jp5u2s8/RQ181efY3 C4p64wqLrtuOZRMYWFaPTZ4DA0oEXbVehHhB99Xn+y+C/cI8J+/hWAJ/Xw2rwhvg5EX7 Wkcg== X-Gm-Message-State: AOAM530aZGTwT5yNmuO7i8vaPZuRMZy1xiomOsD2yjIIrQrn3f1jD5u0 9CLrZDNPu7Lau4mbTl56i7dqNkVSXfuZHj3CWip/uRfwYffRAtkO4fUC35z64Nw1a1ntAH4aj7U /0DcLzsijr6OlNtGJsYLlLrXUtVEoqiX4CzSg+lyIvg== X-Received: by 2002:a1c:2e56:: with SMTP id u83mr2579091wmu.122.1614943540840; Fri, 05 Mar 2021 03:25:40 -0800 (PST) X-Google-Smtp-Source: ABdhPJzJkdDADi29npR5jm6uaXHLDmTZ2JOEJEIdQVKiI0LHTOo9fZorrcqw7Wzeekw0PSc44FlBMw== X-Received: by 2002:a1c:2e56:: with SMTP id u83mr2579081wmu.122.1614943540739; Fri, 05 Mar 2021 03:25:40 -0800 (PST) Received: from [192.168.1.116] (adsl-84-226-167-205.adslplus.ch. [84.226.167.205]) by smtp.gmail.com with ESMTPSA id u4sm4256737wrm.24.2021.03.05.03.25.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 05 Mar 2021 03:25:40 -0800 (PST) Subject: Re: [PATCH 1/8] gpio: Add Elba SoC gpio driver for spi cs control To: Brad Larson , linux-arm-kernel@lists.infradead.org Cc: arnd@arndb.de, linus.walleij@linaro.org, bgolaszewski@baylibre.com, broonie@kernel.org, fancer.lancer@gmail.com, adrian.hunter@intel.com, ulf.hansson@linaro.org, olof@lixom.net, linux-gpio@vger.kernel.org, linux-spi@vger.kernel.org, linux-mmc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20210304034141.7062-1-brad@pensando.io> <20210304034141.7062-2-brad@pensando.io> From: Krzysztof Kozlowski Message-ID: <605880ad-6c12-bf1d-45f8-ef70181e4eec@canonical.com> Date: Fri, 5 Mar 2021 12:25:39 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <20210304034141.7062-2-brad@pensando.io> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/03/2021 04:41, Brad Larson wrote: > This GPIO driver is for the Pensando Elba SoC which > provides control of four chip selects on two SPI busses. > > Signed-off-by: Brad Larson > --- > drivers/gpio/Kconfig | 6 ++ > drivers/gpio/Makefile | 1 + > drivers/gpio/gpio-elba-spics.c | 120 +++++++++++++++++++++++++++++++++ > 3 files changed, 127 insertions(+) > create mode 100644 drivers/gpio/gpio-elba-spics.c (...) > +static int elba_spics_probe(struct platform_device *pdev) > +{ > + struct elba_spics_priv *p; > + struct resource *res; > + int ret; > + > + p = devm_kzalloc(&pdev->dev, sizeof(*p), GFP_KERNEL); > + if (!p) > + return -ENOMEM; > + > + res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > + p->base = devm_ioremap_resource(&pdev->dev, res); > + if (IS_ERR(p->base)) { > + dev_err(&pdev->dev, "failed to remap I/O memory\n"); > + return PTR_ERR(p->base); > + } > + spin_lock_init(&p->lock); > + platform_set_drvdata(pdev, p); > + > + p->chip.ngpio = 4; /* 2 cs pins for spi0, and 2 for spi1 */ > + p->chip.base = -1; > + p->chip.direction_input = elba_spics_direction_input; > + p->chip.direction_output = elba_spics_direction_output; > + p->chip.get = elba_spics_get_value; > + p->chip.set = elba_spics_set_value; > + p->chip.label = dev_name(&pdev->dev); > + p->chip.parent = &pdev->dev; > + p->chip.owner = THIS_MODULE; > + > + ret = devm_gpiochip_add_data(&pdev->dev, &p->chip, p); > + if (ret) { > + dev_err(&pdev->dev, "unable to add gpio chip\n"); > + return ret; > + } > + > + dev_info(&pdev->dev, "elba spics registered\n"); Don't print trivial probe results, unless you print here something useful. If you need it for debugging, keep it dev_dbg. Best regards, Krzysztof