From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1756646AbcE0VhK (ORCPT <rfc822;w@1wt.eu>);
	Fri, 27 May 2016 17:37:10 -0400
Received: from mout.kundenserver.de ([212.227.17.24]:57598 "EHLO
	mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1755997AbcE0VhH (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 27 May 2016 17:37:07 -0400
From: Arnd Bergmann <arnd@arndb.de>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Michal Marek <mmarek@suse.com>,
        =?utf-8?B?0JzQsNC60YEg0JbRg9C60L7Qsg==?= 
	<mussitantesmortem@gmail.com>,
        nicolas.ferre@atmel.com, Nicolas Pitre <nicolas.pitre@linaro.org>,
        robert.jarzmik@free.fr, yamada.masahiro@socionext.com,
        Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Bob Peterson <rpeterso@redhat.com>,
        Andrzej Hajda <a.hajda@samsung.com>
Subject: Re: [GIT PULL] kbuild updates for v4.7-rc1
Date: Fri, 27 May 2016 23:36:51 +0200
Message-ID: <6059647.tYvRSTXOxn@wuerfel>
User-Agent: KMail/5.1.3 (Linux/4.4.0-22-generic; KDE/5.18.0; x86_64; ; )
In-Reply-To: <CA+55aFzQ4oe6cT5xf=3xT1d6ji2L_her8AmJxpsixFw_GavDvg@mail.gmail.com>
References: <20160526203346.GA4734@pobox.suse.cz> <9633365.kM71HHzq9d@wuerfel> <CA+55aFzQ4oe6cT5xf=3xT1d6ji2L_her8AmJxpsixFw_GavDvg@mail.gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
X-Provags-ID: V03:K0:P97mOuMOrIHT+dxQAAv++ow1pBOS99Rc8WODw5QQUfICKWl49tK
 xbLyzaO8mtRVkJVl28MPmBCty8wFUaOy2FA4lNK0lklO7W+Hx+PQ52RRLAvMKimSUIuNcUB
 AJJLnlHexu7INo65xHZarIrE+5yZsLYK/mHFvrRGBNJHwAIb+bmiP372ApctwirqUN8T5U2
 jenTztqRn37MnH77MIjJA==
X-UI-Out-Filterresults: notjunk:1;V01:K0:2glabNIgNpU=:xvqpc1HQ23vd+qU+n3V23Q
 jSi7tvkzhPhlQgdlBN/bnU+1phCHdfoms+utT+2r8qF2AdW05jEtr4A7ijEg4dq7wWLIWCLHI
 yeR6wHhQkcjcguAORzIzb3mtBrAHqQHqWgWcSsOg2sv7QBsmr7TohqFJ2PucpT3hxyzmv1NMy
 GpckAumK0rb2bRvq/+iaa+NmiORdo7YfLyqEDrf7lfuIEKkCLQT/MkIMk6XJ4XSqbsz37qBWH
 Na2OIrmwRYbxLdxEGCg9mQ6eI+YY55cFHU5J6XFttFAaCxDr4Ili9rNn5ONz9XzJTdQhioig9
 KEKQa5lxarXxIIxxbG45dH2VRAhrW/P7URPSDKhu4OGaZpjvJ2iJXDi3CkCGjiY9ycXsdSEIw
 RpEFGbc0s4MDr14u7L9dmcRM5JmAET7qwHNem187HgII1IX3dV7dXzUJxQBzoKhJwfsD1536J
 ueeMSHXD5fk0Ms19JxqC0LyGX03QKPb9Sz4nVAXo5KF+3rQFpzPk19hIkdxp44YmkWBDmZfqo
 rlqyXBGTSJhIIGdz19JgyMwAyLnfryXK1powAUyZ+0a7p4ZqrSjG2RFvTxcnbD2i/LbRCft+3
 51A1A0G14lsHmmqOoR4zwz858Jlgppc/yJg2Sd77/XFsOouQZxeSj+05HlA/3fSI1lbnr5cGh
 AOCotoei9Gac2qpZi8IMGkipOPQb5+tyrvySw1R4xYFB5OtfUEiVj0ZmczafCakMTdx+0Ohd4
 3L2NrjZl5O9u9MdJ
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Friday, May 27, 2016 1:20:29 PM CEST Linus Torvalds wrote:
> On Fri, May 27, 2016 at 1:04 PM, Arnd Bergmann <arnd@arndb.de> wrote:
> >
> > In fact, the patch that I have in my private tree that was hiding the
> > warning for me on x86 is one that removes all instances of IS_ERR_VALUE()
> > with arguments other than 'unsigned long', see http://pastebin.com/uYa2mkgC
> > for reference.
> 
> Please just send me that patch, we need to do this (and then add a
> cast to pointer (and back to unsigned long) in IS_ERR_VALUE() so that
> we get warnings for when that macro is mis-used.

Ok, I've tried to come up with a summary of what happened so far
on this, and sent the patch your way, leaving out the modified
IS_ERR_VALUE() definition for the moment.

I've added the people on Cc whose drivers had the most invasive
changes.

> I didn't look at the details of your patch, but I did look at several
> IS_ERR_VALUE() uses in the standard kernel, and they were basically
> all wrong.

Yes, that matches what we found earlier this year when Andrzej Hajda
did some work on fixing the worst problems he found.

	Arnd