From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E34DFC282C3 for ; Thu, 24 Jan 2019 06:25:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B631A2184C for ; Thu, 24 Jan 2019 06:25:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726151AbfAXGZu convert rfc822-to-8bit (ORCPT ); Thu, 24 Jan 2019 01:25:50 -0500 Received: from youngberry.canonical.com ([91.189.89.112]:44941 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725287AbfAXGZu (ORCPT ); Thu, 24 Jan 2019 01:25:50 -0500 Received: from mail-pg1-f199.google.com ([209.85.215.199]) by youngberry.canonical.com with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.76) (envelope-from ) id 1gmYSS-0000sw-Of for linux-kernel@vger.kernel.org; Thu, 24 Jan 2019 06:25:48 +0000 Received: by mail-pg1-f199.google.com with SMTP id a18so3249306pga.16 for ; Wed, 23 Jan 2019 22:25:48 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=bFP8/UfMkiYNP2p4MVjWtswpJ0bCC+aw29EzWe/4b98=; b=VFIisnG3PLmWY+wtm0ACtfxQvVf3co03ugdgLMxs/dyj0Bz3rXMAPZ86fc0FxCffgO YQsOPQr8UHLGkQLPoHpyKxAl4/QEfBBB95n2dnVUcxiIR/SXouDEXciKZbP3N+7C8BCu Bns7ZUHesQ1AXcObG71UvWW6COD/Lu3C7TY/cAsx2avU/8n1DTNTJUCs8QtTl+dh7Ppj DAx7GkJBl/0J+9dSapm6RsYQTJatiRkXAe3jF3Da/B7LqrOkvtW541mZbqP3VWiBvIIr n42XM4zmT+BPaFXfW8ekQzRHIMTlCSRz0YuQBkn0Vsn+QlnyPivVf6im72N6p8CnVoUL jBIA== X-Gm-Message-State: AJcUukfzniY6LLWo88uDGOZK8DwWojN8FV2jpyIg2doUWLV3Yt1Fh+xB 8R9cyC1c+ft9jt5XJEzHc292eORC5uDPepbDz+undej4/Z3FeVxXw3p9plMm+2M/Uopip/4sOmz wKXVqNkRcRrA7RNZSGXc3m8cko1xatLoBleVMHvB2jA== X-Received: by 2002:a62:d448:: with SMTP id u8mr5193720pfl.105.1548311147380; Wed, 23 Jan 2019 22:25:47 -0800 (PST) X-Google-Smtp-Source: ALg8bN4b8p7K4IyMvgSL+z9jbw7RQ6JQaFIstEeWcRjkH/Mj7ylrOzNQwF8E+6lPSqisfb7jGKJe/g== X-Received: by 2002:a62:d448:: with SMTP id u8mr5193696pfl.105.1548311146961; Wed, 23 Jan 2019 22:25:46 -0800 (PST) Received: from 2001-b011-380f-13aa-18a3-1f83-e8c3-1f13.dynamic-ip6.hinet.net (2001-b011-380f-13aa-18a3-1f83-e8c3-1f13.dynamic-ip6.hinet.net. [2001:b011:380f:13aa:18a3:1f83:e8c3:1f13]) by smtp.gmail.com with ESMTPSA id l85sm33173391pfg.161.2019.01.23.22.25.45 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 23 Jan 2019 22:25:46 -0800 (PST) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 12.2 \(3445.102.3\)) Subject: Re: [PATCH] platform/x86: dell-wmi: Ignore new keyboard backlight change event From: Kai-Heng Feng In-Reply-To: <20181212140607.nrawhff2rgn5ykja@pali> Date: Thu, 24 Jan 2019 14:25:43 +0800 Cc: =?utf-8?Q?Pali_Roh=C3=A1r?= , mjg59@srcf.ucam.org, andy@infradead.org, Mario Limonciello , platform-driver-x86@vger.kernel.org, lkml Content-Transfer-Encoding: 8BIT Message-Id: <60649833-A007-4821-9A35-8F420B5F9714@canonical.com> References: <20181212064125.25137-1-kai.heng.feng@canonical.com> <20181212140607.nrawhff2rgn5ykja@pali> To: dvhart@infradead.org X-Mailer: Apple Mail (2.3445.102.3) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Darren, > On Dec 12, 2018, at 22:06, Pali Rohár wrote: > > On Wednesday 12 December 2018 14:41:25 Kai-Heng Feng wrote: >> There's a new wmi event generated by dell-wmi when pressing keyboard >> backlight hotkey: >> [ 3285.474172] dell_wmi: Unknown key with type 0x0010 and code 0x003f pressed >> >> This event is for notification purpose, let's ignore it. The keyboard >> backlight hotkey uses another event so it still works without event >> 0x3f. >> >> Signed-off-by: Kai-Heng Feng >> --- >> drivers/platform/x86/dell-wmi.c | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/drivers/platform/x86/dell-wmi.c b/drivers/platform/x86/dell-wmi.c >> index 16c7f3d9a335..c3166ba73e9a 100644 >> --- a/drivers/platform/x86/dell-wmi.c >> +++ b/drivers/platform/x86/dell-wmi.c >> @@ -267,6 +267,9 @@ static const struct key_entry dell_wmi_keymap_type_0010[] = { >> /* Fn-lock switched to multimedia keys */ >> { KE_IGNORE, 0x1, { KEY_RESERVED } }, >> >> + /* Keyboard backlight change notification */ >> + { KE_IGNORE, 0x3f, { KEY_RESERVED } }, >> + >> /* Mic mute */ >> { KE_KEY, 0x150, { KEY_MICMUTE } }, >> > > Looks good. > > Reviewed-by: Pali Rohár Please merge this patch, thanks. Kai-Heng > > -- > Pali Rohár > pali.rohar@gmail.com