From: John Fastabend <john.fastabend@gmail.com>
To: Pedro Tammela <pctammela@gmail.com>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Andrii Nakryiko <andrii@kernel.org>,
Martin KaFai Lau <kafai@fb.com>, Song Liu <songliubraving@fb.com>,
Yonghong Song <yhs@fb.com>,
John Fastabend <john.fastabend@gmail.com>,
KP Singh <kpsingh@kernel.org>, Shuah Khan <shuah@kernel.org>,
Pedro Tammela <pctammela@mojatatu.com>,
David Verbeiren <david.verbeiren@tessares.net>,
Matthieu Baerts <matthieu.baerts@tessares.net>,
"(open list:BPF \\(Safe dynamic programs and tools\\))"
<netdev@vger.kernel.org>,
bpf@vger.kernel.org (open list:BPF \(Safe dynamic programs and
tools\)),
"(open list:BPF \\(Safe dynamic programs and tools\\) open
list)" <linux-kernel@vger.kernel.org>,
"(open list:BPF \\(Safe dynamic programs and tools\\) open list
open list:KERNEL SELFTEST FRAMEWORK)"
<linux-kselftest@vger.kernel.org> (open list:BPF \(Safe dynamic
programs and tools\) open list open list:KERNEL SELFTEST
FRAMEWORK)
Subject: RE: [PATCH bpf-next 2/3] libbpf: selftests: refactor 'BPF_PERCPU_TYPE()' and 'bpf_percpu()' macros
Date: Mon, 05 Apr 2021 22:14:37 -0700 [thread overview]
Message-ID: <606bee3dd51_d4646208fe@john-XPS-13-9370.notmuch> (raw)
In-Reply-To: <20210404200256.300532-3-pctammela@mojatatu.com>
Pedro Tammela wrote:
> This macro was refactored out of the bpf selftests.
>
> Since percpu values are rounded up to '8' in the kernel, a careless
> user in userspace might encounter unexpected values when parsing the
> output of the batched operations.
>
> Now that both array and hash maps have support for batched ops in the
> percpu variant, let's provide a convenient macro to declare percpu map
> value types.
>
> Updates the tests to a "reference" usage of the new macro.
>
> Signed-off-by: Pedro Tammela <pctammela@mojatatu.com>
> ---
Other than the initial patch needing a bit of description the series
looks good to me. Thanks.
next prev parent reply other threads:[~2021-04-06 5:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-04 20:02 [PATCH bpf-next 0/3] add batched ops support for percpu array Pedro Tammela
2021-04-04 20:02 ` [PATCH bpf-next 1/3] bpf: " Pedro Tammela
2021-04-06 1:42 ` John Fastabend
2021-04-04 20:02 ` [PATCH bpf-next 2/3] libbpf: selftests: refactor 'BPF_PERCPU_TYPE()' and 'bpf_percpu()' macros Pedro Tammela
2021-04-06 5:14 ` John Fastabend [this message]
2021-04-04 20:02 ` [PATCH bpf-next 3/3] bpf: selftests: update array map tests for per-cpu batched ops Pedro Tammela
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=606bee3dd51_d4646208fe@john-XPS-13-9370.notmuch \
--to=john.fastabend@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=david.verbeiren@tessares.net \
--cc=kafai@fb.com \
--cc=kpsingh@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=matthieu.baerts@tessares.net \
--cc=netdev@vger.kernel.org \
--cc=pctammela@gmail.com \
--cc=pctammela@mojatatu.com \
--cc=shuah@kernel.org \
--cc=songliubraving@fb.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).