From: Neil Armstrong <narmstrong@baylibre.com>
To: Paul Gortmaker <paul.gortmaker@windriver.com>,
linux-kernel@vger.kernel.org
Cc: Philipp Zabel <p.zabel@pengutronix.de>,
Carlo Caione <carlo@caione.org>,
Kevin Hilman <khilman@baylibre.com>,
linux-amlogic@lists.infradead.org
Subject: Re: [PATCH 3/4] reset: meson: make it explicitly non-modular
Date: Wed, 8 Feb 2017 09:43:43 +0100 [thread overview]
Message-ID: <6070b3ca-95f3-6be8-d0e0-afa6a34c6def@baylibre.com> (raw)
In-Reply-To: <20170208001847.9887-4-paul.gortmaker@windriver.com>
On 02/08/2017 01:18 AM, Paul Gortmaker wrote:
> The Kconfig currently controlling compilation of this code is:
>
> arch/arm/mach-meson/Kconfig:menuconfig ARCH_MESON
> arch/arm/mach-meson/Kconfig: bool "Amlogic Meson SoCs"
>
> arch/arm64/Kconfig.platforms:config ARCH_MESON
> arch/arm64/Kconfig.platforms: bool "Amlogic Platforms"
>
> ...meaning that it currently is not being built as a module by anyone.
>
> Lets remove the modular code that is essentially orphaned, so that
> when reading the driver there is no doubt it is builtin-only.
>
> Since module_platform_driver() uses the same init level priority as
> builtin_platform_driver() the init ordering remains unchanged with
> this commit.
>
> Also note that MODULE_DEVICE_TABLE is a no-op for non-modular code.
>
> We also delete the MODULE_LICENSE tag etc. since all that information
> was (or is now) contained at the top of the file in the comments.
>
> Cc: Philipp Zabel <p.zabel@pengutronix.de>
> Cc: Carlo Caione <carlo@caione.org>
> Cc: Kevin Hilman <khilman@baylibre.com>
> Cc: linux-amlogic@lists.infradead.org
> Cc: Neil Armstrong <narmstrong@baylibre.com>
> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
> ---
> drivers/reset/reset-meson.c | 12 ++++--------
> 1 file changed, 4 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/reset/reset-meson.c b/drivers/reset/reset-meson.c
> index c32f11a30c5f..a8b915eb8b58 100644
> --- a/drivers/reset/reset-meson.c
> +++ b/drivers/reset/reset-meson.c
> @@ -1,4 +1,6 @@
> /*
> + * Amlogic Meson Reset Controller driver
> + *
> * This file is provided under a dual BSD/GPLv2 license. When using or
> * redistributing this file, you may do so under either license.
> *
> @@ -53,7 +55,7 @@
> * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
> */
> #include <linux/err.h>
> -#include <linux/module.h>
> +#include <linux/init.h>
> #include <linux/io.h>
> #include <linux/of.h>
> #include <linux/platform_device.h>
> @@ -95,7 +97,6 @@ static const struct of_device_id meson_reset_dt_ids[] = {
> { .compatible = "amlogic,meson-gxbb-reset", },
> { /* sentinel */ },
> };
> -MODULE_DEVICE_TABLE(of, meson_reset_dt_ids);
>
> static int meson_reset_probe(struct platform_device *pdev)
> {
> @@ -128,9 +129,4 @@ static struct platform_driver meson_reset_driver = {
> .of_match_table = meson_reset_dt_ids,
> },
> };
> -
> -module_platform_driver(meson_reset_driver);
> -
> -MODULE_AUTHOR("Neil Armstrong <narmstrong@baylibre.com>");
> -MODULE_DESCRIPTION("Amlogic Meson Reset Controller driver");
> -MODULE_LICENSE("Dual BSD/GPL");
> +builtin_platform_driver(meson_reset_driver);
>
Acked-by: Neil Armstrong <narmstrong@baylibre.com>
next prev parent reply other threads:[~2017-02-08 8:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-08 0:18 [PATCH 0/4] reset: de-modularize the remaining reset drivers Paul Gortmaker
2017-02-08 0:18 ` [PATCH 1/4] reset: ath79: make it explicitly non-modular Paul Gortmaker
2017-02-09 9:03 ` Alban
2017-02-08 0:18 ` [PATCH 2/4] reset: pistachio: " Paul Gortmaker
2017-02-08 0:18 ` [PATCH 3/4] reset: meson: " Paul Gortmaker
2017-02-08 8:43 ` Neil Armstrong [this message]
2017-02-08 0:18 ` [PATCH 4/4] reset: oxnas: " Paul Gortmaker
2017-02-08 8:44 ` Neil Armstrong
2017-02-08 10:43 ` [PATCH 0/4] reset: de-modularize the remaining reset drivers Philipp Zabel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6070b3ca-95f3-6be8-d0e0-afa6a34c6def@baylibre.com \
--to=narmstrong@baylibre.com \
--cc=carlo@caione.org \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=paul.gortmaker@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).