From: Coly Li <colyli@suse.de>
To: Hannes Reinecke <hare@suse.de>, linux-kernel@vger.kernel.org
Cc: linux-bcache@vger.kernel.org, linux-block@vger.kernel.org,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Luis R . Rodriguez" <mcgrof@suse.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Thomas Gleixner <tglx@linutronix.de>,
Michael Lyle <mlyle@lyle.org>,
Kent Overstreet <kent.overstreet@gmail.com>,
Kate Stewart <kstewart@linuxfoundation.org>
Subject: Re: [PATCH 0/4] add crc64 calculation as kernel library
Date: Tue, 17 Jul 2018 14:19:30 +0800 [thread overview]
Message-ID: <608100d7-6e98-13ec-57ab-5c672131e332@suse.de> (raw)
In-Reply-To: <8538b45b-bf30-926a-50fb-700b4bf1c636@suse.de>
On 2018/7/17 1:46 PM, Hannes Reinecke wrote:
> On 07/16/2018 06:55 PM, Coly Li wrote:
>> This patch set adds basic implementation of crc64 calculation as Linux
>> kernel library. Since bcache already does crc64 by itself, this patch
>> set also modifies bcache code to use the new crc64 library routine.
>>
>> bcache uses crc64 as storage checksum, if a change of crc lib routines
>> results an inconsistent result, the unmatched checksum may make bcache
>> 'think' the on-disk is corrupted, such change should be avoided or
>> detected as early as possible. Therefore the last patch in this series
>> adds a crc test framework, to check consistency of different calculations.
>>
>> Coly Li
>>
>> Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>> Cc: Luis R. Rodriguez <mcgrof@suse.com>
>> Cc: Linus Torvalds <torvalds@linux-foundation.org>
>> Cc: Thomas Gleixner <tglx@linutronix.de>
>> Cc: Michael Lyle <mlyle@lyle.org>
>> Cc: Kent Overstreet <kent.overstreet@gmail.com>
>> Cc: Kate Stewart <kstewart@linuxfoundation.org>
>> ---
>> Andy Shevchenko (1):
>> lib/crc64: add crc64 option to lib/Kconfig
>>
>> Coly Li (3):
>> lib: add crc64 calculation routines
>> bcache: use routines from lib/crc64.c for CRC64 calculation
>> lib/test_crc: Add test cases for crc calculation
>>
>> drivers/md/bcache/bcache.h | 7 +-
>> drivers/md/bcache/btree.c | 2 +-
>> drivers/md/bcache/request.c | 2 +-
>> drivers/md/bcache/super.c | 5 +-
>> drivers/md/bcache/util.c | 131 ----------------------------------
>> drivers/md/bcache/util.h | 5 +-
>> include/linux/crc64.h | 15 ++++
>> lib/.gitignore | 2 +
>> lib/Kconfig | 8 +++
>> lib/Kconfig.debug | 11 +++
>> lib/Makefile | 12 ++++
>> lib/crc64.c | 71 +++++++++++++++++++
>> lib/gen_crc64table.c | 76 ++++++++++++++++++++
>> lib/test_crc.c | 136 ++++++++++++++++++++++++++++++++++++
>> 14 files changed, 341 insertions(+), 142 deletions(-)
>> create mode 100644 include/linux/crc64.h
>> create mode 100644 lib/crc64.c
>> create mode 100644 lib/gen_crc64table.c
>> create mode 100644 lib/test_crc.c
>>
Hi Hannes,
> Actually, I would merge patch 1 & 2 together (pointless to introduce an
> option for which no code exists).
The patch 1 was originally from Andy Shevchenko, and I want to keep his
contribute. If it seems not a good idea from me, I will merge them into
1 patch in v2 series.
> Otherwise for the whole series:
>
> Reviewed-by: Hannes Reinecke <hare@suse.com>
Thanks.
Coly Li
next prev parent reply other threads:[~2018-07-17 6:19 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-16 16:55 [PATCH 0/4] add crc64 calculation as kernel library Coly Li
2018-07-16 16:55 ` [PATCH 1/4] lib/crc64: add crc64 option to lib/Kconfig Coly Li
2018-07-16 17:48 ` Randy Dunlap
2018-07-17 3:16 ` Coly Li
2018-07-16 16:55 ` [PATCH 2/4] lib: add crc64 calculation routines Coly Li
2018-07-16 17:57 ` Randy Dunlap
2018-07-17 3:19 ` Coly Li
2018-07-17 1:27 ` kbuild test robot
2018-07-17 3:34 ` Eric Biggers
2018-07-17 6:25 ` Coly Li
2018-07-17 7:13 ` Eric Biggers
2018-07-17 7:34 ` Coly Li
2018-07-17 14:29 ` Coly Li
2018-07-16 16:55 ` [PATCH 3/4] bcache: use routines from lib/crc64.c for CRC64 calculation Coly Li
2018-07-16 16:55 ` [PATCH 4/4] lib/test_crc: Add test cases for crc calculation Coly Li
2018-07-16 18:05 ` Randy Dunlap
2018-07-17 3:37 ` Coly Li
2018-07-16 20:47 ` Andy Shevchenko
2018-07-17 4:38 ` Coly Li
2018-07-17 5:46 ` [PATCH 0/4] add crc64 calculation as kernel library Hannes Reinecke
2018-07-17 6:19 ` Coly Li [this message]
2018-07-17 8:37 ` Andy Shevchenko
2018-07-17 14:20 ` Coly Li
2018-07-17 6:57 Coly Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=608100d7-6e98-13ec-57ab-5c672131e332@suse.de \
--to=colyli@suse.de \
--cc=andriy.shevchenko@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=hare@suse.de \
--cc=kent.overstreet@gmail.com \
--cc=kstewart@linuxfoundation.org \
--cc=linux-bcache@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mcgrof@suse.com \
--cc=mlyle@lyle.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).