From: Karolina Drobnik <karolinadrobnik@gmail.com>
To: Julia Lawall <julia.lawall@inria.fr>
Cc: outreachy-kernel@googlegroups.com, gregkh@linuxfoundation.org,
forest@alittletooquiet.net, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [Outreachy kernel] [PATCH] staging: vt6655: Rename `by_preamble_type` parameter
Date: Wed, 20 Oct 2021 13:54:27 +0100 [thread overview]
Message-ID: <6089e564f89ceaa7303bf3a4b4c864bf1389ac25.camel@gmail.com> (raw)
In-Reply-To: <alpine.DEB.2.22.394.2110201051300.2930@hadrien>
On Wed, 2021-10-20 at 10:54 +0200, Julia Lawall wrote:
> On Wed, 20 Oct 2021, Karolina Drobnik wrote:
>
> > Drop `by` prefix in the first parameter of `bb_get_frame_time`
> > function.
> > As the original argument, `byPreambleType`, was renamed to
> > `preamble_type`,
> > the parameter referring to it is now renamed to match the new
> > naming
> > convention.
> > Update `bb_get_frame_time` comment to reflect that change.
> >
> > This patch is a follow-up work to this commit:
> > Commit 548b6d7ebfa4 ("staging: vt6655: Rename byPreambleType
> > field")
>
> This is not going to be practical. If the previous patch is
> accepted, then this it not needed.
This change was there before but Greg told me to do only one logical
change per patch (which was a struct member rename), so I reverted it.
I believe this is needed because this parameter still uses Hungarian
notation, which is against the LK coding style. Also, it makes sense to
update the name given my previous change.
> there needs to be a vn+1 putting the patches together into a series.
I didn't know that it should be send this way, especially given the
fact that Outreachy applicants should first get 3-5 patches out before
creating a patchset. Or has something changed in this regard?
> > @@ -1691,7 +1691,7 @@ static const unsigned short
> > awc_frame_time[MAX_RATE] = {
> > *
> > * Parameters:
> > * In:
> > - * by_preamble_type - Preamble Type
> > + * preamble_type - Preamble Type
> > * by_pkt_type - PK_TYPE_11A, PK_TYPE_11B,
> > PK_TYPE_11GB, PK_TYPE_11GA
>
> In the realm of small cleanups to this driver, the extra space in
> front of the - above is a bit annoying.
I can add this in but will that still count as a one logical change?
I described the comment update, will that suffice?
> > @@ -1717,7 +1717,7 @@ unsigned int bb_get_frame_time(unsigned char
> > by_preamble_type,
> > rate = (unsigned int)awc_frame_time[rate_idx];
> >
> > if (rate_idx <= 3) { /* CCK mode */
> > - if (by_preamble_type == 1) /* Short */
> > + if (preamble_type == 1) /* Short */
>
> I hope you will get around to replacing the 1 by the appropriate
> constant and removing the "Short" comment.
I plan to do so after correcting the name variable.
On Wed, 2021-10-20 at 10:55 +0200, Greg KH wrote:
> On Wed, Oct 20, 2021 at 09:40:33AM +0100, Karolina Drobnik wrote:
> > Drop `by` prefix in the first parameter of `bb_get_frame_time`
> > function.
> > As the original argument, `byPreambleType`, was renamed to
> > `preamble_type`,
> > the parameter referring to it is now renamed to match the new
> > naming
> > convention.
> > Update `bb_get_frame_time` comment to reflect that change.
> >
> > This patch is a follow-up work to this commit:
> > Commit 548b6d7ebfa4 ("staging: vt6655: Rename byPreambleType
> > field")
>
> There is no need for these two lines in the changelog text. They can
> go
> below --- if you want to have them.
Thank you for clarifying this. I've been following the Submitting
Patches docs[1] and thought this is needed.
Thanks,
Karolina
-------------------------------------------------------------------
[1]:
https://elixir.bootlin.com/linux/latest/source/Documentation/process/submitting-patches.rst#L106
next prev parent reply other threads:[~2021-10-20 12:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-20 8:40 [PATCH] staging: vt6655: Rename `by_preamble_type` parameter Karolina Drobnik
2021-10-20 8:54 ` [Outreachy kernel] " Julia Lawall
2021-10-20 12:54 ` Karolina Drobnik [this message]
2021-10-20 12:59 ` Julia Lawall
2021-10-20 13:08 ` Karolina Drobnik
2021-10-20 8:55 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6089e564f89ceaa7303bf3a4b4c864bf1389ac25.camel@gmail.com \
--to=karolinadrobnik@gmail.com \
--cc=forest@alittletooquiet.net \
--cc=gregkh@linuxfoundation.org \
--cc=julia.lawall@inria.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=outreachy-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).