From: Benjamin GAIGNARD <benjamin.gaignard@st.com>
To: Rob Herring <robh+dt@kernel.org>
Cc: "Thierry Reding" <thierry.reding@gmail.com>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Mark Rutland" <mark.rutland@arm.com>,
"Linux PWM List" <linux-pwm@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] dt-bindings: pwm: fix nodename pattern
Date: Thu, 12 Dec 2019 08:16:47 +0000 [thread overview]
Message-ID: <60921a82-9241-9c6e-0a17-0bd93dc52978@st.com> (raw)
In-Reply-To: <CAL_JsqJKWoX_kY2kSieOA-wXO5xKtDbhXPMCjg-d4FHHEvOmHg@mail.gmail.com>
On 12/11/19 8:52 PM, Rob Herring wrote:
> On Wed, Dec 11, 2019 at 9:00 AM Benjamin Gaignard
> <benjamin.gaignard@st.com> wrote:
>> Typical pwm nodes should be named pwm@xxx.
>> The pattern shouldn't match nodes named pwm-xxx to avoid
>> conflicts with pinmux or pwm-fan nodes.
> It only matches pwm-$(a-hex-number), not any string, so that shouldn't
> be a problem. This is needed for things like GPIO based devices (not
> just PWMs) which don't have any address.
>
> Pinmux nodes are going to need to adopt some sort of standard pattern
> we can match on.
I have push a patch to stop using '@' and '_' in pinmux groups names:
https://lore.kernel.org/patchwork/patch/1162591/
It remove the warnings when compiling the devicetre with W=12 but pwm.yaml
complain because pwm pinmux is named pwm-1.
How can I solve these issues at the same time ?
Benjamin
>
>> Signed-off-by: Benjamin Gaignard <benjamin.gaignard@st.com>
>> ---
>> Documentation/devicetree/bindings/pwm/pwm.yaml | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/Documentation/devicetree/bindings/pwm/pwm.yaml b/Documentation/devicetree/bindings/pwm/pwm.yaml
>> index fa4f9de92090..29b86886c282 100644
>> --- a/Documentation/devicetree/bindings/pwm/pwm.yaml
>> +++ b/Documentation/devicetree/bindings/pwm/pwm.yaml
>> @@ -11,7 +11,7 @@ maintainers:
>>
>> properties:
>> $nodename:
>> - pattern: "^pwm(@.*|-[0-9a-f])*$"
>> + pattern: "^pwm(@.*[0-9a-f])*$"
>>
>> "#pwm-cells":
>> description:
>> --
>> 2.15.0
>>
next prev parent reply other threads:[~2019-12-12 8:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-11 15:00 [PATCH] dt-bindings: pwm: fix nodename pattern Benjamin Gaignard
2019-12-11 19:52 ` Rob Herring
2019-12-12 8:16 ` Benjamin GAIGNARD [this message]
2019-12-12 19:07 ` Rob Herring
2019-12-13 11:09 ` Benjamin GAIGNARD
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=60921a82-9241-9c6e-0a17-0bd93dc52978@st.com \
--to=benjamin.gaignard@st.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=thierry.reding@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).