Re: [PATCH 0/3] Update ASUS WMI supported boards.

From: Oleksandr Natalenko <oleksandr@natalenko.name>
To: Denis Pauk <pauk.denis@gmail.com>
Cc: pauk.denis@gmail.com, Eugene Shalygin <eugene.shalygin@gmail.com>,
	matt-testalltheway <sefoci9222@rerunway.com>,
	Kamil Dudka <kdudka@redhat.com>,
	Robert Swiecki <robert@swiecki.net>,
	Kamil Pietrzak <kpietrzak@disroot.org>, Igor <igor@svelig.com>,
	Tor Vic <torvic9@mailbox.org>, Poezevara <nephartyz@gmail.com>,
	Andy Shevchenko <andriy.shevchenko@intel.com>,
	Guenter Roeck <linux@roeck-us.net>,
	Jean Delvare <jdelvare@suse.com>,
	linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org
Subject: Re: [PATCH 0/3] Update ASUS WMI supported boards.
Date: Sun, 03 Oct 2021 13:50:12 +0200	[thread overview]
Message-ID: <6096864.rdmfHhMOLH@natalenko.name> (raw)
In-Reply-To: <20211002210857.709956-1-pauk.denis@gmail.com>

Hello.

On sobota 2. října 2021 23:08:53 CEST Denis Pauk wrote:
> Add support to nct6775:
> * PRIME B360-PLUS
> * PRIME X570-PRO
> * ROG CROSSHAIR VIII FORMULA
> * ROG STRIX B550-I GAMING
> * ROG STRIX X570-F GAMING
> * ROG STRIX Z390-E GAMING
> * TUF GAMING B550-PRO
> * TUF GAMING Z490-PLUS
> * TUF GAMING Z490-PLUS (WI-FI)

Thank you for this submission.

Do you happen to know whether it can be extended with another ASUS board which 
is:

```
Manufacturer: ASUSTeK COMPUTER INC.
Product Name: Pro WS X570-ACE
```

?

I've got one, and in case any info or testing is needed, I'd be happy to 
contribute.

Currently, this board is kinda working after adding 
`acpi_enforce_resources=lax`, but I assume a proper support is needed instead.

Thanks.

> Add sensors driver for ASUS motherboards to read sensors from the embedded
> controller. Based on https://github.com/zeule/asus-wmi-ec-sensors.
> 
> Could you please review?
> 
> @Andy Shevchenko, @Guenter Roeck should I split last patch in some way?
> Should I add to MAINTAINERS:
> --
> ASUS WMI HARDWARE MONITOR DRIVER
> M:     Eugene Shalygin <eugene.shalygin@gmail.com>
> M:     Denis Pauk <pauk.denis@gmail.com>
> L:     linux-hwmon@vger.kernel.org
> S:     Maintained
> F:     drivers/hwmon/asus_wmi_sensors.c
> --
> 
> 
> BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=204807
> Signed-off-by: Denis Pauk <pauk.denis@gmail.com>
> Co-developed-by: Eugene Shalygin <eugene.shalygin@gmail.com>
> Signed-off-by: Eugene Shalygin <eugene.shalygin@gmail.com>
> Tested-by: matt-testalltheway <sefoci9222@rerunway.com>
> Tested-by: Kamil Dudka <kdudka@redhat.com>
> Tested-by: Robert Swiecki <robert@swiecki.net>
> Tested-by: Kamil Pietrzak <kpietrzak@disroot.org>
> Tested-by: Igor <igor@svelig.com>
> Tested-by: Tor Vic <torvic9@mailbox.org>
> Tested-by: Poezevara <nephartyz@gmail.com>
> Cc: Andy Shevchenko <andriy.shevchenko@intel.com>
> Cc: Guenter Roeck <linux@roeck-us.net>
> 
> ---
> Denis Pauk (3):
>   hwmon: (nct6775) Add additional ASUS motherboards.
>   hwmon: (nct6775) Use custom scale for ASUS motherboards.
>   hwmon: (asus_wmi_sensors) Support access via Asus WMI.
> 
>  drivers/hwmon/Kconfig            |  12 +
>  drivers/hwmon/Makefile           |   1 +
>  drivers/hwmon/asus_wmi_sensors.c | 595 +++++++++++++++++++++++++++++++
>  drivers/hwmon/nct6775.c          |  41 ++-
>  4 files changed, 643 insertions(+), 6 deletions(-)
>  create mode 100644 drivers/hwmon/asus_wmi_sensors.c

-- 
Oleksandr Natalenko (post-factum)